[Bug tree-optimization/46193] New: ICE: in omp_reduction_init, at omp-low.c:2212 with -ftree-parallelize-loops

[Bug tree-optimization/46193] New: ICE: in omp_reduction_init, at omp-low.c:2212 with -ftree-parallelize-loops

[zsojka at seznam dot cz]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46193

           Summary: ICE: in omp_reduction_init, at omp-low.c:2212 with
                    -ftree-parallelize-loops
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: zsojka@seznam.cz


Created attachment 22167
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22167
reduced testcase (from gcc.dg/torture/pr45869.c)

Compiler output:
$ gcc -O -ftree-parallelize-loops=2 pr46193.c 
pr46193.c: In function 'foo':
pr46193.c:1:7: internal compiler error: in omp_reduction_init, at
omp-low.c:2212
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

Tested revisions:
r165915 - crash
4.5 r165781 - crash
4.4 r165754 - crash
4.4 r149995 - crash

[Bug tree-optimization/46193] ICE: in omp_reduction_init, at omp-low.c:2212 with -ftree-parallelize-loops

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46193

Uros Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2010.10.30 21:15:40
     Ever Confirmed|0                           |1

--- Comment #1 from Uros Bizjak <ubizjak at gmail dot com> 2010-10-30 21:15:40 UTC ---
Confirmed with 4.6.0, backtrace:

(gdb) bt
#0  fancy_abort (file=0xd11c58 "../../gcc-svn/trunk/gcc/omp-low.c", line=2212, 
    function=0xd138e0 "omp_reduction_init")
    at ../../gcc-svn/trunk/gcc/diagnostic.c:880
#1  0x0000000000708873 in omp_reduction_init (clause=<value optimized out>, 
    type=0x7ffff2054930) at ../../gcc-svn/trunk/gcc/omp-low.c:2212
#2  0x000000000082a13a in initialize_reductions (slot=<value optimized out>, 
    data=0x7ffff2036b28) at ../../gcc-svn/trunk/gcc/tree-parloops.c:415
#3  0x0000000000c9c1d8 in htab_traverse_noresize (htab=<value optimized out>, 
    callback=0x82a070 <initialize_reductions>, info=0x7ffff2036b28)
    at ../../gcc-svn/trunk/libiberty/hashtab.c:784
#4  0x000000000082c09e in gen_parallel_loop (loop=<value optimized out>, 
    reduction_list=0x1389f00, n_threads=2, niter=<value optimized out>)
    at ../../gcc-svn/trunk/gcc/tree-parloops.c:1640
#5  0x000000000082d58b in parallelize_loops ()
    at ../../gcc-svn/trunk/gcc/tree-parloops.c:1976
#6  0x00000000008ae469 in tree_parallelize_loops ()
    at ../../gcc-svn/trunk/gcc/tree-ssa-loop.c:589

[Bug tree-optimization/46193] ICE: in omp_reduction_init, at omp-low.c:2212 with -ftree-parallelize-loops

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46193

--- Comment #2 from Uros Bizjak <ubizjak at gmail dot com> 2010-10-30 21:18:05 UTC ---
We have pointer type that triggers assert:

#1  0x0000000000708873 in omp_reduction_init (clause=<value optimized out>, 
    type=0x7ffff2054930) at ../../gcc-svn/trunk/gcc/omp-low.c:2212
2212          gcc_assert (INTEGRAL_TYPE_P (type));
(gdb) p debug_generic_expr (type)
char *
$1 = void

[Bug tree-optimization/46193] ICE: in omp_reduction_init, at omp-low.c:2212 with -ftree-parallelize-loops

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=46193

vries at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vries at gcc dot gnu.org

--- Comment #3 from vries at gcc dot gnu.org ---
Created attachment 35962
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35962&action=edit
Tentative patch

[Bug tree-optimization/46193] ICE: in omp_reduction_init, at omp-low.c:2212 with -ftree-parallelize-loops

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=46193

vries at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #4 from vries at gcc dot gnu.org ---
https://gcc.gnu.org/ml/gcc-patches/2015-07/msg01018.html

[Bug tree-optimization/46193] ICE: in omp_reduction_init, at omp-low.c:2212 with -ftree-parallelize-loops

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=46193

--- Comment #5 from vries at gcc dot gnu.org ---
pinged patch 2015-07-22:
https://gcc.gnu.org/ml/gcc-patches/2015-07/msg01883.html

[Bug tree-optimization/46193] ICE: in omp_reduction_init, at omp-low.c:2212 with -ftree-parallelize-loops

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=46193

--- Comment #6 from vries at gcc dot gnu.org ---
Author: vries
Date: Mon Jul 27 23:46:16 2015
New Revision: 226289

URL: https://gcc.gnu.org/viewcvs?rev=226289&root=gcc&view=rev
Log:
Handle mix/max pointer reductions in parloops

2015-07-28  Tom de Vries  <tom@codesourcery.com>

        PR tree-optimization/46193
        * omp-low.c (omp_reduction_init): Handle pointer type for min or max
        clause.

        * gcc.dg/autopar/pr46193.c: New test.

        * testsuite/libgomp.c/pr46193.c: New test.

Added:
    branches/gomp-4_0-branch/gcc/testsuite/gcc.dg/autopar/pr46193.c
    branches/gomp-4_0-branch/libgomp/testsuite/libgomp.c/pr46193.c
Modified:
    branches/gomp-4_0-branch/gcc/ChangeLog.gomp
    branches/gomp-4_0-branch/gcc/omp-low.c
    branches/gomp-4_0-branch/gcc/testsuite/ChangeLog.gomp
    branches/gomp-4_0-branch/libgomp/ChangeLog.gomp

[Bug tree-optimization/46193] ICE: in omp_reduction_init, at omp-low.c:2212 with -ftree-parallelize-loops

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=46193

--- Comment #7 from vries at gcc dot gnu.org ---
ping^2: https://gcc.gnu.org/ml/gcc-patches/2015-08/msg01423.html

[Bug tree-optimization/46193] ICE: in omp_reduction_init, at omp-low.c:2212 with -ftree-parallelize-loops

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=46193

--- Comment #8 from vries at gcc dot gnu.org ---
Author: vries
Date: Sat Aug 29 07:07:51 2015
New Revision: 227315

URL: https://gcc.gnu.org/viewcvs?rev=227315&root=gcc&view=rev
Log:
Handle mix/max pointer reductions in parloops

2015-08-29  Tom de Vries  <tom@codesourcery.com>

        PR tree-optimization/46193
        * omp-low.c (omp_reduction_init): Handle pointer type for min or max
        clause.

        * gcc.dg/autopar/pr46193.c: New test.

        * testsuite/libgomp.c/pr46193.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/autopar/pr46193.c
    trunk/libgomp/testsuite/libgomp.c/pr46193.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/omp-low.c
    trunk/gcc/testsuite/ChangeLog
    trunk/libgomp/ChangeLog

[Bug tree-optimization/46193] ICE: in omp_reduction_init, at omp-low.c:2212 with -ftree-parallelize-loops

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=46193

vries at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from vries at gcc dot gnu.org ---
patch and test-case committed, marking resolved-fixed