public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "sebpop at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/46194] [4.5/4.6 Regression] gcc.dg/graphite/block-0.c FAILs with -ftree-parallelize-loops
Date: Thu, 03 Feb 2011 19:55:00 -0000	[thread overview]
Message-ID: <bug-46194-4-aLgtMw2BSU@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-46194-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46194

--- Comment #9 from sebpop at gmail dot com <sebpop at gmail dot com> 2011-02-03 19:54:36 UTC ---
>>  access_fn_A: {0, +, 1}_1
>>  access_fn_B: {0, +, 1}_2
>>
>>  (subscript
>>  iterations_that_access_an_element_twice_in_A: [0 + 1 * x_1]
>>  last_conflict: 1000
>>  iterations_that_access_an_element_twice_in_B: [0 + 1 * x_1]
>
> I think that this representation of affine functions is wrong:
> the access in B should read [0 + 0 * x_1 + 1 * x_2] and that
> would not lead to a wrong conclusion like the following...

This representation is correct, as it stands for: there exists
a dependence for all x_1 from 0 to 1000, that is, there exist
a possible overlap that is represented by:

{0, +, 1}_1 ([0 + 1 * x_1]) == {0, +, 1}_2 ([0 + 1 * x_1])

>
>>  last_conflict: 1000
>>  (Subscript distance: 0
>>  )
>>  )
>>  inner loop index: 0
>>  loop nest: (1 2 )
>>  distance_vector:   0   0
>>  direction_vector:     =    =
>> )
>

This representation is still wrong, and so I went to see where this
was computed, and the bug seems to be in build_classic_dist_vector_1
I will submit a patch to fix this.


  parent reply	other threads:[~2011-02-03 19:55 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-27  0:27 [Bug tree-optimization/46194] New: " zsojka at seznam dot cz
2010-10-27 10:19 ` [Bug tree-optimization/46194] " hjl.tools at gmail dot com
2010-10-27 20:50 ` rguenth at gcc dot gnu.org
2010-11-12 15:19 ` rguenth at gcc dot gnu.org
2010-12-16 13:28 ` rguenth at gcc dot gnu.org
2010-12-31 12:02 ` jakub at gcc dot gnu.org
2011-02-03 18:11   ` Sebastian Pop
2010-12-31 13:09 ` zsojka at seznam dot cz
2011-02-03  8:42 ` jakub at gcc dot gnu.org
2011-02-03 17:34 ` spop at gcc dot gnu.org
2011-02-03 18:11 ` sebpop at gmail dot com
2011-02-03 19:54   ` Sebastian Pop
2011-02-03 18:21 ` spop at gcc dot gnu.org
2011-02-03 19:55 ` sebpop at gmail dot com [this message]
2011-02-04  4:00 ` spop at gcc dot gnu.org
2011-02-05  1:39 ` spop at gcc dot gnu.org
2011-02-05  1:42 ` spop at gcc dot gnu.org
2011-02-07 22:58 ` [Bug tree-optimization/46194] [4.5 " spop at gcc dot gnu.org
2011-04-18 14:44 ` rguenth at gcc dot gnu.org
2011-04-18 16:11 ` spop at gcc dot gnu.org
2011-04-19 16:26 ` spop at gcc dot gnu.org
2011-04-28 16:02 ` rguenth at gcc dot gnu.org
2011-07-26 19:39 ` spop at gcc dot gnu.org
2011-07-27 18:26 ` spop at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-46194-4-aLgtMw2BSU@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).