From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14878 invoked by alias); 2 Oct 2011 17:47:43 -0000 Received: (qmail 14869 invoked by uid 22791); 2 Oct 2011 17:47:43 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from localhost (HELO gcc.gnu.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 02 Oct 2011 17:47:29 +0000 From: "dominiq at lps dot ens.fr" To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/46244] gfc_compare_derived_types is buggy Date: Sun, 02 Oct 2011 17:47:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: fortran X-Bugzilla-Keywords: ice-on-valid-code, patch X-Bugzilla-Severity: normal X-Bugzilla-Who: dominiq at lps dot ens.fr X-Bugzilla-Status: ASSIGNED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: mikael at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2011-10/txt/msg00058.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46244 --- Comment #17 from Dominique d'Humieres 2011-10-02 17:46:44 UTC --- Created attachment 25397 --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=25397 updated patch for revision 179415 The patch in comment #12 no longer applies cleanly (the changes in resolve.c are now obsolete, I have mechanically replaced four times !gfc_compare_types with !gfc_TK_compatible, although it does not introduce regression, this should be checked by someone understanding the code better than I do). I had also to do a similar change in gcc/fortran/check.c to allow move_alloc_5.f90 and select_type_23.f03 to pass (otherwise they fail with Error: 'from' argument of 'move_alloc' intrinsic at (1) must be the same type and kind as 'to' I have also updated null_1.f90. With these changes I had no regression and my tests passed without the glitch reported in comment #13 (the previous patch probably exposed some rampant bug that has been fixed).