[Bug target/46280] New: [4.6 regression] Several testcases FAIL with 16byte alignment ABI warning on Solaris 8/9 x86

[Bug target/46280] New: [4.6 regression] Several testcases FAIL with 16byte alignment ABI warning on Solaris 8/9 x86

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46280

           Summary: [4.6 regression] Several testcases FAIL with 16byte
                    alignment ABI warning on Solaris 8/9 x86
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: ro@gcc.gnu.org
                CC: hjl@gcc.gnu.org
              Host: i386-pc-solaris2.[89]
            Target: i386-pc-solaris2.[89]
             Build: i386-pc-solaris2.[89]


Between 20101022 and 20101029, several testcases started to FAIL on Solaris 8
and 9/x86, e.g. 

+FAIL: g++.dg/eh/simd-2.C (test for excess errors)

Excess errors:
/vol/gcc/src/hg/trunk/local/gcc/testsuite/g++.dg/eh/simd-2.C:13:8: note: The
ABI of passing parameter with 16byte alignment has changed in GCC 4.6

This is almost certainly related to this patch

2010-10-26  H.J. Lu  <hongjiu.lu@intel.com>

    PR target/44948
    * config/i386/i386.c (ix86_old_function_arg_boundary): New.
    (ix86_function_arg_boundary): Always align parameters on stack
    in 64bit and align parameters with alignment >= 16byte on stack
    in 32bit.  Warn alignment change.

and the fact that those targets default to -march=pentiumpro instead of
-march=pentium4, since the tests pass with -march=pentium4.

Here's the list of affected testcases:

g++.dg/eh/simd-2.C
g++.dg/opt/combine.C
g++.dg/torture/pr36444.C
g++.dg/torture/pr36445.C
gcc.c-torture/compile/pr34856.c
gcc.c-torture/compile/pr39928-1.c
gcc.c-torture/compile/vector-1.c
gcc.c-torture/compile/vector-2.c
gcc.c-torture/execute/va-arg-25.c
gcc.c-torture/execute/vector-1.c
gcc.c-torture/execute/vector-2.c
gcc.dg/pr32912-1.c
gcc.dg/tree-ssa/forwprop-5.c
gcc.dg/tree-ssa/fre-vce-1.c
gcc.dg/tree-ssa/sra-4.c
gcc.dg/tree-ssa/vector-1.c
gcc.dg/tree-ssa/vector-2.c
gcc.target/i386/vect-args.c

[Bug target/46280] [4.6 regression] Several testcases FAIL with 16byte alignment ABI warning on Solaris 8/9 x86

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46280

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> 2010-11-02 22:24:07 UTC ---
I believe all those tests are using SSE vectors without
SSE enabled. The warnings are valid. Those tests should
either add -Wno-psabi or enable SSE.

[Bug target/46280] [4.6 regression] Several testcases FAIL with 16byte alignment ABI warning on Solaris 8/9 x86

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46280

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.6.0

[Bug target/46280] [4.6 regression] Several testcases FAIL with 16byte alignment ABI warning on Solaris 8/9 x86

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46280

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2010.11.03 11:25:49
                 CC|                            |ubizjak at gmail dot com
     Ever Confirmed|0                           |1

--- Comment #2 from Rainer Orth <ro at gcc dot gnu.org> 2010-11-03 11:25:49 UTC ---
I can go either way.  Which one would you prefer?

    Rainer

[Bug target/46280] [4.6 regression] Several testcases FAIL with 16byte alignment ABI warning on Solaris 8/9 x86

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46280

--- Comment #3 from Uros Bizjak <ubizjak at gmail dot com> 2010-11-03 11:35:01 UTC ---
(In reply to comment #2)
> I can go either way.  Which one would you prefer?

Please add -msse for all x86 targets for tests that deal with vectors.

[Bug target/46280] [4.6 regression] Several testcases FAIL with 16byte alignment ABI warning on Solaris 8/9 x86

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46280

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2010-11/msg00572.htm
                   |                            |l

--- Comment #4 from Rainer Orth <ro at gcc dot gnu.org> 2010-11-05 19:50:57 UTC ---
Mine, initial patch submitted.

[Bug target/46280] [4.6 regression] Several testcases FAIL with 16byte alignment ABI warning on Solaris 8/9 x86

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46280

--- Comment #5 from Rainer Orth <ro at gcc dot gnu.org> 2010-11-08 17:44:46 UTC ---
Author: ro
Date: Mon Nov  8 17:44:40 2010
New Revision: 166444

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166444
Log:
    gcc:
    * config/i386/i386.c (ix86_function_arg_boundary): Fix warning
    message.

    gcc/testsuite:
    * gcc.dg/pr35442.c: Adapt warning.

    PR target/46280
    * g++.dg/eh/simd-2.C: Add -msse to dg-options, add
    dg-require-effective-target sse_runtime for for i?86-*-*, x86_64-*-*.
    * g++.dg/torture/pr36444.C: Add dg-options -msse for
    i?86-*-* x86_64-*-*.
    * g++.dg/torture/pr36445.C: Likewise.
    * gcc.c-torture/compile/pr34856.c: Likewise.
    * gcc.c-torture/compile/pr39928-1.c: Likewise.
    * gcc.c-torture/compile/vector-1.c: Likewise.
    * gcc.c-torture/compile/vector-2.c: Likewise.
    * gcc.dg/pr32912-1.c: Likewise.
    * gcc.c-torture/execute/va-arg-25.c: Move ...
    * gcc.dg/torture/va-arg-25.c: ... here.
    Add dg-do run.
    Add dg-options -msse, dg-require-effective-target sse_runtime for
    for i?86-*-*, x86_64-*-*.
    * gcc.c-torture/execute/vector-1.c: Likewise.
    * gcc.c-torture/execute/vector-2.c: Likewise.
    * gcc.dg/tree-ssa/forwprop-5.c: Add -msse to dg-options for
    i?86-*-*, x86_64-*-*.
    * gcc.dg/tree-ssa/fre-vce-1.c: Likewise.
    * gcc.dg/tree-ssa/sra-4.c: Likewise.
    * gcc.dg/tree-ssa/vector-1.c: Likewise.
    * gcc.dg/tree-ssa/vector-2.c: Likewise.
    * gcc.target/i386/vect-args.c: Add -Wno-psabi to dg-options.

Added:
    trunk/gcc/testsuite/gcc.dg/torture/va-arg-25.c
      - copied, changed from r166441,
trunk/gcc/testsuite/gcc.c-torture/execute/va-arg-25.c
    trunk/gcc/testsuite/gcc.dg/torture/vector-1.c
      - copied, changed from r166441,
trunk/gcc/testsuite/gcc.c-torture/execute/vector-1.c
    trunk/gcc/testsuite/gcc.dg/torture/vector-2.c
      - copied, changed from r166441,
trunk/gcc/testsuite/gcc.c-torture/execute/vector-2.c
Removed:
    trunk/gcc/testsuite/gcc.c-torture/execute/va-arg-25.c
    trunk/gcc/testsuite/gcc.c-torture/execute/vector-1.c
    trunk/gcc/testsuite/gcc.c-torture/execute/vector-2.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/i386.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/eh/simd-2.C
    trunk/gcc/testsuite/g++.dg/torture/pr36444.C
    trunk/gcc/testsuite/g++.dg/torture/pr36445.C
    trunk/gcc/testsuite/gcc.c-torture/compile/pr34856.c
    trunk/gcc/testsuite/gcc.c-torture/compile/pr39928-1.c
    trunk/gcc/testsuite/gcc.c-torture/compile/vector-1.c
    trunk/gcc/testsuite/gcc.c-torture/compile/vector-2.c
    trunk/gcc/testsuite/gcc.dg/pr32912-1.c
    trunk/gcc/testsuite/gcc.dg/pr35442.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/forwprop-5.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/fre-vce-1.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/sra-4.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/vector-1.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/vector-2.c
    trunk/gcc/testsuite/gcc.target/i386/vect-args.c

[Bug target/46280] [4.6 regression] Several testcases FAIL with 16byte alignment ABI warning on Solaris 8/9 x86

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46280

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
                URL|http://gcc.gnu.org/ml/gcc-p |http://gcc.gnu.org/ml/gcc-p
                   |atches/2010-11/msg00572.htm |atches/2010-11/msg00748.htm
                   |l                           |l
         Resolution|                            |FIXED

--- Comment #6 from Rainer Orth <ro at gcc dot gnu.org> 2010-11-08 17:48:42 UTC ---
Fixed for 4.6.0.