[Bug middle-end/46314] New: frontends use ASM_GENERATE_INTERNAL_LABEL

[Bug middle-end/46314] New: frontends use ASM_GENERATE_INTERNAL_LABEL

[amylaar at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46314

           Summary: frontends use ASM_GENERATE_INTERNAL_LABEL
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: amylaar@gcc.gnu.org


cp/method.c:  ASM_GENERATE_INTERNAL_LABEL (buf, "LTHUNK", thunk_labelno);
java/class.c:  ASM_GENERATE_INTERNAL_LABEL (buf, name, alias_labelno++);  
java/expr.c:  ASM_GENERATE_INTERNAL_LABEL(buf, "LJpc=",
start_label_pc_this_method + pc);
java/expr.c:  ASM_GENERATE_INTERNAL_LABEL(buff, "LJv", l_number);

I currently get a warning building java for picochip because of this issue.

We should have a target hook so that we can wean the frontends off this macro.

[Bug middle-end/46314] frontends use ASM_GENERATE_INTERNAL_LABEL

[amylaar at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46314

--- Comment #1 from Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> 2010-11-06 15:04:58 UTC ---
Author: amylaar
Date: Sat Nov  6 15:04:52 2010
New Revision: 166404

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166404
Log:
    PR middle-end/46314
gcc:
    * target.def (generate_internal_label): New asm_out hook.
    * output.h (default_generate_internal_label): Declare.
    * varasm.c (default_generate_internal_label): Define.
gcc/cp:
    * method.c (make_alias_for_thunk):
    Use targetm.asm_out.generate_internal_label.
gcc/java:
    * class.c: Include target.h.
    (make_local_function_alias):
    Use targetm.asm_out.generate_internal_label.
    * expr.c (lookup_label, generate_name): Likewise.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/method.c
    trunk/gcc/java/ChangeLog
    trunk/gcc/java/class.c
    trunk/gcc/java/expr.c
    trunk/gcc/output.h
    trunk/gcc/target.def
    trunk/gcc/varasm.c

[Bug middle-end/46314] frontends use ASM_GENERATE_INTERNAL_LABEL

[amylaar at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46314

Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> 2010-11-06 15:13:34 UTC ---
Patch has been applied to trunk.