[Bug debug/46338] New: -fcompare-debug failure (length) with -O -fprofile-generate

[Bug debug/46338] New: -fcompare-debug failure (length) with -O -fprofile-generate

[zsojka at seznam dot cz]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46338

           Summary: -fcompare-debug failure (length) with -O
                    -fprofile-generate
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: debug
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: zsojka@seznam.cz
                CC: aoliva@gcc.gnu.org
              Host: x86_64-pc-linux-gnu
            Target: x86_64-pc-linux-gnu


Created attachment 22303
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22303
preprocessed source

Compiler output:
$ gcc -O -fprofile-generate -fcompare-debug testcase.C -w
gcc: error: testcase.C: -fcompare-debug failure (length)

The original source fails with r165699, but the reduced one doesn't... I don't
know if this is a regression or not.

[Bug debug/46338] -fcompare-debug failure (length) with -O -fprofile-generate

[zsojka at seznam dot cz]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46338

--- Comment #1 from Zdenek Sojka <zsojka at seznam dot cz> 2010-11-07 02:15:43 UTC ---
Created attachment 22304
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22304
auto-reduced testcase

This testcase doen't fail with r165699, but the original one does fail.

[Bug debug/46338] -fcompare-debug failure (length) with -O -fprofile-generate

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46338

Alexandre Oliva <aoliva at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2010.11.18 11:22:02
         AssignedTo|unassigned at gcc dot       |aoliva at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

--- Comment #2 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2010-11-18 11:22:02 UTC ---
Mine

[Bug debug/46338] -fcompare-debug failure (length) with -O -fprofile-generate

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46338

--- Comment #3 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2010-11-18 11:23:50 UTC ---
Created attachment 22441
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22441
Patch that fixes the problem

Here's the patch I'm testing.

[Bug debug/46338] -fcompare-debug failure (length) with -O -fprofile-generate

[zsojka at seznam dot cz]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46338

--- Comment #4 from Zdenek Sojka <zsojka at seznam dot cz> 2010-11-18 20:05:39 UTC ---
Created attachment 22449
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22449
more reduced testcase

$ gcc -O -fprofile-generate -fcompare-debug testcase.C            
gcc: error: testcase.C: -fcompare-debug failure (length)

Fails in r166899

[Bug debug/46338] -fcompare-debug failure (length) with -O -fprofile-generate

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46338

--- Comment #5 from Richard Guenther <rguenth at gcc dot gnu.org> 2010-11-26 09:50:02 UTC ---
Author: rguenth
Date: Fri Nov 26 09:49:47 2010
New Revision: 167171

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=167171
Log:
2010-11-26  Richard Guenther  <rguenther@suse.de>

    PR tree-optimization/46528
    PR debug/46338
    * profile.c (branch_prob): Do not split blocks based on locations
    from debug statements.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/profile.c

[Bug debug/46338] -fcompare-debug failure (length) with -O -fprofile-generate

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46338

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Richard Guenther <rguenth at gcc dot gnu.org> 2010-11-26 09:52:17 UTC ---
Fixed.

[Bug debug/46338] -fcompare-debug failure (length) with -O -fprofile-generate

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46338

--- Comment #7 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2010-11-29 19:18:27 UTC ---
Author: aoliva
Date: Mon Nov 29 19:18:24 2010
New Revision: 167263

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=167263
Log:
PR debug/46338
* g++.dg/debug/pr46338.C: New.

Added:
    trunk/gcc/testsuite/g++.dg/debug/pr46338.C
Modified:
    trunk/gcc/testsuite/ChangeLog

[Bug debug/46338] -fcompare-debug failure (length) with -O -fprofile-generate

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46338

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> 2010-12-06 19:30:39 UTC ---
Author: jakub
Date: Mon Dec  6 19:30:31 2010
New Revision: 167515

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=167515
Log:
    PR tree-optimization/46528
    PR debug/46338
    * profile.c (branch_prob): Make sure last is never set to a debug
    stmt.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/profile.c