[Bug tree-optimization/46349] New: [4.6 regression] incorrect scalarization

[Bug tree-optimization/46349] New: [4.6 regression] incorrect scalarization

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46349

           Summary: [4.6 regression] incorrect scalarization
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: ebotcazou@gcc.gnu.org


The fix for PR tree-opt/44972 has introduced regressions in Ada, specifically:

    (sra_modify_assign): Removed ref_expr_for_all_replacements_p checks,
    checks for return values of build_ref_for_offset.

sra_modify_assign now builds addresses of non-byte-aligned references, leading
to the expected ICE later in the RTL expander:

eric@atlantis:~/build/gcc/native32> gcc/xgcc -Bgcc -S opt9.adb -gnatws -O
+===========================GNAT BUG DETECTED==============================+
| 4.6.0 20101105 (experimental) [trunk revision 166350] (i586-suse-linux-gnu)
GCC error:|
| in expand_expr_addr_expr_1, at expr.c:7009                               |
| Error detected around opt9.adb:17:7                   

The non-byte-aligned reference is a bitfield with aggregate type.  I think that
the checks of the return values should be reinstated somehow or other.

The testcase is suitable for addition to the gnat.dg testsuite.

[Bug tree-optimization/46349] [4.6 regression] incorrect scalarization

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46349

--- Comment #2 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2010-11-07 19:46:51 UTC ---
Created attachment 22311
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22311
Testcase, file #2

[Bug tree-optimization/46349] [4.6 regression] incorrect scalarization

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46349

--- Comment #1 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2010-11-07 19:45:50 UTC ---
Created attachment 22310
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22310
Testcase, file #1

[Bug tree-optimization/46349] [4.6 regression] incorrect scalarization

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46349

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.6.0

[Bug tree-optimization/46349] [4.6 regression] incorrect scalarization

[jamborm at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46349

Martin Jambor <jamborm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jamborm at gcc dot gnu.org
         AssignedTo|unassigned at gcc dot       |jamborm at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #3 from Martin Jambor <jamborm at gcc dot gnu.org> 2010-11-09 14:33:25 UTC ---
Mine.

[Bug tree-optimization/46349] [4.6 regression] incorrect scalarization

[jamborm at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46349

--- Comment #4 from Martin Jambor <jamborm at gcc dot gnu.org> 2010-11-10 12:24:05 UTC ---
Patch posted to the mailing list:

http://gcc.gnu.org/ml/gcc-patches/2010-11/msg01013.html

[Bug tree-optimization/46349] [4.6 regression] incorrect scalarization

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46349

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug tree-optimization/46349] [4.6 regression] incorrect scalarization

[jamborm at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46349

--- Comment #5 from Martin Jambor <jamborm at gcc dot gnu.org> 2010-11-15 16:32:23 UTC ---
Author: jamborm
Date: Mon Nov 15 16:32:18 2010
New Revision: 166759

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166759
Log:
2010-11-15  Martin Jambor  <mjambor@suse.cz>

    PR tree-optimization/46349
    * tree-sra.c (contains_bitfld_comp_ref_p): New function.
    (contains_vce_or_bfcref_p): Likewise.
    (sra_modify_assign): Use them.

    * testsuite/gnat.dg/opt9.adb: New file.
    * testsuite/gnat.dg/opt9_pkg.ads: Likewise


Added:
    trunk/gcc/testsuite/gnat.dg/opt9.adb
    trunk/gcc/testsuite/gnat.dg/opt9_pkg.ads
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-sra.c

[Bug tree-optimization/46349] [4.6 regression] incorrect scalarization

[jamborm at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46349

Martin Jambor <jamborm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Martin Jambor <jamborm at gcc dot gnu.org> 2010-11-15 16:36:52 UTC ---
Fixed.