[Bug tree-optimization/46351] New: [4.6 regression] incorrect scalarization (2)

[Bug tree-optimization/46351] New: [4.6 regression] incorrect scalarization (2)

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46351

           Summary: [4.6 regression] incorrect scalarization (2)
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: ebotcazou@gcc.gnu.org


The fix for PR tree-opt/44972 has introduced regressions in Ada, specifically:

    (sra_modify_assign): Removed ref_expr_for_all_replacements_p checks,
    checks for return values of build_ref_for_offset.

This is a second example, which ICEs in tree-sra.c directly because of an
offset not multiple of a byte:

eric@atlantis:~/build/gcc/native> gcc/xgcc -Bgcc -S opt10.adb -O2
+===========================GNAT BUG DETECTED==============================+
| 4.6.0 20101106 (experimental) [trunk revision 166404] (x86_64-suse-linux-gnu)
GCC error:|
| in build_ref_for_offset, at tree-sra.c:1345                              |
| Error detected around opt10.adb:6:1        

This is again a bitfield with aggregate type.  I think that the checks of the
return values should be reinstated somehow or other.

The testcase is suitable for addition to the gnat.dg testsuite.

[Bug tree-optimization/46351] [4.6 regression] incorrect scalarization (2)

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46351

--- Comment #1 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2010-11-07 20:38:11 UTC ---
Created attachment 22312
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22312
opt10.adb

[Bug tree-optimization/46351] [4.6 regression] incorrect scalarization (2)

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46351

--- Comment #2 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2010-11-07 20:38:43 UTC ---
Created attachment 22313
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22313
opt10_pkg.ads

[Bug tree-optimization/46351] [4.6 regression] incorrect scalarization (2)

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46351

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jamborm at gcc dot gnu.org
   Target Milestone|---                         |4.6.0

[Bug tree-optimization/46351] [4.6 regression] incorrect scalarization (2)

[jamborm at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46351

Martin Jambor <jamborm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2010.11.08 19:44:09
         AssignedTo|unassigned at gcc dot       |jamborm at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

--- Comment #3 from Martin Jambor <jamborm at gcc dot gnu.org> 2010-11-08 19:44:09 UTC ---
Scary stuff.  I will look into it nevertheless.

[Bug tree-optimization/46351] [4.6 regression] incorrect scalarization (2)

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46351

--- Comment #4 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2010-11-09 08:23:18 UTC ---
> Scary stuff.  I will look into it nevertheless.

Thanks.  There are a couple of other similar cases in PR tree-opt/46349 and
tree-opt/46377, although the latter is probably a duplicate of this one.

[Bug tree-optimization/46351] [4.6 regression] incorrect scalarization (2)

[jamborm at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46351

--- Comment #5 from Martin Jambor <jamborm at gcc dot gnu.org> 2010-11-09 17:24:50 UTC ---
Patch submitted to the mailing list:

http://gcc.gnu.org/ml/gcc-patches/2010-11/msg00933.html

[Bug tree-optimization/46351] [4.6 regression] incorrect scalarization (2)

[jamborm at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46351

--- Comment #6 from Martin Jambor <jamborm at gcc dot gnu.org> 2010-11-10 12:52:32 UTC ---
Author: jamborm
Date: Wed Nov 10 12:52:27 2010
New Revision: 166535

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166535
Log:
2010-11-10  Martin Jambor  <mjambor@suse.cz>

    PR tree-optimization/46351
    PR tree-optimization/46377
    * tree-sra.c (type_internals_preclude_sra_p): Disqualify types with
    aggregate bit-fields.

    * testsuite/gnat.dg/opt10.adb: New file.
    * testsuite/gnat.dg/opt10_pkg.ads: Likewise.
    * testsuite/gnat.dg/opt11.adb: Likewise.
    * testsuite/gnat.dg/opt11.ads: Likewise.


Added:
    trunk/gcc/testsuite/gnat.dg/opt10.adb
    trunk/gcc/testsuite/gnat.dg/opt10_pkg.ads
    trunk/gcc/testsuite/gnat.dg/opt11.adb
    trunk/gcc/testsuite/gnat.dg/opt11.ads
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-sra.c

[Bug tree-optimization/46351] [4.6 regression] incorrect scalarization (2)

[jamborm at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46351

Martin Jambor <jamborm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Martin Jambor <jamborm at gcc dot gnu.org> 2010-11-10 12:53:27 UTC ---
Fixed.