[Bug middle-end/46360] New: [4.6 Regression] ICE in release_defs, at tree-ssanames.c:313

[Bug middle-end/46360] New: [4.6 Regression] ICE in release_defs, at tree-ssanames.c:313

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46360

           Summary: [4.6 Regression] ICE in release_defs, at
                    tree-ssanames.c:313
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: rguenth@gcc.gnu.org


Created attachment 22321
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22321
preprocessed source

The package ebook-tools fails to build with

/usr/bin/gcc  -Depub_EXPORTS -Wall -W -Wno-long-long -Wundef -Wcast-align
-Werror-implicit-function-declaration -Wchar-subscripts -Wpointer-arith
-Wwrite-strings -Wformat-security -Wmissing-format-attribute -Wshadow
-fno-common -fomit-frame-pointer -fmessage-length=0 -O2 -Wall
-D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables
-fasynchronous-unwind-tables -g  -fPIC
-I/usr/src/packages/BUILD/ebook-tools-0.2.0/src/libepub -I/usr/include/libxml2 
 -o CMakeFiles/epub.dir/epub.o   -c
/usr/src/packages/BUILD/ebook-tools-0.2.0/src/libepub/epub.c
/usr/src/packages/BUILD/ebook-tools-0.2.0/src/libepub/epub.c: In function
'epub_open':
/usr/src/packages/BUILD/ebook-tools-0.2.0/src/libepub/epub.c:19:3: internal
compiler error: in release_defs, at tree-ssanames.c:313
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://bugs.opensuse.org/> for instructions.

and the cause is -Wwrite-strings as the attached testcase shows

> ./cc1 -quiet ~/epub.i -m32 -Wwrite-strings 
/usr/src/packages/BUILD/ebook-tools-0.2.0/src/libepub/epub.c: In function
'epub_open':
/usr/src/packages/BUILD/ebook-tools-0.2.0/src/libepub/epub.c:19:15: internal
compiler error: in release_defs, at tree-ssanames.c:313
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

[Bug middle-end/46360] [4.6 Regression] ICE in release_defs, at tree-ssanames.c:313

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46360

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |i?86-*-*
   Target Milestone|---                         |4.6.0

[Bug middle-end/46360] [4.6 Regression] ICE in release_defs, at tree-ssanames.c:313

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46360

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2010.11.08 14:50:25
                 CC|                            |hubicka at gcc dot gnu.org
     Ever Confirmed|0                           |1

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> 2010-11-08 14:50:25 UTC ---
It is caused by revision 164438:

http://gcc.gnu.org/ml/gcc-cvs/2010-09/msg00734.html

[Bug middle-end/46360] [4.6 Regression] ICE in release_defs, at tree-ssanames.c:313

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46360

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jakub at gcc dot gnu.org
         AssignedTo|unassigned at gcc dot       |jakub at gcc dot gnu.org
                   |gnu.org                     |

[Bug middle-end/46360] [4.6 Regression] ICE in release_defs, at tree-ssanames.c:313

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46360

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> 2010-11-08 19:18:37 UTC ---
Reduced testcase (fails without any options, -Wwrite-strings is not needed):

__attribute__((gnu_inline, always_inline)) extern inline char *
strncpy (char *dest, const char *src, __SIZE_TYPE__ len)
{
  return __builtin_strncpy (dest, src, len);
}

void
foo (char *s)
{
  strncpy (s, "", 0);
}

The problem is the fold_stmt Honza added to gimplify_call_expr.  
Unfortunately fold_stmt doesn't expect it is being called when still not in SSA
form.  Seems
gimplify_and_update_call_from_tree
has been adjusted for that in PR45073, but
update_call_from_tree still needs doing that.  Will work on it tomorrow.

[Bug middle-end/46360] [4.6 Regression] ICE in release_defs, at tree-ssanames.c:313

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46360

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2010-11-08 19:57:07 UTC ---
Created attachment 22336
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22336
gcc46-pr46360.patch

Untested fix.

[Bug middle-end/46360] [4.6 Regression] ICE in release_defs, at tree-ssanames.c:313

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46360

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> 2010-11-09 11:54:39 UTC ---
Author: jakub
Date: Tue Nov  9 11:54:32 2010
New Revision: 166482

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166482
Log:
    PR middle-end/46360
    * tree-ssa-propagate.c (update_call_from_tree): Fix for use
    not in SSA mode.

    * gcc.c-torture/compile/pr46360.c: New test.

Added:
    trunk/gcc/testsuite/gcc.c-torture/compile/pr46360.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-ssa-propagate.c

[Bug middle-end/46360] [4.6 Regression] ICE in release_defs, at tree-ssanames.c:313

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46360

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> 2010-11-09 11:59:42 UTC ---
Fixed.