[Bug rtl-optimization/46366] New: gcc.target/i386/pr45352-2.c failed

[Bug rtl-optimization/46366] New: gcc.target/i386/pr45352-2.c failed

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46366

           Summary: gcc.target/i386/pr45352-2.c failed
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hjl.tools@gmail.com
                CC: abel@gcc.gnu.org


On Linux/x86-64, I got

FAIL: gcc.target/i386/pr45352-2.c (test for excess errors)

[Bug rtl-optimization/46366] gcc.target/i386/pr45352-2.c failed

[abel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46366

--- Comment #1 from Andrey Belevantsev <abel at gcc dot gnu.org> 2010-11-08 17:05:38 UTC ---
Sorry, I have checked that the test doesn't ICE but missed the additional
warnings.  How about the below patch, do you think it makes sense?  I have
verified that the test still ICEs without the PR45352 patch.

Index: gcc/testsuite/gcc.target/i386/pr45352-2.c
===================================================================
--- gcc/testsuite/gcc.target/i386/pr45352-2.c   (revision 166441)
+++ gcc/testsuite/gcc.target/i386/pr45352-2.c   (working copy)
@@ -55,7 +55,7 @@
     picture->f_motion.ref
       [0]
       [0]
-      = forward_reference_frame->base + (offset ? picture->pitches[0] : 0);
+      = (char) (long) (forward_reference_frame->base + (offset ?
picture->pitches[0] : 0));
   picture->f_motion.ref[0][1] = (offset);
   if (picture->picture_structure)
       picture->pitches[0] <<= picture->pitches[1] <<= 1;
@@ -90,7 +90,7 @@
 mpeg2_xvmc_slice
   (mpeg2dec_accel_t * accel, picture_t * picture, int code, uint8_t buffer,int
mba_inc)
 {
-  xine_xvmc_t * xvmc = bitstream_init (picture, buffer);
+  xine_xvmc_t * xvmc = (xine_xvmc_t *) (long) bitstream_init (picture, (void
*) (long) buffer);
   slice_xvmc_init (picture, code);
     while (1)
       {

[Bug rtl-optimization/46366] gcc.target/i386/pr45352-2.c failed

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46366

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> 2010-11-08 17:13:24 UTC ---
The testcase looks invalid to me:

static bitstream_init (picture_t * picture, void *start)
{
  picture->bitstream_ptr = start;
}
...
xine_xvmc_t * xvmc = bitstream_init (picture, buffer);

[Bug rtl-optimization/46366] gcc.target/i386/pr45352-2.c failed

[abel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46366

--- Comment #3 from Andrey Belevantsev <abel at gcc dot gnu.org> 2010-11-15 11:10:56 UTC ---
It is no problem to make this function return 0; and explicitly declare its
return type, I just need to check that the test case will still ICE without a
patch.

[Bug rtl-optimization/46366] gcc.target/i386/pr45352-2.c failed

[abel at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46366

--- Comment #4 from Andrey Belevantsev <abel at gcc dot gnu.org> 2010-11-16 14:11:47 UTC ---
Author: abel
Date: Tue Nov 16 14:11:39 2010
New Revision: 166798

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166798
Log:
        PR rtl-optimization/46366
        * gcc.target/i386/pr45352-2.c: Silence warnings by using appropriate
        casts.


Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.target/i386/pr45352-2.c

[Bug rtl-optimization/46366] gcc.target/i386/pr45352-2.c failed

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46366

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.6.0

--- Comment #5 from H.J. Lu <hjl.tools at gmail dot com> 2010-11-16 18:54:32 UTC ---
Fixed.