[Bug tree-optimization/46377] New: [4.6 regression] incorrect scalarization (3)

[Bug tree-optimization/46377] New: [4.6 regression] incorrect scalarization (3)

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46377

           Summary: [4.6 regression] incorrect scalarization (3)
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: ebotcazou@gcc.gnu.org


The fix for PR tree-opt/44972 has introduced regressions in Ada, specifically:

    (sra_modify_assign): Removed ref_expr_for_all_replacements_p checks,
    checks for return values of build_ref_for_offset.

This is a third example, potentially a duplicate of PR tree-opt/46351, but it
can be reproduced on 32-bit targets:

eric@atlantis:~/build/gcc/native32> gcc/xgcc -Bgcc -S -O opt11.adb
+===========================GNAT BUG DETECTED==============================+
| 4.6.0 20101105 (experimental) [trunk revision 166350] (i586-suse-linux-gnu)
GCC error:|
| in build_ref_for_offset, at tree-sra.c:1345                              |
| Error detected around opt11.adb:12:1       

The testcase is suitable for addition to the gnat.dg testsuite.

[Bug tree-optimization/46377] [4.6 regression] incorrect scalarization (3)

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46377

--- Comment #2 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2010-11-08 17:58:19 UTC ---
Created attachment 22333
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22333
opt11.ads

[Bug tree-optimization/46377] [4.6 regression] incorrect scalarization (3)

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46377

--- Comment #1 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2010-11-08 17:57:40 UTC ---
Created attachment 22332
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22332
opt11.adb

[Bug tree-optimization/46377] [4.6 regression] incorrect scalarization (3)

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46377

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.6.0

[Bug tree-optimization/46377] [4.6 regression] incorrect scalarization (3)

[jamborm at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46377

Martin Jambor <jamborm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot       |jamborm at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #3 from Martin Jambor <jamborm at gcc dot gnu.org> 2010-11-09 14:33:16 UTC ---
Also mine.

[Bug tree-optimization/46377] [4.6 regression] incorrect scalarization (3)

[jamborm at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46377

--- Comment #4 from Martin Jambor <jamborm at gcc dot gnu.org> 2010-11-09 17:25:04 UTC ---
Patch submitted to the mailing list:

http://gcc.gnu.org/ml/gcc-patches/2010-11/msg00933.html

[Bug tree-optimization/46377] [4.6 regression] incorrect scalarization (3)

[jamborm at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46377

--- Comment #5 from Martin Jambor <jamborm at gcc dot gnu.org> 2010-11-10 12:52:32 UTC ---
Author: jamborm
Date: Wed Nov 10 12:52:27 2010
New Revision: 166535

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166535
Log:
2010-11-10  Martin Jambor  <mjambor@suse.cz>

    PR tree-optimization/46351
    PR tree-optimization/46377
    * tree-sra.c (type_internals_preclude_sra_p): Disqualify types with
    aggregate bit-fields.

    * testsuite/gnat.dg/opt10.adb: New file.
    * testsuite/gnat.dg/opt10_pkg.ads: Likewise.
    * testsuite/gnat.dg/opt11.adb: Likewise.
    * testsuite/gnat.dg/opt11.ads: Likewise.


Added:
    trunk/gcc/testsuite/gnat.dg/opt10.adb
    trunk/gcc/testsuite/gnat.dg/opt10_pkg.ads
    trunk/gcc/testsuite/gnat.dg/opt11.adb
    trunk/gcc/testsuite/gnat.dg/opt11.ads
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-sra.c

[Bug tree-optimization/46377] [4.6 regression] incorrect scalarization (3)

[jamborm at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46377

Martin Jambor <jamborm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Martin Jambor <jamborm at gcc dot gnu.org> 2010-11-10 12:53:41 UTC ---
Fixed.