[Bug rtl-optimization/46395] New: [4.6 regression] FAIL: 22_locale/numpunct/members/pod/2.cc execution test

[Bug rtl-optimization/46395] New: [4.6 regression] FAIL: 22_locale/numpunct/members/pod/2.cc execution test

[schwab@linux-m68k.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46395

           Summary: [4.6 regression] FAIL:
                    22_locale/numpunct/members/pod/2.cc execution test
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P3
         Component: rtl-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: schwab@linux-m68k.org
                CC: rth@gcc.gnu.org
            Target: m68k-*-*


Created attachment 22345
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22345
Preprocessed testcase

The patch for rtl-opt/33721 causes wrong code to be generated during postreload
for 22_locale/numpunct/members/pod/2.cc.  The relevant difference is this:

@@ -4010,15 +4015,14 @@ _Z6test01v:
     jsr _ZNSt6locale7classicEv
 .LEHE49:
     move.l %a0,-(%sp)
-    move.l %fp,%d4
-    subq.l #6,%d4
-    move.l %d4,-(%sp)
+    moveq #-46,%d4
+    pea (%fp,%d4.l)
     .cfi_escape 0x2e,0x8
     jsr _ZNSt6localeC1ERKS_
-    addq.l #4,%sp
-    move.l %d4,(%sp)
+    addq.l #8,%sp
+    pea (%fp,%d4.l)
     pea 44(%a2)
-    lea (-10,%fp),%a5
+    lea (-42,%fp),%a5
     move.l %a5,%a1
     lea
_ZNSt9basic_iosIN9__gnu_cxx9characterItj11__mbstate_tEESt11char_traitsIS3_EE5imbueERKSt6locale,%a4
     lea _ZNSt6localeD1Ev,%a3

This changes the value of %d4, but there are other uses of %d4 that still
assume that it is the address of the variable loc.

    lea _ZNSt6localeD1Ev,%a3
...
.L628:
    move.l %d4,-(%sp)
    .cfi_escape 0x2e,0x4
    jsr (%a3)
    addq.l #4,%sp
...
.LEHB55:
    .cfi_escape 0x2e,0x4
    jsr _Znwj
    clr.l 4(%a0)
    move.l
#_ZTVSt7num_putIN9__gnu_cxx9characterItj11__mbstate_tEESt19ostreambuf_iteratorIS3_St11char_traitsIS3_EEE+8,(%a0)
    move.l %a0,(%sp)
    move.l %d4,-(%sp)
    moveq #-38,%d6
    add.l %fp,%d6
    move.l %d6,-(%sp)
    .cfi_escape 0x2e,0xc
    jsr
_ZNSt6localeC1ISt7num_putIN9__gnu_cxx9characterItj11__mbstate_tEESt19ostreambuf_iteratorIS5_St11char_traitsIS5_EEEEERKS_PT_

[Bug rtl-optimization/46395] [4.6 regression] FAIL: 22_locale/numpunct/members/pod/2.cc execution test

[schwab@linux-m68k.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46395

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unknown                     |4.6.0
   Target Milestone|---                         |4.6.0

[Bug rtl-optimization/46395] [4.6 regression] FAIL: 22_locale/numpunct/members/pod/2.cc execution test

[schwab@linux-m68k.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46395

--- Comment #1 from Andreas Schwab <schwab@linux-m68k.org> 2010-11-14 21:11:14 UTC ---
That appears to be a bug in postreload in that it does not take exceptions into
account.  The change in rtl-opt/33721 just modifies the order how automatic
variables are allocated and triggers a match in
reload_combine_recognize_pattern.

[Bug rtl-optimization/46395] [4.6 regression] FAIL: 22_locale/numpunct/members/pod/2.cc execution test

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46395

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4

[Bug rtl-optimization/46395] [4.6 regression] FAIL: 22_locale/numpunct/members/pod/2.cc execution test

[schwab at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46395

--- Comment #2 from Andreas Schwab <schwab at gcc dot gnu.org> 2010-11-16 20:17:38 UTC ---
Author: schwab
Date: Tue Nov 16 20:17:31 2010
New Revision: 166820

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166820
Log:
PR rtl-optimization/46395
* gcc/postreload.c (reload_combine): Invalidate register use
information on all control flow insns.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/postreload.c

[Bug rtl-optimization/46395] [4.6 regression] FAIL: 22_locale/numpunct/members/pod/2.cc execution test

[schwab@linux-m68k.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46395

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Andreas Schwab <schwab@linux-m68k.org> 2010-11-16 20:19:11 UTC ---
Fixed.