From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-336412-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 24095 invoked by alias); 9 Nov 2010 17:09:36 -0000
Received: (qmail 24085 invoked by uid 22791); 9 Nov 2010 17:09:35 -0000
X-SWARE-Spam-Status: No, hits=-2.8 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO gcc.gnu.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 09 Nov 2010 17:09:31 +0000
From: "krebbel at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/46399] New: Missing type promotion for library call argument
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Keywords:
X-Bugzilla-Severity: major
X-Bugzilla-Who: krebbel at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields:
Message-ID: <bug-46399-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Date: Tue, 09 Nov 2010 17:09:00 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2010-11/txt/msg01145.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46399

           Summary: Missing type promotion for library call argument
           Product: gcc
           Version: 4.4.3
            Status: UNCONFIRMED
          Severity: major
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: krebbel@gcc.gnu.org


The following testcase produces an unexpected result when compiled with:
gcc -O3 t.c -ot

int
main ()
{
  volatile _Decimal32 b, c;
  volatile unsigned int ui;
  volatile long long sll;

  ui = 1;
  sll = 1LL;
  b = sll;
  c = ui;

  printf("b: %x\n", *(int*)&b);
  printf("c: %x\n", *(int*)&c);
}

./t:
b: 22500001
c: 3a95e225

The problem appears to be a missing type promotion when doing the conversion
from unsigned int to _Decimal32 in c = ui:

        stmg    %r14,%r15,112(%r15)
        aghi    %r15,-184
        lhi     %r1,1
        st      %r1,180(%r15)
        lghi    %r1,1
        stg     %r1,160(%r15)
        lg      %r2,160(%r15)           <-- load a 64bit value into r2
        brasl   %r14,__dpd_floatdisd
        ste     %f0,172(%r15)
        l       %r2,180(%r15)           <-- load a 32bit value into r2
        brasl   %r14,__dpd_floatunssisd     without zero extending to 64bit
        ....

When I manually kill the upper 32 bits of r2 before doing the second lib call
it works fine:

        stmg    %r14,%r15,112(%r15)
        aghi    %r15,-184
        .cfi_offset 15, -40
        .cfi_offset 14, -48
        .cfi_def_cfa_offset 344
        lhi     %r1,1
        st      %r1,180(%r15)
        lghi    %r1,1
        stg     %r1,160(%r15)
        lg      %r2,160(%r15)
        brasl   %r14,__dpd_floatdisd
        ste     %f0,172(%r15)
        lghi    %r2,0                    <-- load a 64bit 0 into r2
        l       %r2,180(%r15)
        brasl   %r14,__dpd_floatunssisd
        ...

The result then is:
b: 22500001
c: 22500001


The testcase above is extracted from gcc.dg/dfp/pr41049.c which currently seems
to fail due to that problem on s390*.