public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/46432] New: v850-elf --enable-werror-always build fails
@ 2010-11-11 12:22 amylaar at gcc dot gnu.org
  2010-11-11 21:37 ` [Bug target/46432] " amylaar at gcc dot gnu.org
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: amylaar at gcc dot gnu.org @ 2010-11-11 12:22 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46432

           Summary: v850-elf --enable-werror-always build fails
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Keywords: build
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: amylaar@gcc.gnu.org
            Blocks: 44756
            Target: v850-elf


../../../gcc/gcc/final.c: In function ‘profile_function’:
../../../gcc/gcc/final.c:1627:45: error: suggest braces around empty body in an
‘if’ statement [-Werror=empty-body]
../../../gcc/gcc/final.c:1629:46: error: suggest braces around empty body in an
‘if’ statement [-Werror=empty-body]
../../../gcc/gcc/final.c:1636:45: error: suggest braces around empty body in an
‘if’ statement [-Werror=empty-body]
../../../gcc/gcc/final.c:1638:44: error: suggest braces around empty body in an
‘if’ statement [-Werror=empty-body]


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug target/46432] v850-elf --enable-werror-always build fails
  2010-11-11 12:22 [Bug target/46432] New: v850-elf --enable-werror-always build fails amylaar at gcc dot gnu.org
@ 2010-11-11 21:37 ` amylaar at gcc dot gnu.org
  2010-11-12 12:18 ` amylaar at gcc dot gnu.org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: amylaar at gcc dot gnu.org @ 2010-11-11 21:37 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46432

Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nickc at redhat dot com

--- Comment #1 from Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> 2010-11-11 21:37:12 UTC ---
Does profiling actually work on the v850?
It seems strange that v850.h defines ASM_OUTPUT_REG_PUSH / ASM_OUTPUT_REG_POP
as empty - I'd expect the profiled program to suffer from
clobbered registers.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug target/46432] v850-elf --enable-werror-always build fails
  2010-11-11 12:22 [Bug target/46432] New: v850-elf --enable-werror-always build fails amylaar at gcc dot gnu.org
  2010-11-11 21:37 ` [Bug target/46432] " amylaar at gcc dot gnu.org
@ 2010-11-12 12:18 ` amylaar at gcc dot gnu.org
  2010-11-15 13:16 ` nickc at redhat dot com
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: amylaar at gcc dot gnu.org @ 2010-11-12 12:18 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46432

--- Comment #2 from Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> 2010-11-12 12:10:44 UTC ---
FWIW, following the GNU coding standard advice on 'swallowing the semicolon'
avoids the warning:

Index: config/v850/v850.h
===================================================================
--- config/v850/v850.h  (revision 166609)
+++ config/v850/v850.h  (working copy)
@@ -888,8 +888,8 @@ #define ADDITIONAL_REGISTER_NAMES       
   { "r30",     30 },                           \
   { "lp",      LP_REGNUM} }

-#define ASM_OUTPUT_REG_PUSH(FILE,REGNO)
-#define ASM_OUTPUT_REG_POP(FILE,REGNO)
+#define ASM_OUTPUT_REG_PUSH(FILE,REGNO) do {} while (0)
+#define ASM_OUTPUT_REG_POP(FILE,REGNO) do {} while (0)

 /* This is how to output an element of a case-vector that is absolute.  */


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug target/46432] v850-elf --enable-werror-always build fails
  2010-11-11 12:22 [Bug target/46432] New: v850-elf --enable-werror-always build fails amylaar at gcc dot gnu.org
  2010-11-11 21:37 ` [Bug target/46432] " amylaar at gcc dot gnu.org
  2010-11-12 12:18 ` amylaar at gcc dot gnu.org
@ 2010-11-15 13:16 ` nickc at redhat dot com
  2010-11-15 14:08 ` amylaar at gcc dot gnu.org
  2010-11-15 14:14 ` amylaar at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: nickc at redhat dot com @ 2010-11-15 13:16 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46432

--- Comment #3 from Nick Clifton <nickc at redhat dot com> 2010-11-15 12:37:35 UTC ---
Hi Joern,

> FWIW, following the GNU coding standard advice on 'swallowing the semicolon'
> avoids the warning:

I think that it would be better to just delete the definitions.  They 
are bogus; the v850 does not currently support profiling, so it will be 
cleaner to just remove them.  At patch that does this is pre-approved.

Cheers
   Nick


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug target/46432] v850-elf --enable-werror-always build fails
  2010-11-11 12:22 [Bug target/46432] New: v850-elf --enable-werror-always build fails amylaar at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2010-11-15 13:16 ` nickc at redhat dot com
@ 2010-11-15 14:08 ` amylaar at gcc dot gnu.org
  2010-11-15 14:14 ` amylaar at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: amylaar at gcc dot gnu.org @ 2010-11-15 14:08 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46432

Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> 2010-11-15 14:04:23 UTC ---
Patch has been applied to trunk.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug target/46432] v850-elf --enable-werror-always build fails
  2010-11-11 12:22 [Bug target/46432] New: v850-elf --enable-werror-always build fails amylaar at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2010-11-15 14:08 ` amylaar at gcc dot gnu.org
@ 2010-11-15 14:14 ` amylaar at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: amylaar at gcc dot gnu.org @ 2010-11-15 14:14 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46432

--- Comment #4 from Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> 2010-11-15 14:03:36 UTC ---
Author: amylaar
Date: Mon Nov 15 14:03:31 2010
New Revision: 166754

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166754
Log:
        PR target/46432
        * config/v850/v850.h (ASM_OUTPUT_REG_PUSH, ASM_OUTPUT_REG_POP): Delete.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/v850/v850.h


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2010-11-15 14:08 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-11 12:22 [Bug target/46432] New: v850-elf --enable-werror-always build fails amylaar at gcc dot gnu.org
2010-11-11 21:37 ` [Bug target/46432] " amylaar at gcc dot gnu.org
2010-11-12 12:18 ` amylaar at gcc dot gnu.org
2010-11-15 13:16 ` nickc at redhat dot com
2010-11-15 14:08 ` amylaar at gcc dot gnu.org
2010-11-15 14:14 ` amylaar at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).