[Bug tree-optimization/46469] New: [4.6 Regression] ICE: verify_cgraph_node failed: inline clone is needed at -O

[Bug tree-optimization/46469] New: [4.6 Regression] ICE: verify_cgraph_node failed: inline clone is needed at -O

[zsojka at seznam dot cz]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46469

           Summary: [4.6 Regression] ICE: verify_cgraph_node failed:
                    inline clone is needed at -O
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: zsojka@seznam.cz
              Host: x86_64-pc-linux-gnu
            Target: x86_64-pc-linux-gnu


Created attachment 22387
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22387
reduced testcase

Compiler output:
$ gcc -O pr46469.C 
pr46469.C: In function 'int identifierByPthreadHandle()':
pr46469.C:12:19: error: inline clone is needed
int pthread_equal()/0(0) @0x7ff98720b000 (asm: pthread_equal) (inline copy in
int identifierByPthreadHandle()/2) availability:available analyzed 2 time, 13
benefit 3 size, 5 benefit needed reachable body finalized always_inline
  called by: int identifierByPthreadHandle()/2 (1.00 per call) (inlined) 
  calls: 
  References: 
  Refering this function: 
pr46469.C:12:19: internal compiler error: verify_cgraph_node failed
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

Backtrace:
(gdb) bt
#0  error (gmsgid=0x12f7fa0 "inline clone is needed") at
/mnt/svn/gcc-trunk/gcc/diagnostic.c:747
#1  0x0000000000c11e6c in verify_cgraph_node (node=0x7ffff5d1c000) at
/mnt/svn/gcc-trunk/gcc/cgraphunit.c:485
#2  0x0000000000c48ca5 in expand_call_inline (fn=0x7ffff5d0d300) at
/mnt/svn/gcc-trunk/gcc/tree-inline.c:3831
#3  gimple_expand_calls_inline (fn=0x7ffff5d0d300) at
/mnt/svn/gcc-trunk/gcc/tree-inline.c:4081
#4  optimize_inline_calls (fn=0x7ffff5d0d300) at
/mnt/svn/gcc-trunk/gcc/tree-inline.c:4232
#5  0x0000000000c1ef07 in cgraph_early_inlining () at
/mnt/svn/gcc-trunk/gcc/ipa-inline.c:1831
#6  0x000000000090723f in execute_one_pass (pass=0x177c880) at
/mnt/svn/gcc-trunk/gcc/passes.c:1560
#7  0x0000000000907505 in execute_pass_list (pass=0x177c880) at
/mnt/svn/gcc-trunk/gcc/passes.c:1615
#8  0x000000000090672c in do_per_function_toporder (callback=0x9074f0
<execute_pass_list>, data=0x1779c00)
    at /mnt/svn/gcc-trunk/gcc/passes.c:1153
#9  0x00000000009079b6 in execute_ipa_pass_list (pass=0x1779d20) at
/mnt/svn/gcc-trunk/gcc/passes.c:1932
#10 0x0000000000c154c8 in ipa_passes () at
/mnt/svn/gcc-trunk/gcc/cgraphunit.c:1694
#11 cgraph_optimize () at /mnt/svn/gcc-trunk/gcc/cgraphunit.c:1763
#12 0x0000000000c1568a in cgraph_finalize_compilation_unit () at
/mnt/svn/gcc-trunk/gcc/cgraphunit.c:1015
#13 0x0000000000585c1d in cp_write_global_declarations () at
/mnt/svn/gcc-trunk/gcc/cp/decl2.c:3973
#14 0x00000000009f3e86 in compile_file (argc=3, argv=0x7fffffffdf28) at
/mnt/svn/gcc-trunk/gcc/toplev.c:885
#15 do_compile (argc=3, argv=0x7fffffffdf28) at
/mnt/svn/gcc-trunk/gcc/toplev.c:2313
#16 toplev_main (argc=3, argv=0x7fffffffdf28) at
/mnt/svn/gcc-trunk/gcc/toplev.c:2374
#17 0x00007ffff6579bbd in __libc_start_main () from /lib/libc.so.6
#18 0x00000000004cadf5 in _start ()

Tested revisions:
r166703 - crash
r165699 - OK
4.5 r166509 - OK

[Bug tree-optimization/46469] [4.6 Regression] ICE: verify_cgraph_node failed: inline clone is needed at -O

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46469

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2010.11.13 23:29:17
                 CC|                            |hubicka at gcc dot gnu.org
   Target Milestone|---                         |4.6.0
     Ever Confirmed|0                           |1

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> 2010-11-13 23:29:17 UTC ---
It is caused by revision 165972:

http://gcc.gnu.org/ml/gcc-cvs/2010-10/msg01159.html

[Bug tree-optimization/46469] [4.6 Regression] ICE: verify_cgraph_node failed: inline clone is needed at -O

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46469

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-checking
           Priority|P3                          |P1

[Bug tree-optimization/46469] [4.6 Regression] ICE: verify_cgraph_node failed: inline clone is needed at -O

[dcb314 at hotmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46469

dcb <dcb314 at hotmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcb314 at hotmail dot com

--- Comment #2 from dcb <dcb314 at hotmail dot com> 2011-01-03 15:26:01 UTC ---
(In reply to comment #1)
> It is caused by revision 165972:
> 
> http://gcc.gnu.org/ml/gcc-cvs/2010-10/msg01159.html

This still seems to be broken in the 20110101 4.6 snapshot.

I've found about a dozen duplicates in the Fedora rawhide source
code tree, so it looks pretty important to me.

[Bug tree-optimization/46469] [4.6 Regression] ICE: verify_cgraph_node failed: inline clone is needed at -O

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46469

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |hubicka at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #3 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-01-07 21:11:39 UTC ---
Seems like inliner only needs to drop needed flag when making extern inline
function to disappear.

[Bug tree-optimization/46469] [4.6 Regression] ICE: verify_cgraph_node failed: inline clone is needed at -O

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46469

--- Comment #4 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-01-07 21:18:16 UTC ---
I think we also should drop needed flags on extern symbols once cgraph is fully
built.

[Bug tree-optimization/46469] [4.6 Regression] ICE: verify_cgraph_node failed: inline clone is needed at -O

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46469

--- Comment #5 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-01-08 16:34:03 UTC ---
Author: hubicka
Date: Sat Jan  8 16:33:57 2011
New Revision: 168598

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=168598
Log:
    PR tree-optmization/46469
    * ipa.c (function_and_variable_visibility): Clear needed flags on
    nodes with external decls; handle weakrefs merging correctly.

    * g++.dg/torture/pr46469.C: New testcase.

Added:
    trunk/gcc/testsuite/g++.dg/torture/pr46469.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa.c
    trunk/gcc/testsuite/ChangeLog

[Bug tree-optimization/46469] [4.6 Regression] ICE: verify_cgraph_node failed: inline clone is needed at -O

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46469

--- Comment #6 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-01-08 16:37:20 UTC ---
Fixed.

[Bug tree-optimization/46469] [4.6 Regression] ICE: verify_cgraph_node failed: inline clone is needed at -O

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46469

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-01-11 13:21:56 UTC ---
bah, really fixed ;)