public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/46476] Missing Warning about unreachable code after return [-Wunreachable-code-return] Date: Fri, 26 Nov 2021 10:04:22 +0000 [thread overview] Message-ID: <bug-46476-4-Hpz6YINNLS@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-46476-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=46476 --- Comment #25 from Richard Biener <rguenth at gcc dot gnu.org> --- Created attachment 51878 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51878&action=edit -Wunreachable-code-return at GIMPLE lowering time This is an alternative change only implementing -Wunreachable-code-return (-Wunreachable-code-throw should be doable within this framework as well). It does so during GIMPLE lowering where we still have return stmts using the can_fallthru logic already present. The approach has the same issues with premature optimization by the C++ frontend eliding if (0) and if (1) as shown during bootstrap so the relevant hunk is included here, too, likewise the double return in main(). It also warns for void baz(); void foo (int b) { if (b) __builtin_abort (); else return; baz (); } but not for void baz(); void foo (int b) { if (b) return; else __builtin_abort (); baz (); } as the previous stmt here is not the return but the abort() but in both cases baz () is not really "after return" but after an if, but that part of the IL structure is not easily visible. For the same reason implementing -Wunreachable-code-break as supported by clang is difficult (break is just a goto in GIMPLE). At least this patch passes bootstrap and would have found one real issue but not the problematic dead "looping" stmts.
next prev parent reply other threads:[~2021-11-26 10:04 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-11-14 17:13 [Bug c++/46476] New: Missing Warning about unreachable code after return paolo.carlini at oracle dot com 2010-11-14 17:44 ` [Bug c++/46476] " rguenth at gcc dot gnu.org 2012-05-12 14:05 ` manu at gcc dot gnu.org 2014-02-25 9:10 ` stefan at schweter dot it 2021-10-26 12:48 ` [Bug c++/46476] Missing Warning about unreachable code after return [-Wunreachable-code-return] rguenth at gcc dot gnu.org 2021-11-24 15:23 ` rguenth at gcc dot gnu.org 2021-11-25 12:06 ` tschwinge at gcc dot gnu.org 2021-11-26 8:45 ` rguenth at gcc dot gnu.org 2021-11-26 8:45 ` rguenth at gcc dot gnu.org 2021-11-26 8:47 ` rguenth at gcc dot gnu.org 2021-11-26 8:50 ` rguenth at gcc dot gnu.org 2021-11-26 9:48 ` tschwinge at gcc dot gnu.org 2021-11-26 10:04 ` rguenth at gcc dot gnu.org [this message] 2021-11-26 10:13 ` rguenth at gcc dot gnu.org 2021-11-26 12:05 ` rguenth at gcc dot gnu.org 2021-11-29 7:21 ` rguenth at gcc dot gnu.org 2021-11-29 13:30 ` rguenth at gcc dot gnu.org 2021-11-29 14:29 ` rguenth at gcc dot gnu.org 2022-07-27 16:58 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-46476-4-Hpz6YINNLS@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).