public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "joseph at codesourcery dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug other/46489] tree optimizer and frontend files use target macros
Date: Mon, 20 Dec 2010 17:42:00 -0000	[thread overview]
Message-ID: <bug-46489-4-7LXUtuWrFy@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-46489-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46489

--- Comment #6 from joseph at codesourcery dot com <joseph at codesourcery dot com> 2010-12-20 17:42:46 UTC ---
On Mon, 20 Dec 2010, amylaar at gcc dot gnu.org wrote:

> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46489
> 
> --- Comment #5 from Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> 2010-12-20 17:04:39 UTC ---
> (In reply to comment #4)
> 
> > This sounds like a nice approach for making sure it is safe to remove a 
> > tm.h include from a particular source file - if combined with generating a 
> > list of every target (every triplet with significant differences in how 
> > config.gcc / libgcc/config.host configure it, whether in the set of 
> > headers or the set of tm_defines) so you can run tests automatically for 
> > all targets -
> 
> I fear our configure system is turing complete, and thus such a list is
> not computable.

One configuration for each case in config.gcc, at least, so that you cover 
every header that might go in tm_file (and every object in c_target_objs 
etc.).  The effects of different macro values (such as the computation of 
FBSD_MAJOR from the target triplet for *-*-freebsd*) are less important.

> But by testing at least one configuration per target architecture, we
> already get a useful test coverage.
> I can also make a script to search for every macro that is documented with
> @defmac, so the remaining uncertainty would be for undocumented macros
> that only appear in specific configuration variants.

You could also check for every #define (note that some may have whitespace 
after the #) in config/*.h config/*/*.h.


  parent reply	other threads:[~2010-12-20 17:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-15 19:53 [Bug other/46489] New: " amylaar at gcc dot gnu.org
2010-11-16  5:21 ` [Bug other/46489] " amylaar at gcc dot gnu.org
2010-12-18 20:56 ` amylaar at gcc dot gnu.org
2010-12-20 13:59 ` amylaar at gcc dot gnu.org
2010-12-20 15:43 ` joseph at codesourcery dot com
2010-12-20 17:04 ` amylaar at gcc dot gnu.org
2010-12-20 17:42 ` joseph at codesourcery dot com [this message]
2011-04-05 15:43 ` jsm28 at gcc dot gnu.org
2012-01-24  0:54 ` pinskia at gcc dot gnu.org
2020-04-02 19:49 ` xerofoify at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-46489-4-7LXUtuWrFy@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).