public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "amonakov at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug rtl-optimization/46649] [4.6 Regression] ICE: in move_bb_info, at sel-sched-ir.c:5080 with -fschedule-insns -fselective-scheduling Date: Tue, 14 Dec 2010 14:39:00 -0000 [thread overview] Message-ID: <bug-46649-4-UwP4VMEJ6J@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-46649-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46649 --- Comment #7 from Alexander Monakov <amonakov at gcc dot gnu.org> 2010-12-14 14:38:38 UTC --- After a discussion with Andrey and refreshing my memory on that code I think it's actually better to unbreak purge_empty_blocks in this case. It used to be correct, i.e. it never attempted to delete the first BB in the region; then I broke it because I wasn't aware of the limitation w.r.t. removal of the first BB. Sorry for the spam. diff --git a/gcc/sel-sched-ir.c b/gcc/sel-sched-ir.c index 427fd22..9f0c4a3 100644 --- a/gcc/sel-sched-ir.c +++ b/gcc/sel-sched-ir.c @@ -3749,10 +3749,10 @@ tidy_control_flow (basic_block xbb, bool full_tidying) void purge_empty_blocks (void) { - /* Do not attempt to delete preheader. */ - int i = sel_is_loop_preheader_p (BASIC_BLOCK (BB_TO_BLOCK (0))) ? 1 : 0; + int i; - while (i < current_nr_blocks) + /* Do not attempt to delete the first basic block in the region. */ + for (i = 1; i < current_nr_blocks; i++) { basic_block b = BASIC_BLOCK (BB_TO_BLOCK (i));
next prev parent reply other threads:[~2010-12-14 14:39 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-11-25 1:48 [Bug rtl-optimization/46649] New: " zsojka at seznam dot cz 2010-11-25 6:27 ` [Bug rtl-optimization/46649] " hjl.tools at gmail dot com 2010-11-25 8:05 ` ebotcazou at gcc dot gnu.org 2010-11-25 10:01 ` amonakov at gcc dot gnu.org 2010-11-25 19:34 ` zsojka at seznam dot cz 2010-11-25 22:37 ` amonakov at gcc dot gnu.org 2010-12-14 13:28 ` amonakov at gcc dot gnu.org 2010-12-14 14:39 ` amonakov at gcc dot gnu.org [this message] 2010-12-15 13:09 ` amonakov at gcc dot gnu.org 2010-12-15 13:09 ` amonakov at gcc dot gnu.org 2011-04-07 7:01 ` abel at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-46649-4-UwP4VMEJ6J@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).