[Bug libffi/46661] New: 32-bit cls_pointer.c, cls_pointer_stack.c FAIL on IRIX 6.5

[Bug libffi/46661] New: 32-bit cls_pointer.c, cls_pointer_stack.c FAIL on IRIX 6.5

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46661

           Summary: 32-bit cls_pointer.c, cls_pointer_stack.c FAIL on IRIX
                    6.5
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libffi
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: ro@gcc.gnu.org
                CC: green@redhat.com, andreast@gcc.gnu.org
              Host: mips-sgi-irix6.5
            Target: mips-sgi-irix6.5
             Build: mips-sgi-irix6.5


For the 32-bit N32 ABI, cls_pointer.c and cls_pointer_stack.c fail on IRIX 6.5:

FAIL: libffi.call/cls_pointer.c -O0 -W -Wall (test for excess errors)
Excess errors:
/vol/gcc/src/hg/trunk/irix/libffi/testsuite/libffi.call/cls_pointer.c: In
function 'main':
/vol/gcc/src/hg/trunk/irix/libffi/testsuite/libffi.call/cls_pointer.c:68:8:
warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

FAIL: libffi.call/cls_pointer_stack.c -O0 -W -Wall (test for excess errors)
Excess errors:
/vol/gcc/src/hg/trunk/irix/libffi/testsuite/libffi.call/cls_pointer_stack.c: In
function 'main':
/vol/gcc/src/hg/trunk/irix/libffi/testsuite/libffi.call/cls_pointer_stack.c:132:8:
warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

In both cases, a void * is casted to ffi_arg, which in the N32 case is

#  ifdef FFI_MIPS_O32
/* O32 stack frames have 32bit integer args */
typedef unsigned int     ffi_arg __attribute__((__mode__(__SI__)));
typedef signed   int     ffi_sarg __attribute__((__mode__(__SI__)));
#else
/* N32 and N64 frames have 64bit integer args */
typedef unsigned int     ffi_arg __attribute__((__mode__(__DI__)));
typedef signed   int     ffi_sarg __attribute__((__mode__(__DI__)));
#  endif

(cf. src/mips/ffitarget.h), i.e. a 64-bit type.

I'm not sure what the best way is to portably fix this.

[Bug libffi/46661] 32-bit cls_pointer.c, cls_pointer_stack.c FAIL on IRIX 6.5

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46661

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2011-02/msg00531.htm
                   |                            |l
   Last reconfirmed|                            |2011.02.08 11:36:42
         AssignedTo|unassigned at gcc dot       |ro at gcc dot gnu.org
                   |gnu.org                     |
   Target Milestone|---                         |4.6.0
     Ever Confirmed|0                           |1

--- Comment #1 from Rainer Orth <ro at gcc dot gnu.org> 2011-02-08 11:36:42 UTC ---
Mine, patch posted.

[Bug libffi/46661] 32-bit cls_pointer.c, cls_pointer_stack.c FAIL on IRIX 6.5

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46661

--- Comment #2 from Rainer Orth <ro at gcc dot gnu.org> 2011-02-09 10:01:11 UTC ---
Author: ro
Date: Wed Feb  9 10:01:07 2011
New Revision: 169963

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=169963
Log:
    PR libffi/46661
    * testsuite/libffi.call/cls_pointer.c (main): Cast void * to
    uintptr_t first.
    * testsuite/libffi.call/cls_pointer_stack.c (main): Likewise.

Modified:
    trunk/libffi/ChangeLog
    trunk/libffi/testsuite/libffi.call/cls_pointer.c
    trunk/libffi/testsuite/libffi.call/cls_pointer_stack.c

[Bug libffi/46661] 32-bit cls_pointer.c, cls_pointer_stack.c FAIL on IRIX 6.5

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46661

--- Comment #3 from Rainer Orth <ro at gcc dot gnu.org> 2011-02-09 14:40:18 UTC ---
Author: ro
Date: Wed Feb  9 14:40:15 2011
New Revision: 169972

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=169972
Log:
    PR libffi/46661
    * testsuite/libffi.call/cls_pointer.c (main): Cast void * to
    uintptr_t first.
    * testsuite/libffi.call/cls_pointer_stack.c (main): Likewise.

Modified:
    branches/gcc-4_5-branch/libffi/ChangeLog
    branches/gcc-4_5-branch/libffi/testsuite/libffi.call/cls_pointer.c
    branches/gcc-4_5-branch/libffi/testsuite/libffi.call/cls_pointer_stack.c

[Bug libffi/46661] 32-bit cls_pointer.c, cls_pointer_stack.c FAIL on IRIX 6.5

[ro at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46661

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Rainer Orth <ro at gcc dot gnu.org> 2011-02-09 14:43:02 UTC ---
Fixed for 4.5.3, 4.6.0.