[Bug rtl-optimization/46665] New: two gfortran tests fail with -O[2s] -fipa-pta -fno-tree-ccp -fno-tree-forwprop

[Bug rtl-optimization/46665] New: two gfortran tests fail with -O[2s] -fipa-pta -fno-tree-ccp -fno-tree-forwprop

[zsojka at seznam dot cz]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46665

           Summary: two gfortran tests fail with -O[2s] -fipa-pta
                    -fno-tree-ccp -fno-tree-forwprop
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: zsojka@seznam.cz
              Host: x86_64-pc-linux-gnu
            Target: x86_64-pc-linux-gnu


The failing tests are:
gfortran.dg/array_alloc_3.f90
gfortran.dg/char_reshape_1.f90

In both cases, the flags are:
-O[2s] -fipa-pta -fno-tree-ccp -fno-tree-forwprop
or
-O1 -fipa-pta -fschedule-insns -fstrict-overflow -fno-tree-ccp
-fno-tree-forwprop

, while array_alloc_3.f90 fails further with:

Output:
$ gfortran char_reshape_1.f90 -O2 -fipa-pta -fno-tree-ccp -fno-tree-forwprop -g
&& valgrind -q ./a.out
==5108== Conditional jump or move depends on uninitialised value(s)
==5108==    at 0x400C0D: MAIN__ (char_reshape_1.f90:24)
==5108==    by 0x400DA2: main (char_reshape_1.f90:17)
==5108== 
Aborted

$ gfortran char_reshape_1.f90 -O1 -fipa-pta -fschedule-insns -fstrict-overflow
-fno-tree-ccp -fno-tree-forwprop -g && valgrind -q ./a.out
==8736== Conditional jump or move depends on uninitialised value(s)
==8736==    at 0x400C14: MAIN__ (char_reshape_1.f90:24)
==8736==    by 0x400E69: main (char_reshape_1.f90:17)
==8736== 
Aborted

$ gfortran array_alloc_3.f90 -O2 -fipa-pta -fno-tree-ccp -fno-tree-forwprop -g
&& valgrind -q ./a.out
==7327== Conditional jump or move depends on uninitialised value(s)
==7327==    at 0x400A4E: main (array_alloc_3.f90:12)
==7327== 
Aborted

$ gfortran array_alloc_3.f90 -O1 -fipa-pta -fschedule-insns -fstrict-overflow
-fno-tree-ccp -fno-tree-forwprop -g && valgrind -q ./a.out
==9570== Conditional jump or move depends on uninitialised value(s)
==9570==    at 0x400A43: main (array_alloc_3.f90:12)
==9570== 
Aborted

Tested revisions:
r167147 - fail
r165699 - fail
r161659 - OK

[Bug rtl-optimization/46665] two gfortran tests fail with -O[2s] -fipa-pta -fno-tree-ccp -fno-tree-forwprop

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46665

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2010.11.25 22:37:29
                 CC|                            |rguenth at gcc dot gnu.org
   Target Milestone|---                         |4.6.0
     Ever Confirmed|0                           |1

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> 2010-11-25 22:37:29 UTC ---
It is caused by revision 161840:

http://gcc.gnu.org/ml/gcc-cvs/2010-07/msg00194.html

[Bug rtl-optimization/46665] two gfortran tests fail with -O[2s] -fipa-pta -fno-tree-ccp -fno-tree-forwprop

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46665

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |rguenth at gcc dot gnu.org
                   |gnu.org                     |
   Target Milestone|4.6.0                       |---

--- Comment #2 from Richard Guenther <rguenth at gcc dot gnu.org> 2010-11-26 10:32:10 UTC ---
Mine.

[Bug rtl-optimization/46665] two gfortran tests fail with -O[2s] -fipa-pta -fno-tree-ccp -fno-tree-forwprop

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46665

--- Comment #3 from Richard Guenther <rguenth at gcc dot gnu.org> 2010-11-26 12:19:54 UTC ---
The -O[2s] -fipa-pta -fno-tree-ccp -fno-tree-forwprop failure goes away
with -fno-schedule-insns2.

restrict support really depends on CCP and CSE, -fipa-pta doesn't
recompute it after CSE.  But there isn't anything obviously wrong
in the .optimized alias info.

Fails with -fdbg-cnt=sched_insn:218, ok with -fdbg-cnt=sched_insn:217

--- array_alloc_3.s.good        2010-11-26 13:04:58.000000000 +0100
+++ array_alloc_3.s.bad 2010-11-26 13:04:48.000000000 +0100
@@ -151,6 +151,7 @@
        .p2align 4,,10
        .p2align 3
 .L11:
+       movq    (%rcx), %rdx
        movq    $1, 144(%rsp)
        movq    %rbp, 152(%rsp)
        movq    $1, 168(%rsp)
@@ -159,7 +160,6 @@
        movq    $1, 192(%rsp)
        movq    %r11, 200(%rsp)
        movq    %r10, 184(%rsp)
-       movq    (%rcx), %rdx
        subq    -8(%rcx), %rdx
        addq    $1, %rdx
        cmovs   %r9, %rdx

which is

(insn 264 263 267 15 (set (mem/s:DI (plus:DI (reg/f:DI 7 sp)
                (const_int 184 [0xb8])) [5 parm.16.dim[2].stride+0 S8 A64])
        (reg:DI 39 r10 [orig:227 D.1900 ] [227]))
/space/rguenther/src/svn/trunk/gcc/testsuite/gfortran.dg/array_alloc_3.f90:12
62 {*movdi_internal_rex64}
     (nil))

(and similar accesses to parm.16) vs.

(insn:TI 267 264 268 15 (set (reg:DI 1 dx [323])
        (mem:DI (reg:DI 2 cx [orig:251 ivtmp.92 ] [251]) [3 MEM[(struct
array3_integer(kind=4) *)D.2016_21]+0 S8 A64]))
/space/rguenther/src/svn/trunk/gcc/testsuite/gfortran.dg/array_alloc_3.f90:12
62 {*movdi_internal_rex64}
     (nil))

  # PT = { parm.16ptD.1610ptD.1610 }
  D.2016_21 = (void *) ivtmp.92_128;

I found the bug and have a patch.

[Bug rtl-optimization/46665] two gfortran tests fail with -O[2s] -fipa-pta -fno-tree-ccp -fno-tree-forwprop

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46665

--- Comment #4 from Richard Guenther <rguenth at gcc dot gnu.org> 2010-11-26 14:04:55 UTC ---
Author: rguenth
Date: Fri Nov 26 14:04:50 2010
New Revision: 167176

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=167176
Log:
2010-11-26  Richard Guenther  <rguenther@suse.de>

    PR tree-optimization/46665
    * tree-ssa-structalias.c (pt_solution_set_var): Use DECL_PT_UID.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-ssa-structalias.c

[Bug rtl-optimization/46665] two gfortran tests fail with -O[2s] -fipa-pta -fno-tree-ccp -fno-tree-forwprop

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46665

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.6.0

--- Comment #5 from Richard Guenther <rguenth at gcc dot gnu.org> 2010-11-26 14:05:53 UTC ---
Fixed.

[Bug rtl-optimization/46665] two gfortran tests fail with -O[2s] -fipa-pta -fno-tree-ccp -fno-tree-forwprop

[hjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46665

--- Comment #6 from hjl at gcc dot gnu.org <hjl at gcc dot gnu.org> 2010-11-26 15:14:27 UTC ---
Author: hjl
Date: Fri Nov 26 15:14:20 2010
New Revision: 167179

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=167179
Log:
Add a testcase for PR tree-optimization/46665.

2010-11-26  H.J. Lu  <hongjiu.lu@intel.com>

    PR tree-optimization/46665
    * gfortran.dg/pr46665.f90: New.

Added:
    trunk/gcc/testsuite/gfortran.dg/pr46665.f90
Modified:
    trunk/gcc/testsuite/ChangeLog