[Bug libfortran/46720] New: [4.6 Regression] missing quadmath_weak.h with --enable-maintainer-mode

[Bug libfortran/46720] New: [4.6 Regression] missing quadmath_weak.h with --enable-maintainer-mode

[tkoenig at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46720

           Summary: [4.6 Regression] missing quadmath_weak.h with
                    --enable-maintainer-mode
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Keywords: build
          Severity: normal
          Priority: P3
         Component: libfortran
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: tkoenig@gcc.gnu.org


Bootstrapping trunk as of 2010-11-29 failed with

In file included from ../../../../trunk/libgfortran/fmain.c:4:0:
../../../../trunk/libgfortran/libgfortran.h:52:29: schwerwiegender
Fehler: quadmath_weak.h: Datei oder Verzeichnis nicht gefunden

when configured with

../trunk/configure --enable-maintainer-mode --prefix=$HOME
--enable-languages=c,fortran --with-mpc=/usr/local/

The bootstrap worked all right without --enable-maintainer-mode.

See http://gcc.gnu.org/ml/fortran/2010-11/msg00401.html

[Bug libfortran/46720] [4.6 Regression] missing quadmath_weak.h with --enable-maintainer-mode

[tkoenig at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46720

Thomas Koenig <tkoenig at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |4.5.1
   Target Milestone|---                         |4.6.0
      Known to fail|                            |4.6.0

[Bug libfortran/46720] [4.6 Regression] missing quadmath_weak.h with --enable-maintainer-mode

[tkoenig at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46720

Thomas Koenig <tkoenig at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

--- Comment #1 from Thomas Koenig <tkoenig at gcc dot gnu.org> 2010-12-02 10:24:07 UTC ---
The issue seems to be fixed after upgrading to automake 1.11.1
from 1.11, so I am ready to resolve this as invalid.

However, two points:

- The build process complains about the automake 1.11, but this warning
  scrolls past really fast, and if automake 1.11 really causes issues,
  this should be addressed.

- The timestamps on the generated files should be set so that no
  unneeded regeneration takes place.  How do you do that in svn?

Any ideas on either point?

[Bug libfortran/46720] [4.6 Regression] missing quadmath_weak.h with --enable-maintainer-mode

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46720

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu.org
           Severity|enhancement                 |normal

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> 2010-12-02 10:33:00 UTC ---
(In reply to comment #1)
> The issue seems to be fixed after upgrading to automake 1.11.1
> from 1.11, so I am ready to resolve this as invalid.

1.11.1 is the correct version according to
http://gcc.gnu.org/install/prerequisites.html ("GCC requires the latest release
in the 1.11 series, which is currently 1.11.1.")

> However, two points:
> - The build process complains about the automake 1.11, but this warning
>   scrolls past really fast, and if automake 1.11 really causes issues,
>   this should be addressed.

No idea about that one. Except: "When regenerating a directory to a newer
version, please update all the directories using an older 1.11 to the latest
released version."

> - The timestamps on the generated files should be set so that no
>   unneeded regeneration takes place.

No idea. Except using ./contrib/gcc_update, which touches the and the
"configure/*.in" files if it thinks that it is needed. (Causing that autoreconf
is not run because the touched "configure" files is "newer" than the modified
"configure.ac" file.)

 * * *

Some older comments - written before comment 1 was available.

libgfortran/acinclude.m4 contains:

  if test -f ../libquadmath/libquadmath.la; then
    [...];
    LIBQUADINCLUDE='- I$(srcdir)/../libquadmath'
  else
    [...]
    LIBQUADINCLUDE=

Thus, the .h file can only be found if ../libquadmath/libquadmath.la is found
or when the .h file is for other reasons in the include path.

There might be also a race condition in building libgfortran and libquadmath;
however, I think (TM) that the following line of Makefile.def should take care
of it:

dependencies = { module=configure-target-libgfortran;
                 on=all-target-libquadmath; };

Given that many have bootstrapped successfully with and without
--enable-maintainer-mode, I assume either a race condition or that there is
something peculiar on the specific system, which triggers this bug.

[Bug libfortran/46720] [4.6 Regression] missing quadmath_weak.h with --enable-maintainer-mode

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46720

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2010.12.07 10:10:41
     Ever Confirmed|0                           |1

--- Comment #3 from Tobias Burnus <burnus at gcc dot gnu.org> 2010-12-07 10:10:41 UTC ---
Mark as WAITING

[Bug libfortran/46720] [4.6 Regression] missing quadmath_weak.h with --enable-maintainer-mode

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46720

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> 2010-12-09 13:16:19 UTC ---
    if test -f ../libquadmath/libquadmath.la; then
      LIBQUADLIB=../libquadmath/libquadmath.la
      LIBQUADLIB_DEP=../libquadmath/libquadmath.la
      LIBQUADINCLUDE='-I$(srcdir)/../libquadmath'
    else
      LIBQUADLIB="-lquadmath"
      LIBQUADLIB_DEP=
      LIBQUADINCLUDE= 
    fi   

Not sure why do we have this, when test "x$libgfor_cv_have_float128" = xyes
then I'd say libquadmath should have been built always.

The dependencies in toplevel:
dependencies = { module=configure-target-libgfortran;
on=all-target-libquadmath; };
and thus
configure-target-libgfortran: maybe-all-target-libquadmath
should take care of it.

Anyway, Thomas, have you ever been able to reproduce it again?

[Bug libfortran/46720] [4.6 Regression] missing quadmath_weak.h with --enable-maintainer-mode

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46720

--- Comment #5 from Tobias Burnus <burnus at gcc dot gnu.org> 2010-12-09 13:34:38 UTC ---
(In reply to comment #4)
>     if test -f ../libquadmath/libquadmath.la; then
[...]
>     else
>       LIBQUADLIB="-lquadmath"
>       LIBQUADLIB_DEP=
>       LIBQUADINCLUDE= 
>     fi   
> 
> Not sure why do we have this, when test "x$libgfor_cv_have_float128" = xyes
> then I'd say libquadmath should have been built always.

Well, that was proposed by Ralf to allow optionally use a system installed
libquadmath instead of the GCC build one.

(This requires the patch for PR 46540 which disables the build of libquadmath
(--disable-libquadmath) but which still builds gfortran/libgfortran with
quadmath support.)

[Bug libfortran/46720] [4.6 Regression] missing quadmath_weak.h with --enable-maintainer-mode

[rwild at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46720

Ralf Wildenhues <rwild at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rwild at gcc dot gnu.org

--- Comment #6 from Ralf Wildenhues <rwild at gcc dot gnu.org> 2010-12-13 17:17:08 UTC ---
Is this still an issue (with the correct Automake version installed)?  Thanks.

[Bug libfortran/46720] [4.6 Regression] missing quadmath_weak.h with --enable-maintainer-mode

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46720

--- Comment #7 from Tobias Burnus <burnus at gcc dot gnu.org> 2010-12-20 08:52:08 UTC ---
* PING *

Can you still reproduce it -- with the correct version of automake installed?

[Bug libfortran/46720] [4.6 Regression] missing quadmath_weak.h with --enable-maintainer-mode

[tkoenig at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46720

--- Comment #8 from Thomas Koenig <tkoenig at gcc dot gnu.org> 2010-12-23 09:41:08 UTC ---
(In reply to comment #7)
> * PING *
> 
> Can you still reproduce it -- with the correct version of automake installed?

With the correct automake, there is no error.

Close as INVALID?

[Bug libfortran/46720] [4.6 Regression] missing quadmath_weak.h with --enable-maintainer-mode

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46720

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |INVALID