public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "amonakov at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/46758] [4.5/4.6 Regression] -fgraphite-identity produces wrong code when using 64bit constants
Date: Fri, 03 Dec 2010 15:27:00 -0000	[thread overview]
Message-ID: <bug-46758-4-pufgQlm4Yg@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-46758-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46758

Alexander Monakov <amonakov at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2010.12.03 15:27:13
                 CC|                            |amonakov at gcc dot gnu.org
     Ever Confirmed|0                           |1

--- Comment #1 from Alexander Monakov <amonakov at gcc dot gnu.org> 2010-12-03 15:27:13 UTC ---
In this particular example, the problem is in scan_tree_for_params_int:

  int v = int_cst_value (cst);

  mpz_init (val);
  mpz_set_si (val, 0);

  /* Necessary to not get "-1 = 2^n - 1". */
  if (v < 0)
    mpz_sub_ui (val, val, -v);
  else
    mpz_add_ui (val, val, v);

(gdb) p cst
$8 = (tree) 0x7ffff5a4e848
(gdb) pt
 <integer_cst 0x7ffff5a4e848 type <integer_type 0x7ffff7ed0738 long long int>
constant -8589934593>
(gdb) p v
$9 = -1
(gdb) 

There are multiple places where graphite uses int_cst_value.  Note that the
problem may be more severe on 32-bit hosts as there the tree may hold a 64-bit
constant but mpz_*_{u,s}i accepts 'long's.


  parent reply	other threads:[~2010-12-03 15:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-02  1:11 [Bug middle-end/46758] New: " zsojka at seznam dot cz
2010-12-02  9:43 ` [Bug middle-end/46758] " rguenth at gcc dot gnu.org
2010-12-03 15:27 ` amonakov at gcc dot gnu.org [this message]
2010-12-05 11:57 ` rguenth at gcc dot gnu.org
2010-12-08 18:04 ` amonakov at gcc dot gnu.org
2010-12-13 17:25 ` amonakov at gcc dot gnu.org
2010-12-16 13:22 ` rguenth at gcc dot gnu.org
2010-12-23  0:19 ` spop at gcc dot gnu.org
2010-12-23 16:26 ` spop at gcc dot gnu.org
2010-12-23 16:35 ` spop at gcc dot gnu.org
2010-12-23 18:52 ` spop at gcc dot gnu.org
2010-12-23 18:54 ` spop at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-46758-4-pufgQlm4Yg@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).