From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-340513-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 15292 invoked by alias); 13 Dec 2010 20:31:15 -0000
Received: (qmail 15283 invoked by uid 22791); 13 Dec 2010 20:31:14 -0000
X-SWARE-Spam-Status: No, hits=-2.8 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO gcc.gnu.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 13 Dec 2010 20:31:09 +0000
From: "hjl.tools at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/46770] Replace .ctors/.dtors with .init_array/.fini_array on targets supporting them
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: hjl.tools at gmail dot com
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: hjl.tools at gmail dot com
X-Bugzilla-Target-Milestone: 4.6.0
X-Bugzilla-Changed-Fields:
Message-ID: <bug-46770-4-a1yluxFedT@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-46770-4@http.gcc.gnu.org/bugzilla/>
References: <bug-46770-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Date: Mon, 13 Dec 2010 20:31:00 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2010-12/txt/msg01496.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46770

--- Comment #51 from H.J. Lu <hjl.tools at gmail dot com> 2010-12-13 20:30:58 UTC ---
(In reply to comment #50)
> 
> If gcc switches from .ctors to .init_array, it needs to make sure to generate
> the constructors in forward order within the TU, rather than backwards order as
> it does in the .ctors section. I didn't see anything in HJ's patch that does
> that.
> 

It is handled in

static section *
get_elf_initfini_array_priority_section (int priority,
                     bool constructor_p)
{
  section *sec;
  if (priority != DEFAULT_INIT_PRIORITY)
    {
      char buf[18];
      sprintf (buf, "%s.%.5u", 
           constructor_p ? ".init_array" : ".fini_array",
           priority);
      sec = get_section (buf, SECTION_WRITE, NULL_TREE);
    }
  else
    sec = constructor_p ? init_array_section : fini_array_section;
  return sec;
}

It uses priority, instead of MAX_INIT_PRIORITY - priority, to generate
NNNN for .init_arry.NNNN.