[Bug fortran/46772] New: libquadmath: Build failure - strtod: static declaration of 'strtod' follows non-static declaration

[Bug fortran/46772] New: libquadmath: Build failure - strtod: static declaration of 'strtod' follows non-static declaration

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46772

           Summary: libquadmath: Build failure - strtod: static
                    declaration of 'strtod'  follows non-static
                    declaration
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Keywords: build
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: burnus@gcc.gnu.org


Created attachment 22608
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22608
Draft patch

On MinGW there is the following compiler error; cf. attachment.


/mingw/i586-pc-mingw32/sys-include -DHAVE_CONFIG_H -I. 
-I../../../gcc-trunk/libquadmath -g -O2 -MT gdtoa/dmisc.lo -MD -MP -MF 
gdtoa/.deps/dmisc.Tpo -c ../../../gcc-trunk/libquadmath/gdtoa/dmisc.c -o 
gdtoa/dmisc.o
In file included from ../../../gcc-trunk/libquadmath/gdtoa/gdtoaimp.h:186:0,
                 from ../../../gcc-trunk/libquadmath/gdtoa/dmisc.c:32:
c:/MinGW/include/stdlib.h:319:1: error: static declaration of 'strtod' 
follows non-static declaration
../../../gcc-trunk/libquadmath/gdtoa/gdtoa.h:112:15: note: previous 
declaration of 'strtod' was here

[Bug fortran/46772] libquadmath: Build failure - strtod: static declaration of 'strtod' follows non-static declaration

[ktietz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46772

Kai Tietz <ktietz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2010.12.03 12:38:27
                 CC|                            |ktietz at gcc dot gnu.org
     Ever Confirmed|0                           |1

--- Comment #1 from Kai Tietz <ktietz at gcc dot gnu.org> 2010-12-03 12:38:27 UTC ---
Fix looks reasonable to me.
That mingw.org defines this function static is more a bug on their side.

[Bug fortran/46772] libquadmath: Build failure - strtod: static declaration of 'strtod' follows non-static declaration

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46772

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> 2010-12-08 15:10:29 UTC ---
Patch: http://gcc.gnu.org/ml/gcc-patches/2010-12/msg00664.html

[Bug fortran/46772] libquadmath: Build failure - strtod: static declaration of 'strtod' follows non-static declaration

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46772

--- Comment #3 from Tobias Burnus <burnus at gcc dot gnu.org> 2010-12-08 22:35:56 UTC ---
Author: burnus
Date: Wed Dec  8 22:35:52 2010
New Revision: 167608

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=167608
Log:
2010-12-08  Tobias Burnus  <burnus@net-b.de>

        PR fortran/46772
        * gdtoa/gdtoa.h: Include stdlib.h instead of declare strtod.
        * gdtoa/gdtoaimp.h: Don't declare strtod.


Modified:
    trunk/libquadmath/ChangeLog
    trunk/libquadmath/gdtoa/gdtoa.h
    trunk/libquadmath/gdtoa/gdtoaimp.h

[Bug fortran/46772] libquadmath: Build failure - strtod: static declaration of 'strtod' follows non-static declaration

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46772

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Tobias Burnus <burnus at gcc dot gnu.org> 2010-12-08 22:43:16 UTC ---
FIXED for GCC / libquadmath.

The "static" issue of MinGW is tracked at
http://sourceforge.net/tracker/?func=detail&aid=3132404&group_id=2435&atid=102435