[Bug testsuite/46913] New: send_log "$first != $second\n" in gdb-test fails when $first starts with '-'

[Bug testsuite/46913] New: send_log "$first != $second\n" in gdb-test fails when $first starts with '-'

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46913

           Summary: send_log "$first != $second\n" in gdb-test fails when
                    $first starts with '-'
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: danglin@gcc.gnu.org
              Host: hppa-unknown-linux-gnu
            Target: hppa-unknown-linux-gnu
             Build: hppa-unknown-linux-gnu


Executing on host: /home/dave/gnu/gcc-4.6/objdir/gcc/xgcc
-B/home/dave/gnu/gcc-4
.6/objdir/gcc/ /home/dave/gnu/gcc/gcc/gcc/testsuite/gcc.dg/guality/nrv-1.c  
-O2
 -flto -flto-partition=none  -g -fno-tree-sra  -lm   -o ./nrv-1.exe    (timeout 
= 300)spawn /home/dave/gnu/gcc-4.6/objdir/gcc/xgcc
-B/home/dave/gnu/gcc-4.6/objdir/gcc
/ /home/dave/gnu/gcc/gcc/gcc/testsuite/gcc.dg/guality/nrv-1.c -O2 -flto
-flto-pa
rtition=none -g -fno-tree-sra -lm -o ./nrv-1.exe
PASS: gcc.dg/guality/nrv-1.c  -O2 -flto -flto-partition=none  (test for excess
e
rrors)
Setting LD_LIBRARY_PATH to
:/home/dave/gnu/gcc/objdir/gcc::/home/dave/gnu/gcc/ob
jdir/gcc:/home/dave/gnu/gcc/objdir/hppa-linux/libstdc++-v3/src/.libs:/home/dave/
gnu/gcc/objdir/hppa-linux/libmudflap/.libs:/home/dave/gnu/gcc/objdir/hppa-linux/
libssp/.libs:/home/dave/gnu/gcc/objdir/hppa-linux/libgomp/.libs:/home/dave/gnu/g
cc/objdir/./gcc:/home/dave/gnu/gcc/objdir/./prev-gcc
spawn [open ...]
PASS: gcc.dg/guality/nrv-1.c  -O2 -flto -flto-partition=none  execution test
Spawning: gdb -nx -nw -quiet -x nrv-1.gdb ./nrv-1.exe
spawn gdb -nx -nw -quiet -x nrv-1.gdb ./nrv-1.exe
Reading symbols from
/home/dave/gnu/gcc-4.6/objdir/gcc/testsuite/gcc/nrv-1.exe..
.done.
Breakpoint 1 at 0x10558: file
/home/dave/gnu/gcc/gcc/gcc/testsuite/gcc.dg/gualit
y/nrv-1.c, line 20.

Breakpoint 1, f ()
    at /home/dave/gnu/gcc/gcc/gcc/testsuite/gcc.dg/guality/nrv-1.c:20
20        a2.i[4] = 7;  /* { dg-final { gdb-test 20 "a2.i\[0\]" "42" } } */
$1 = -1093315243
$2 = 42
A debugging session is active.

        Inferior 1 [process 8290] will be killed.

Quit anyway? (y or n) [answered Y; input not from terminal]
ERROR OCCURED: usage: send [args] string
    while executing
"send_log "$first != $second\n""
    invoked from within
"expect {
-i exp7 -timeout 300 
        -re {[\n\r]\$1 = ([^\n\r]*)[\n\r]+\$2 = ([^\n\r]*)[\n\r]} {
            set first $expect_out(1,string)
            set second $expe..."
    ("uplevel" body line 1)
    invoked from within"uplevel $body" TCL LOOKUP INDEX flag {-1093315243 != 42
} usage: send [args] stringUNSUPPORTED: gcc.dg/guality/nrv-1.c  -O2 -flto
-flto-partition=none  line 20 a2.i[0] == 42

Note that this appears to also cause a test timeout ("UNSUPPORTD" output).

I think we need to use send_log -- "$first != $second\n" in the script.
See <http://sourceware.org/bugzilla/show_bug.cgi?id=9737>.

[Bug testsuite/46913] send_log "$first != $second\n" in gdb-test fails when $first starts with '-'

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46913

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> 2010-12-12 20:03:31 UTC ---
So post a patch to gcc-patches?

[Bug testsuite/46913] send_log "$first != $second\n" in gdb-test fails when $first starts with '-'

[dave at hiauly1 dot hia.nrc.ca]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46913

--- Comment #2 from dave at hiauly1 dot hia.nrc.ca 2010-12-12 20:10:51 UTC ---
> So post a patch to gcc-patches?

Will do when I complete testing on the system where I see the problem.
It currently doing a full check that I don't want to mess up.  There
is some expect/tcl version dependency.

Dave

[Bug testsuite/46913] send_log "$first != $second\n" in gdb-test fails when $first starts with '-'

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46913

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2010-12-12 20:18:59 UTC ---
If it doesn't work on some expect or tcl or dejagnu versions, the alternative
would be
send_log "actual $first != expected $second\n"

[Bug testsuite/46913] send_log "$first != $second\n" in gdb-test fails when $first starts with '-'

[dave at hiauly1 dot hia.nrc.ca]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46913

--- Comment #4 from dave at hiauly1 dot hia.nrc.ca 2010-12-12 21:14:37 UTC ---
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46913
> 
> --- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2010-12-12 20:18:59 UTC ---
> If it doesn't work on some expect or tcl or dejagnu versions, the alternative
> would be
> send_log "actual $first != expected $second\n"

Which do you prefer?  It's not easy to test multiple versions.  What
I know is the error only occurs with certain versions.

Dave

[Bug testsuite/46913] send_log "$first != $second\n" in gdb-test fails when $first starts with '-'

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46913

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> 2010-12-13 08:19:00 UTC ---
I guess the one with actual/expected is more portable/robust, and it really
doesn't matter that much what is printed into the log file, and actual/expected
make it even more explicit what the numbers mean.