From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-340593-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 14892 invoked by alias); 14 Dec 2010 13:18:48 -0000
Received: (qmail 14882 invoked by uid 22791); 14 Dec 2010 13:18:48 -0000
X-SWARE-Spam-Status: No, hits=-2.8 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO gcc.gnu.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Dec 2010 13:18:43 +0000
From: "hubicka at ucw dot cz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/46916] gcc.dg/torture/stackalign/non-local-goto-[1,2].c ICEs compiler due to r167727
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: hubicka at ucw dot cz
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields:
Message-ID: <bug-46916-4-KTluBuOR8H@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-46916-4@http.gcc.gnu.org/bugzilla/>
References: <bug-46916-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Date: Tue, 14 Dec 2010 13:18:00 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2010-12/txt/msg01576.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46916

--- Comment #19 from Jan Hubicka <hubicka at ucw dot cz> 2010-12-14 13:18:30 UTC ---
Hi,
does the following patch fix the problem?
darwin_text_section no longer needs to care about hot/cold code since this is
already done in darwin_function_section.

In fact you might additionally consider putting 
  return (DECL_WEAK (decl)
      ? darwin_sections[text_coal_section]
      : text_section);
into places returning NULL in darwin_function_section, removing case
SECCAT_TEXT
from machopic_select_section undefining USE_SELECT_SECTION_FOR_FUNCTIONS
as suggested by rth as cleanup.

Honza

Index: opts.c
===================================================================
--- opts.c    (revision 167794)
+++ opts.c    (working copy)
@@ -738,6 +738,9 @@ finish_options (struct gcc_options *opts
       opts->x_flag_reorder_blocks = 1;
     }

+  if (opts->x_flag_reorder_blocks_and_partition)
+    opts->x_flag_reorder_blocks = 1;
+
   /* If the target requested unwind info, then turn off the partitioning
      optimization with a different message.  Likewise, if the target does not
      support named sections.  */
Index: config/darwin.c
===================================================================
--- config/darwin.c    (revision 167794)
+++ config/darwin.c    (working copy)
@@ -1145,16 +1145,11 @@ darwin_mark_decl_preserved (const char *
 }

 static section *
-darwin_text_section (int reloc, int weak)
+darwin_text_section (int weak)
 {
-  if (reloc)
-    return (weak
-        ? darwin_sections[text_unlikely_coal_section]
-        : unlikely_text_section ());
-  else
-    return (weak
-        ? darwin_sections[text_coal_section]
-        : text_section);
+  return (weak
+      ? darwin_sections[text_coal_section]
+      : text_section);
 }

 static section *