public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "patrick.marlier at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/46941] [trans-mem] new/delete operator are unsafe
Date: Wed, 02 Feb 2011 14:17:00 -0000	[thread overview]
Message-ID: <bug-46941-4-nsAL64IuHo@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-46941-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46941

Patrick Marlier <patrick.marlier at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #7 from Patrick Marlier <patrick.marlier at gmail dot com> 2011-02-02 14:17:23 UTC ---
(In reply to comment #6)
> Fixed
> http://gcc.gnu.org/ml/gcc-patches/2011-01/msg00776.html

Please considered this...
http://gcc.gnu.org/ml/gcc-patches/2011-01/msg01206.html

It must be **transaction_safe** not transaction_pure.

Moreover I think we should also add ECF_MALLOC (malloc attribute) because
otherwise the allocated memory will not be considered as local.

Extract from trans-mem.c: thread_private_new_memory()
  if (stmt && is_gimple_call (stmt) && gimple_call_flags (stmt) & ECF_MALLOC)
    /* Thread-local or transaction-local.  */
    ;
  else
    retval = mem_non_local;

Thanks.


  parent reply	other threads:[~2011-02-02 14:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-14 15:40 [Bug c++/46941] New: " patrick.marlier at gmail dot com
2010-12-22 10:12 ` [Bug c++/46941] " patrick.marlier at gmail dot com
2010-12-22 13:51 ` aldyh at gcc dot gnu.org
2010-12-23 15:45 ` patrick.marlier at gmail dot com
2010-12-23 16:19 ` aldyh at gcc dot gnu.org
2010-12-23 16:28 ` patrick.marlier at gmail dot com
2011-01-12 19:43 ` aldyh at gcc dot gnu.org
2011-02-02 14:17 ` patrick.marlier at gmail dot com [this message]
2011-02-03 16:24 ` aldyh at gcc dot gnu.org
2011-02-03 16:41 ` aldyh at gcc dot gnu.org
2011-02-04 13:54 ` patrick.marlier at gmail dot com
2011-02-04 15:31 ` aldyh at gcc dot gnu.org
2011-02-04 18:40 ` aldyh at gcc dot gnu.org
2011-02-04 20:13 ` patrick.marlier at gmail dot com
2011-02-04 20:16 ` aldyh at gcc dot gnu.org
2011-02-04 20:30 ` patrick.marlier at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-46941-4-nsAL64IuHo@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).