[Bug testsuite/47013] New: FAIL: gcc.dg/sms-*.c scan-rtl-dump-times sms "SMS succeeded" *

[Bug testsuite/47013] New: FAIL: gcc.dg/sms-*.c scan-rtl-dump-times sms "SMS succeeded" *

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47013

           Summary: FAIL: gcc.dg/sms-*.c scan-rtl-dump-times sms "SMS
                    succeeded" *
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: dominiq@lps.ens.fr
                CC: eres@il.ibm.com
            Target: powerpc*-*-*


I believed that a PR has been opened for this failures, but I cannot find any.
Since over a year (see
http://gcc.gnu.org/ml/gcc-testresults/2009-12/msg02672.html to
http://gcc.gnu.org/ml/gcc-testresults/2010-12/msg01632.html ) The following
tests

FAIL: gcc.dg/sms-2.c scan-rtl-dump-times sms "SMS succeeded" 1
FAIL: gcc.dg/sms-4.c scan-rtl-dump-times sms "SMS succeeded" 1
FAIL: gcc.dg/sms-5.c scan-rtl-dump-times sms "SMS succeeded" 1
FAIL: gcc.dg/sms-6.c scan-rtl-dump-times sms "SMS succeeded" 3
FAIL: gcc.dg/sms-7.c scan-rtl-dump-times sms "SMS succeeded" 3
FAIL: gcc.dg/sms-8.c scan-rtl-dump-times sms "SMS succeeded" 1

fail on powerpc*-*-* for both -m32 and -m64. In addition on
powerpc-apple-darwin9

FAIL: gcc.dg/sms-3.c scan-rtl-dump-times sms "SMS succeeded" 1

also fails with -m32. The dumps for sms-2.c are

[karma] f90/bug% less sms-2.c.180r.sms 

;; Function fun (fun)

(note 1 0 4 NOTE_INSN_DELETED)

(note 4 1 3 2 [bb 2] NOTE_INSN_BASIC_BLOCK)

(note 3 4 0 2 NOTE_INSN_FUNCTION_BEG)


try_optimize_cfg iteration 1

;; 1 loops found
;;
;; Loop 0
;;  header 0, latch 1
;;  depth 0, outer -1
;;  nodes: 0 1 2
;; 2 succs { 1 }
Reordered sequence:
 2 compensation  [10000]
(note 1 0 4 NOTE_INSN_DELETED)

(note 4 1 3 2 [bb 2] NOTE_INSN_BASIC_BLOCK)

(note 3 4 0 2 NOTE_INSN_FUNCTION_BEG)
starting the processing of deferred insns
ending the processing of deferred insns

[karma] f90/bug% less sms-2.c.189r.sms

;; Function fun (fun)

(note 1 0 4 NOTE_INSN_DELETED)

(note 4 1 3 2 [bb 2] NOTE_INSN_BASIC_BLOCK)

(note 3 4 0 2 NOTE_INSN_FUNCTION_BEG)


try_optimize_cfg iteration 1

;; 1 loops found
;;
;; Loop 0
;;  header 0, latch 1
;;  depth 0, outer -1
;;  nodes: 0 1 2
;; 2 succs { 1 }
Reordered sequence:
 2 compensation  [10000]
(note 1 0 4 NOTE_INSN_DELETED)

(note 4 1 3 2 [bb 2] NOTE_INSN_BASIC_BLOCK)

(note 3 4 0 2 NOTE_INSN_FUNCTION_BEG)
starting the processing of deferred insns
ending the processing of deferred insns

[Bug testsuite/47013] FAIL: gcc.dg/sms-*.c scan-rtl-dump-times sms "SMS succeeded" *

[eres at il dot ibm.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47013

--- Comment #1 from revital eres <eres at il dot ibm.com> 2010-12-20 09:07:53 UTC ---
In some of the testcases additional flags are needed to make SMS apply: (though
it does not mean it succeeds)
sms-5.c: add -mno-update -fno-auto-inc-dec 
sms-4.c: -funsafe-loop-optimizations -fno-auto-inc-dec
(-funsafe-loop-optimizations is related to PR32283
http://gcc.gnu.org/ml/gcc/2010-07/msg00379.html)
sms-7.c: add -fno-auto-inc-dec

[Bug testsuite/47013] FAIL: gcc.dg/sms-*.c scan-rtl-dump-times sms "SMS succeeded" *

[eres at il dot ibm.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47013

--- Comment #2 from revital eres <eres at il dot ibm.com> 2010-12-20 09:26:21 UTC ---
The testcases fail (even when adding the flags mentioned before) due to the
decision to apply SMS when stage_count greater than 1.
If stage_count is 1 it means the new SMSed kernel includes instructions from a
single iteration of the original loop -- in that case SMS fails and leaves the
scheduling task to the scheduler. In r146278 SMS has been applied also when SC
equals 1 so the testcases passed with that version.

[Bug testsuite/47013] FAIL: gcc.dg/sms-*.c scan-rtl-dump-times sms "SMS succeeded" *

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47013

--- Comment #3 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2010-12-20 10:21:37 UTC ---
Thanks for looking at the problem. Do you understand why the tests pass on
*86*-*-* and not on powerpc*-*-*?

[Bug testsuite/47013] FAIL: gcc.dg/sms-*.c scan-rtl-dump-times sms "SMS succeeded" *

[eres at il dot ibm.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47013

--- Comment #4 from revital eres <eres at il dot ibm.com> 2010-12-20 10:55:40 UTC ---
(In reply to comment #3)
> Thanks for looking at the problem. Do you understand why the tests pass on
> *86*-*-* and not on powerpc*-*-*?

Yes, the dump file is checked only for powerpc*-*-* and spu-*-*:

/* { dg-final { scan-rtl-dump-times "SMS succeeded" 1 "sms"  { target
powerpc*-*-* spu-*-* } } } */

[Bug testsuite/47013] FAIL: gcc.dg/sms-*.c scan-rtl-dump-times sms "SMS succeeded" *

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47013

--- Comment #5 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2010-12-20 10:59:26 UTC ---
> Yes, the dump file is checked only for powerpc*-*-* and spu-*-*:
> 
> /* { dg-final { scan-rtl-dump-times "SMS succeeded" 1 "sms"  { target
> powerpc*-*-* spu-*-* } } } */

Indeed I have seen it, but obviously I did not registered the information;-)

[Bug testsuite/47013] FAIL: gcc.dg/sms-*.c scan-rtl-dump-times sms "SMS succeeded" *

[eres at il dot ibm.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47013

--- Comment #6 from revital eres <eres at il dot ibm.com> 2010-12-27 14:00:54 UTC ---
Looking more closely at sms-6.c it seems there is another issue which causes
SMS to FAIL in the loop in foo function:
Although the restrict keyword is attached to the pointers dependence edges are
created between the write and read. (Please see the SMS dump file)
The edges were not created in -r146278.
I used -O2 -fmodulo-sched -fdump-rtl-sms  -fno-auto-inc-dec -mno-update to
compile on PowerPC.

[Bug testsuite/47013] FAIL: gcc.dg/sms-*.c scan-rtl-dump-times sms "SMS succeeded" *

[eres at il dot ibm.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47013

--- Comment #7 from revital eres <eres at il dot ibm.com> 2010-12-27 14:06:43 UTC ---
Created attachment 22853
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22853
SMS dump created with -r168082 on powerpc.

[Bug testsuite/47013] FAIL: gcc.dg/sms-*.c scan-rtl-dump-times sms "SMS succeeded" *

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47013

--- Comment #8 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2011-06-05 19:05:00 UTC ---
Is there any reason (beside reviewing) for not having committed the patch in
http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01175.html ?

[Bug testsuite/47013] FAIL: gcc.dg/sms-*.c scan-rtl-dump-times sms "SMS succeeded" *

[revital.eres at linaro dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47013

revital.eres at linaro dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |revital.eres at linaro dot
                   |                            |org

--- Comment #9 from revital.eres at linaro dot org 2011-06-06 06:28:53 UTC ---
(In reply to comment #8)
> Is there any reason (beside reviewing) for not having committed the patch in
> http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01175.html ?

My recent patchs for SMS (i.e.,
http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01341.html), which are not
approved yet, require some adjustments for this testsuite patch. So that's why
I thought it will be better to wait for a approval for the new patches before
pinging for the testsuite patch, avoiding the need to submit a follow-up fix
for it. Also, currently trunk bootstrap is broken on ARM with SMS flags and I'm
trying to figure out the problem... so once I'll locate this problem I'll go
back to these patches and push them forward to trunk.

[Bug testsuite/47013] FAIL: gcc.dg/sms-*.c scan-rtl-dump-times sms "SMS succeeded" *

[iains at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47013

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011-11-22
                 CC|                            |iains at gcc dot gnu.org
     Ever Confirmed|0                           |1

--- Comment #10 from Iain Sandoe <iains at gcc dot gnu.org> 2011-11-22 14:37:23 UTC ---
any progress on resolving this .. or any more input needed?

[Bug testsuite/47013] FAIL: gcc.dg/sms-*.c scan-rtl-dump-times sms "SMS succeeded" *

[revital.eres at linaro dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47013

--- Comment #11 from revital.eres at linaro dot org 2011-11-23 18:59:34 UTC ---
(In reply to comment #10)
> any progress on resolving this .. or any more input needed?

I will revisit this. Thanks for the ping.

[Bug testsuite/47013] FAIL: gcc.dg/sms-*.c scan-rtl-dump-times sms "SMS succeeded" *

[revitale at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47013

--- Comment #12 from revitale at gcc dot gnu.org 2011-12-12 07:32:31 UTC ---
Author: revitale
Date: Mon Dec 12 07:32:25 2011
New Revision: 182219

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=182219
Log:
Fix PR testsuite/47013

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/sms-2.c
    trunk/gcc/testsuite/gcc.dg/sms-3.c
    trunk/gcc/testsuite/gcc.dg/sms-4.c
    trunk/gcc/testsuite/gcc.dg/sms-5.c
    trunk/gcc/testsuite/gcc.dg/sms-6.c
    trunk/gcc/testsuite/gcc.dg/sms-7.c
    trunk/gcc/testsuite/gcc.dg/sms-8.c
    trunk/gcc/testsuite/gcc.dg/sms-9.c

[Bug testsuite/47013] FAIL: gcc.dg/sms-*.c scan-rtl-dump-times sms "SMS succeeded" *

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47013

--- Comment #13 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2012-01-12 16:58:36 UTC ---
Closing as fixed.

[Bug testsuite/47013] FAIL: gcc.dg/sms-*.c scan-rtl-dump-times sms "SMS succeeded" *

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47013

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #14 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2012-01-12 17:02:20 UTC ---
Closing as fixed for real this time.