public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "janus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/47023] C_Sizeof: Rejects valid code
Date: Tue, 18 Oct 2011 12:18:00 -0000	[thread overview]
Message-ID: <bug-47023-4-weJN0Kq45i@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-47023-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47023

--- Comment #20 from janus at gcc dot gnu.org 2011-10-18 12:17:42 UTC ---
(In reply to comment #19)
> > >  * reject proc-pointers for SIZEOF (comment #7)

I think one could also allow them, but then the implementation of SIZEOF needs
to be fixed to give the size of the pointer.

Draft patch:


Index: gcc/fortran/trans-intrinsic.c
===================================================================
--- gcc/fortran/trans-intrinsic.c    (revision 180129)
+++ gcc/fortran/trans-intrinsic.c    (working copy)
@@ -5088,8 +5088,11 @@ gfc_conv_intrinsic_sizeof (gfc_se *se, gfc_expr *e

       gfc_conv_expr_reference (&argse, arg);

-      type = TREE_TYPE (build_fold_indirect_ref_loc (input_location,
-                         argse.expr));
+      if (arg->ts.type == BT_PROCEDURE)
+    type = TREE_TYPE (argse.expr);
+      else
+    type = TREE_TYPE (build_fold_indirect_ref_loc (input_location,
+                               argse.expr));

       /* Obtain the source word length.  */
       if (arg->ts.type == BT_CHARACTER)


With this the test case in comment #19 gives:

                    8
                    8
                    4

which is ok, apart from the fact that sizeof(proc) should be rejected.


  parent reply	other threads:[~2011-10-18 12:18 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-20  8:59 [Bug fortran/47023] New: " burnus at gcc dot gnu.org
2010-12-22 10:28 ` [Bug fortran/47023] " burnus at gcc dot gnu.org
2011-09-20 11:47 ` florian.rathgeber at gmail dot com
2011-09-20 15:36 ` [Bug fortran/47023] [4.6/4.7 regression] " kargl at gcc dot gnu.org
2011-09-20 15:40 ` kargl at gcc dot gnu.org
2011-09-20 16:49 ` dominiq at lps dot ens.fr
2011-09-29 13:12 ` burnus at gcc dot gnu.org
2011-09-29 13:20 ` rguenth at gcc dot gnu.org
2011-09-29 13:21 ` burnus at gcc dot gnu.org
2011-09-29 13:29 ` janus at gcc dot gnu.org
2011-09-29 15:52 ` burnus at gcc dot gnu.org
2011-10-16  8:44 ` janus at gcc dot gnu.org
2011-10-16 19:43 ` janus at gcc dot gnu.org
2011-10-17  9:47 ` janus at gcc dot gnu.org
2011-10-17 16:00 ` janus at gcc dot gnu.org
2011-10-17 16:16 ` [Bug fortran/47023] " janus at gcc dot gnu.org
2011-10-17 19:11 ` janus at gcc dot gnu.org
2011-10-17 19:23 ` janus at gcc dot gnu.org
2011-10-18 10:48 ` janus at gcc dot gnu.org
2011-10-18 11:07 ` janus at gcc dot gnu.org
2011-10-18 12:04 ` janus at gcc dot gnu.org
2011-10-18 12:18 ` janus at gcc dot gnu.org [this message]
2011-10-18 12:20 ` janus at gcc dot gnu.org
2011-10-18 12:48 ` burnus at gcc dot gnu.org
2011-10-18 13:46 ` janus at gcc dot gnu.org
2011-10-19 22:08 ` janus at gcc dot gnu.org
2011-10-19 22:10 ` janus at gcc dot gnu.org
2013-03-25 15:53 ` burnus at gcc dot gnu.org
2013-03-25 17:46 ` burnus at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-47023-4-weJN0Kq45i@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).