From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-371049-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 10552 invoked by alias); 18 Oct 2011 12:18:57 -0000
Received: (qmail 10543 invoked by uid 22791); 18 Oct 2011 12:18:56 -0000
X-SWARE-Spam-Status: No, hits=-2.9 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO gcc.gnu.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Oct 2011 12:18:42 +0000
From: "janus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/47023] C_Sizeof: Rejects valid code
Date: Tue, 18 Oct 2011 12:18:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: fortran
X-Bugzilla-Keywords: rejects-valid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: janus at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: janus at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields:
Message-ID: <bug-47023-4-weJN0Kq45i@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-47023-4@http.gcc.gnu.org/bugzilla/>
References: <bug-47023-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2011-10/txt/msg01793.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47023

--- Comment #20 from janus at gcc dot gnu.org 2011-10-18 12:17:42 UTC ---
(In reply to comment #19)
> > >  * reject proc-pointers for SIZEOF (comment #7)

I think one could also allow them, but then the implementation of SIZEOF needs
to be fixed to give the size of the pointer.

Draft patch:


Index: gcc/fortran/trans-intrinsic.c
===================================================================
--- gcc/fortran/trans-intrinsic.c    (revision 180129)
+++ gcc/fortran/trans-intrinsic.c    (working copy)
@@ -5088,8 +5088,11 @@ gfc_conv_intrinsic_sizeof (gfc_se *se, gfc_expr *e

       gfc_conv_expr_reference (&argse, arg);

-      type = TREE_TYPE (build_fold_indirect_ref_loc (input_location,
-                         argse.expr));
+      if (arg->ts.type == BT_PROCEDURE)
+    type = TREE_TYPE (argse.expr);
+      else
+    type = TREE_TYPE (build_fold_indirect_ref_loc (input_location,
+                               argse.expr));

       /* Obtain the source word length.  */
       if (arg->ts.type == BT_CHARACTER)


With this the test case in comment #19 gives:

                    8
                    8
                    4

which is ok, apart from the fact that sizeof(proc) should be rejected.