[Bug other/47029] New: fixincludes: the fix for c99 inlines in the glibc header files fixes function declarations as well as function definitions

[Bug other/47029] New: fixincludes: the fix for c99 inlines in the glibc header files fixes function declarations as well as function definitions

[hkodungallur at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47029

           Summary: fixincludes: the fix for c99 inlines in the glibc
                    header files fixes function declarations as well as
                    function definitions
           Product: gcc
           Version: 4.4.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hkodungallur@gmail.com


I am building gcc version 4.4.2 on centos 32-bit machine.

# uname -a
Linux rh55-i386 2.6.18-194.el5PAE #1 SMP Fri Apr 2 15:37:44 EDT 2010 i686 i686
i386 GNU/Linux

The build is successful. But my project fails to build using this built gcc.

The error (actually warning; we have -Werror set) is:

/opt/gcc-4.4.2/bin/../lib/gcc/i686-pc-linux-gnu/4.4.2/include-fixed/sys/stat.h:317:
warning: inline function ‘lstat64’ declared but never defined
/opt/gcc-4.4.2/bin/../lib/gcc/i686-pc-linux-gnu/4.4.2/include-fixed/sys/stat.h:286:
warning: inline function ‘fstatat64’ declared but never defined
/opt/gcc-4.4.2/bin/../lib/gcc/i686-pc-linux-gnu/4.4.2/include-fixed/sys/stat.h:255:
warning: inline function ‘fstat64’ declared but never defined
/opt/gcc-4.4.2/bin/../lib/gcc/i686-pc-linux-gnu/4.4.2/include-fixed/sys/stat.h:250:
warning: inline function ‘stat64’ declared but never defined


The version of glibc on the system is:

# rpm -q glibc
glibc-2.5-49


It looks like fixincludes 'fixes' the function declarations as well, converting
them to extern inline. Example:

this one from <sys/stat.h>:

#ifndef __USE_FILE_OFFSET64
/* Get file attributes for FILE and put them in BUF.  */
extern int stat (__const char *__restrict __file,
                struct stat *__restrict __buf) __THROW __nonnull ((1, 2));


gets converted to the following in the includes-fixed/sys/stat.h:

#ifndef __USE_FILE_OFFSET64
/* Get file attributes for FILE and put them in BUF.  */
#ifdef __GNUC_GNU_INLINE__
extern
#endif
__inline__ int stat (__const char *__restrict __file,
                struct stat *__restrict __buf) __THROW __nonnull ((1, 2));


Similar thing for all the stat/lstat/fstat and stat64/lstat64/fstat64
functions.

The fixincludes should fix only the function definitions. 
Although I've marked it as in Version 4.4.2, apparently this bug is present in
the latest code.


[Ref: This issue was discussed earlier today in the gcc-help list on this
thread: http://gcc.gnu.org/ml/gcc-help/2010-12/msg00197.html]

[Bug other/47029] fixincludes: the fix for c99 inlines in the glibc header files fixes function declarations as well as function definitions

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47029

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2010.12.28 16:11:23
     Ever Confirmed|0                           |1

--- Comment #1 from Richard Guenther <rguenth at gcc dot gnu.org> 2010-12-28 16:11:23 UTC ---
The glibc is a "little" bit old.  Please attach the headerfile.

[Bug other/47029] fixincludes: the fix for c99 inlines in the glibc header files fixes function declarations as well as function definitions

[hkodungallur at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47029

--- Comment #2 from Hari Kodungallur <hkodungallur at gmail dot com> 2011-01-31 20:54:57 UTC ---
Created attachment 23187
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23187
/usr/include/sys/stat.h from a CentOS 5.5 server.

[Bug other/47029] fixincludes: the fix for c99 inlines in the glibc header files fixes function declarations as well as function definitions

[hkodungallur at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47029

--- Comment #3 from Hari Kodungallur <hkodungallur at gmail dot com> 2011-01-31 20:55:37 UTC ---
Sorry for the delay. I was on vacation. I've attached the stat.h header file.

[Bug other/47029] fixincludes: the fix for c99 inlines in the glibc header files fixes function declarations as well as function definitions

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47029

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|1                           |0
             Status|WAITING                     |UNCONFIRMED