[Bug fortran/47040] New: Make error message for empty array constructor more helpful/correct

[Bug fortran/47040] New: Make error message for empty array constructor more helpful/correct

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47040

           Summary: Make error message for empty array constructor more
                    helpful/correct
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: burnus@gcc.gnu.org


Found at
http://groups.google.com/group/comp.lang.fortran/browse_thread/thread/3f6348b03eaed435

The error message:

     call print( [ ] )
                    1
Error: Empty array constructor at (1) is not allowed

is misleading at only empty array constructors without typespec are invalid.
Thus, the following is valid:
     call print( [ real :: ] )


Expect: Error message:
 "Error: Empty array constructor at (1) is not allowed without type-spec"
or
 "Error: Empty array constructor without type-spec at (1) is not allowed"


F2008:

R468 array-constructor is (/ ac-spec /)
                       or lbracket ac-spec rbracket
R469 ac-spec is type-spec ::
             or [type-spec ::] ac-value-list

"An empty sequence forms a zero-sized array."

[Bug fortran/47040] Make error message for empty array constructor more helpful/correct

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47040

--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> 2010-12-22 10:16:56 UTC ---
Draft patch - feel free to take it, I am not sure when I have the time to
submit it.

--- a/gcc/fortran/array.c
+++ b/gcc/fortran/array.c
@@ -1054,7 +1054,8 @@ gfc_match_array_constructor (gfc_expr **result)
        goto done;
       else
        {
-         gfc_error ("Empty array constructor at %C is not allowed");
+         gfc_error ("Empty array constructor without type-spec at %C is not "
+                    "allowed");
          goto cleanup;
        }
     }

[Bug fortran/47040] Make error message for empty array constructor more helpful/correct

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47040

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2013-06-26
     Ever confirmed|0                           |1

--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Still there two years and a half later at revision 200429. What is wrong with
the patch in comment #1?

[Bug fortran/47040] Make error message for empty array constructor more helpful/correct

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47040

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW

--- Comment #3 from Tobias Burnus <burnus at gcc dot gnu.org> ---
(In reply to Dominique d'Humieres from comment #2)
> Still there two years and a half later at revision 200429. What is wrong
> with the patch in comment #1?

Nothing - it just needs to be packaged.

[Bug fortran/47040] Make error message for empty array constructor more helpful/correct

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47040

--- Comment #4 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Nothing - it just needs to be packaged.

Do you want me to do it?