[Bug libstdc++/47045] New: NetBSD: define changes in ctype.h

[Bug libstdc++/47045] New: NetBSD: define changes in ctype.h

[tk at giga dot or.at]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47045

           Summary: NetBSD: define changes in ctype.h
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: tk@giga.or.at


A few days ago, Joerg Sonnenberger improved the name space of NetBSD's ctype.h.
He added "_CTYPE" before "_U", "_N", etc.

The commit message can be seen in
http://mail-index.netbsd.org/source-changes/2010/12/14/msg015830.html
the change to ctype_bits.h:
http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/sys/ctype_bits.h.diff?r1=1.1&r2=1.2&only_with_tag=MAIN
the change to gcc's ctype_base.h as distributed with NetBSD-current:
http://cvsweb.netbsd.org/bsdweb.cgi/src/gnu/dist/gcc4/libstdc++-v3/config/os/bsd/netbsd/ctype_base.h.diff?r1=1.1&r2=1.2&only_with_tag=MAIN

I'd like to see this integrated into one of the next gcc releases.
Since all current releases and older development releases of NetBSD (earlier
than 5.99.41) still have _U etc. it's probably a bit harder than just taking
the change as above.

I'm not sure how you want to do that exactly.

You can test for the older NetBSD versions with _U etc. with:
#include <sys/param.h>
#if __NetBSD_Version__ < 599004100
...
#endif

[Bug libstdc++/47045] NetBSD: define changes in ctype.h

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47045

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2010.12.23 01:41:53
   Target Milestone|---                         |4.6.0
     Ever Confirmed|0                           |1

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> 2010-12-23 01:41:53 UTC ---
should be easy to do, can you test it if I prepare a patch?

[Bug libstdc++/47045] NetBSD: define changes in ctype.h

[tk at giga dot or.at]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47045

--- Comment #2 from Thomas Klausner <tk at giga dot or.at> 2010-12-23 09:35:32 UTC ---
I can test on 5.99.40 and 5.99.41/amd64. Just send me short instructions how to
test. Thanks!

[Bug libstdc++/47045] NetBSD: define changes in ctype.h

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47045

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot       |redi at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> 2010-12-23 10:01:13 UTC ---
Created attachment 22845
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22845
check version in config/os/bsd/netbsd/ctype_base.h

Does <sys/param.h> get included via <ctype.h> or do I need to include it
explicitly?  This patch includes it explicitly.

To test this you'll need to check out svn trunk (or download the gcc-core and
gcc-g++ tarballs from a recent snapshot) and apply this patch in the
libstdc++-v3 directory, then build the compiler.

Let me know if you need details of how to build the compiler if you don't have
the GMP, MPFR and MPC prerequisite libs installed

[Bug libstdc++/47045] NetBSD: define changes in ctype.h

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47045

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> 2010-12-24 01:32:19 UTC ---
Building GCC snapshots made easy:
http://advogato.org/person/redi/diary/229.html

[Bug libstdc++/47045] NetBSD: define changes in ctype.h

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47045

--- Comment #5 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-01-11 16:27:28 UTC ---
Are we still waiting for feedback? PS: IMHO, if just <ctype.h> is ok instead of
<sys/param.h>, it would be much nicer. Besides that nit, it would be nice to
have the tweak in 4.6.0, if we can make it...

[Bug libstdc++/47045] NetBSD: define changes in ctype.h

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47045

--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-01-11 16:34:31 UTC ---
GCC 4.6.0 can't be built on NetBSD (PR 47147) so unless that gets fixed there's
no way to test the changes, and so I thought no urgency to fix this one

I'm happy to commit the changes untested if you want.

I tried to check the NetBSD CVS repo to find out if ctype.h includes
sys/param.h but I couldn't find the right files

[Bug libstdc++/47045] NetBSD: define changes in ctype.h

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47045

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paolo.carlini at oracle dot
                   |                            |com

--- Comment #7 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-01-11 16:46:31 UTC ---
Ah, I didn't know about 47147. Let's wait a bit more then.

[Bug libstdc++/47045] NetBSD: define changes in ctype.h

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47045

--- Comment #8 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-01-13 00:02:48 UTC ---
Author: redi
Date: Thu Jan 13 00:02:41 2011
New Revision: 168732

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=168732
Log:
2011-01-13  Jonathan Wakely  <jwakely.gcc@gmail.com>

    PR libstdc++/47045
    * config/os/bsd/netbsd/ctype_base.h: Use new macros based on version.


Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/config/os/bsd/netbsd/ctype_base.h

[Bug libstdc++/47045] NetBSD: define changes in ctype.h

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47045

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Jonathan Wakely <redi at gcc dot gnu.org> 2011-01-13 00:05:42 UTC ---
While testing PR 47147 I was able to verify my patch for this bug allows
libstdc++ to build, but I didn't have dejagnu so couldn't run the testsuite.
Should be fixed for 4.6.0