[Bug middle-end/47046] New: gcc.target/i386/sse4_1-movntdqa.c ICEs with -fgraphite-identity

[Bug middle-end/47046] New: gcc.target/i386/sse4_1-movntdqa.c ICEs with -fgraphite-identity

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47046

           Summary: gcc.target/i386/sse4_1-movntdqa.c ICEs with
                    -fgraphite-identity
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: howarth@nitro.med.uc.edu


The gcc.target/i386/sse4_1-movntdqa.c test case ICEs the compiler when
-fgraphite identity is used.

Executing on host: /Users/howarth/darwin_objdir/gcc/xgcc
-B/Users/howarth/darwin_objdir/gcc/
/Users/howarth/gcc/gcc/testsuite/gcc.target/i386/sse4_1-movntdqa.c   -O2
-msse4.1  -lm   -fgraphite-identity -o ./sse4_1-movntdqa.exe    (timeout = 300)
/Users/howarth/gcc/gcc/testsuite/gcc.target/i386/sse4_1-movntdqa.c: In function
'sse4_1_test':
/Users/howarth/gcc/gcc/testsuite/gcc.target/i386/sse4_1-movntdqa.c:34:1:
internal compiler error: in rename_uses, at sese.c:544

This backtraces as...

Breakpoint 1, fancy_abort (file=0x1009aeb60 "../../gcc/gcc/sese.c", line=544,
function=0x100a58414 "rename_uses") at ../../gcc/gcc/diagnostic.c:893
893      internal_error ("in %s, at %s:%d", function, trim_filename (file),
line);
(gdb) bt
#0  fancy_abort (file=0x1009aeb60 "../../gcc/gcc/sese.c", line=544,
function=0x100a58414 "rename_uses") at ../../gcc/gcc/diagnostic.c:893
#1  0x0000000100666c95 in copy_bb_and_scalar_dependences (bb=<value temporarily
unavailable, due to optimizations>, region=0x143133ae0, next_e=<value
temporarily unavailable, due to optimizations>, iv_map=0x14313f560) at
../../gcc/gcc/sese.c:543
(gdb) 

on x86_64-apple-darwin10 using r168197.

Using built-in specs.
COLLECT_GCC=dist/bin/gcc
COLLECT_LTO_WRAPPER=/Users/howarth/dist/libexec/gcc/x86_64-apple-darwin10.5.0/4.6.0/lto-wrapper
Target: x86_64-apple-darwin10.5.0
Configured with: ../gcc/configure --enable-checking=yes
--prefix=/Users/howarth/dist --with-gmp=/sw --with-ppl=/sw --with-cloog=/sw
--with-mpc=/sw --with-libiconv-prefix=/sw --with-system-zlib
--x-includes=/usr/X11R6/include --x-libraries=/usr/X11R6/lib
--enable-languages=c --enable-checking=yes
Thread model: posix
gcc version 4.6.0 20101223 (experimental) (GCC)

[Bug middle-end/47046] gcc.target/i386/sse4_1-movntdqa.c ICEs with -fgraphite-identity

[spop at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47046

Sebastian Pop <spop at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2011.02.07 06:48:14
         AssignedTo|unassigned at gcc dot       |spop at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

--- Comment #1 from Sebastian Pop <spop at gcc dot gnu.org> 2011-02-07 06:48:14 UTC ---
The testcase contains a chrec: {0, +, {1, +, 2}_1}_1
and chrec_apply (1, {0, +, {1, +, 2}_1}_1, graphite_IV)
fails to produce an expression that can be code generated.

This could be fixed by implementing the missing case
in chrec_apply.  That's probably a too big change for 4.6.

[Bug middle-end/47046] gcc.target/i386/sse4_1-movntdqa.c ICEs with -fgraphite-identity

[spop at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47046

--- Comment #2 from Sebastian Pop <spop at gcc dot gnu.org> 2011-07-25 21:49:53 UTC ---
Patch
http://gcc.gnu.org/ml/gcc-patches/2011-07/msg02209.html

[Bug middle-end/47046] gcc.target/i386/sse4_1-movntdqa.c ICEs with -fgraphite-identity

[spop at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47046

--- Comment #3 from Sebastian Pop <spop at gcc dot gnu.org> 2011-07-26 18:48:57 UTC ---
Author: spop
Date: Tue Jul 26 18:48:49 2011
New Revision: 176805

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=176805
Log:
Fix PR47046: correct evolution_function_is_affine_p

"Bug 47046 - gcc.target/i386/sse4_1-movntdqa.c ICEs with -fgraphite-identity"

The problem here is that we are left with the following code to be
translated in the new representation following the transform that
Graphite has chosen:

        D.2709_14 = j_33 * i_32;
        D.2710_15 = D.2709_14 * i_32;
        D.2711_16 = D.2710_15 * sign_34;
        *D.2708_13 = D.2711_16;

In this particular case we have a nonlinear expression "i * i" for
which we have to generate code following the new graphite_iv variables.

The patch fixes the function that detects whether we are passing non
linear stuff to graphite: evolution_function_is_affine_p.  It seems
like for the moment evolution_function_is_affine_p is testing whether
an evolution function is affine only in the innermost loop, without
looking recursively at what happens in outer loops.

The chrec for this case is: {0, +, {0, +, {1, +, 2}_1}_1}_2 and we are
testing whether the evolution is affine only for the loop_2, which is
true as we have {0, +, blah}_2 with blah invariant in loop_2.

The patch adds the recursive call to evolution_function_is_affine_p.

Bootstrapped and tested on amd64-linux.

2011-07-26  Sebastian Pop  <sebastian.pop@amd.com>

    PR middle-end/47046
    * tree-chrec.h (evolution_function_is_affine_p): Recursively call
    evolution_function_is_affine_p on CHREC_RIGHT.

    * gcc.dg/graphite/id-pr47046.c: New.

Added:
    trunk/gcc/testsuite/gcc.dg/graphite/id-pr47046.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-chrec.h

[Bug middle-end/47046] gcc.target/i386/sse4_1-movntdqa.c ICEs with -fgraphite-identity

[spop at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47046

Sebastian Pop <spop at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Sebastian Pop <spop at gcc dot gnu.org> 2011-07-26 18:53:47 UTC ---
Fixed.