[Bug ada/47056] New: [4.6 Regression] 10 Ada ACATS tests fail to link with undefined reference on ia64-linux

[Bug ada/47056] New: [4.6 Regression] 10 Ada ACATS tests fail to link with undefined reference on ia64-linux

[laurent at guerby dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47056

           Summary: [4.6 Regression] 10 Ada ACATS tests fail to link with
                    undefined reference on ia64-linux
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Keywords: link-failure
          Severity: normal
          Priority: P3
         Component: ada
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: laurent@guerby.net
              Host: ia64-linux
            Target: ia64-linux
             Build: ia64-linux


From:

http://gcc.gnu.org/ml/gcc-testresults/2010-12/msg02106.html

The following ACATS FAIL with the same kind of linker error:

FAIL:    c390002
FAIL:    c392002
FAIL:    c392003
FAIL:    c392013
FAIL:    c393008
FAIL:    c393009
FAIL:    c760013
FAIL:    cd72a02
FAIL:    cdd2a01
FAIL:    cdd2a03


gnatlink c390002.ali -O2 --GCC=/home/guerby/build/gcc/xgcc
-B/home/guerby/build/gcc/
./c390002.o: In function `_ada_c390002':
c390002.adb:(.text+0x1070): undefined reference to
`c390002__vehicle___alignment.1865'
c390002.adb:(.text+0x1071): undefined reference to
`c390002__vehicle__objectDF.1869'
c390002.adb:(.text+0x1072): undefined reference to
`c390002__vehicle__create.1880'
c390002.adb:(.text+0x1082): undefined reference to
`c390002__vehicle__wheels.1883'
c390002.adb:(.text+0x16d0): undefined reference to
`c390002__motivators___alignment.2087'
c390002.adb:(.text+0x1cc0): undefined reference to
`c390002__motivators___alignment__2.2292'
c390002.adb:(.text+0x22a0): undefined reference to
`c390002__motivators___alignment__3.2497'
collect2: ld returned 1 exit status
gnatlink: error when calling /home/guerby/build/gcc/xgcc
gnatlink: error when calling /home/guerby/build/gcc/xgcc
gnatmake: *** link failed.

...

gnatlink cdd2a03.ali -O2 --GCC=/home/guerby/build/gcc/xgcc
-B/home/guerby/build/gcc/
./cdd2a03.o: In function `_ada_cdd2a03':
cdd2a03.adb:(.text+0x1520): undefined reference to `cdd2a03___alignment.2046'
cdd2a03.adb:(.text+0x1600): undefined reference to `cdd2a03__parentDF.2073'
cdd2a03.adb:(.text+0x1b92): undefined reference to
`cdd2a03___alignment__2.2511'
cdd2a03.adb:(.text+0x20b2): undefined reference to
`cdd2a03___alignment__3.2709'
collect2: ld returned 1 exit status
gnatlink: error when calling /home/guerby/build/gcc/xgcc
gnatmake: *** link failed.

(The other two FAIL are unrelated)

[Bug ada/47056] [4.6 Regression] 10 Ada ACATS tests fail to link with undefined reference on ia64-linux

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47056

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P5
                 CC|                            |jakub at gcc dot gnu.org
   Target Milestone|---                         |4.6.0

[Bug ada/47056] [4.6 Regression] 10 Ada ACATS tests fail to link with undefined reference on ia64-linux

[laurent at guerby dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47056

Laurent GUERBY <laurent at guerby dot net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ebotcazou at gcc dot
                   |                            |gnu.org

--- Comment #1 from Laurent GUERBY <laurent at guerby dot net> 2010-12-27 22:26:40 UTC ---
I took one of the test and it fails to link at -O2 and -O1 but works and PASS
at -O0, see below. So I'm assuming some optimization is creating the issue, any
idea on what to look for?

guerby@Babe:~/tmp$ gnatmake -f -O2 c390002.adb 
gcc -c -O2 c390002.adb
c390002.adb:101:11: warning: unreachable code
gcc -c -O2 report.adb
report.adb:312:30: warning: index for "NAM" may assume lower bound of 1
report.adb:312:30: warning: suggested replacement: "NAM'First + 2"
report.adb:312:33: warning: index for "NAM" may assume lower bound of 1
report.adb:312:33: warning: suggested replacement: "NAM'First + 6"
gnatbind -x c390002.ali
gnatlink c390002.ali -O2
./c390002.o: In function `_ada_c390002':
c390002.adb:(.text+0x1070): undefined reference to
`c390002__vehicle___alignment.1865'
c390002.adb:(.text+0x1071): undefined reference to
`c390002__vehicle__objectDF.1869'
c390002.adb:(.text+0x1072): undefined reference to
`c390002__vehicle__create.1880'
c390002.adb:(.text+0x1082): undefined reference to
`c390002__vehicle__wheels.1883'
c390002.adb:(.text+0x16d0): undefined reference to
`c390002__motivators___alignment.2087'
c390002.adb:(.text+0x1cc0): undefined reference to
`c390002__motivators___alignment__2.2292'
c390002.adb:(.text+0x22a0): undefined reference to
`c390002__motivators___alignment__3.2497'
collect2: ld returned 1 exit status
gnatlink: error when calling /home/guerby/install-trunk/bin/gcc
gnatmake: *** link failed.
guerby@Babe:~/tmp$ gnatmake -f -O1 c390002.adb 
gcc -c -O1 c390002.adb
c390002.adb:101:11: warning: unreachable code
gcc -c -O1 report.adb
report.adb:312:30: warning: index for "NAM" may assume lower bound of 1
report.adb:312:30: warning: suggested replacement: "NAM'First + 2"
report.adb:312:33: warning: index for "NAM" may assume lower bound of 1
report.adb:312:33: warning: suggested replacement: "NAM'First + 6"
gnatbind -x c390002.ali
gnatlink c390002.ali -O1
./c390002.o: In function `_ada_c390002':
c390002.adb:(.text+0x1041): undefined reference to
`c390002__vehicle___alignment.1865'
c390002.adb:(.text+0x1081): undefined reference to
`c390002__vehicle__objectDF.1869'
c390002.adb:(.text+0x11a0): undefined reference to
`c390002__vehicle__wheels.1883'
c390002.adb:(.text+0x1781): undefined reference to
`c390002__motivators___alignment.2087'
c390002.adb:(.text+0x18a0): undefined reference to
`c390002__vehicle__wheels.1883'
c390002.adb:(.text+0x1e71): undefined reference to
`c390002__motivators___alignment__2.2292'
c390002.adb:(.text+0x1f70): undefined reference to
`c390002__vehicle__wheels.1883'
c390002.adb:(.text+0x2531): undefined reference to
`c390002__motivators___alignment__3.2497'
c390002.adb:(.text+0x2620): undefined reference to
`c390002__vehicle__wheels.1883'
collect2: ld returned 1 exit status
gnatlink: error when calling /home/guerby/install-trunk/bin/gcc
gnatmake: *** link failed.
guerby@Babe:~/tmp$ gnatmake -f -O0 c390002.adb 
gcc -c -O0 c390002.adb
c390002.adb:101:11: warning: unreachable code
gcc -c -O0 report.adb
report.adb:312:30: warning: index for "NAM" may assume lower bound of 1
report.adb:312:30: warning: suggested replacement: "NAM'First + 2"
report.adb:312:33: warning: index for "NAM" may assume lower bound of 1
report.adb:312:33: warning: suggested replacement: "NAM'First + 6"
gnatbind -x c390002.ali
gnatlink c390002.ali -O0
guerby@Babe:~/tmp$ ./c390002 

,.,. C390002 ACATS 2.5 10-12-27 23:26:15
---- C390002 Check that a tagged type may be declared and derived from
                in simple, private and extended forms.  Check package
                Ada.Tags.
==== C390002 PASSED ============================.

[Bug ada/47056] [4.6 Regression] 10 Ada ACATS tests fail to link with undefined reference on ia64-linux

[laurent at guerby dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47056

--- Comment #2 from Laurent GUERBY <laurent at guerby dot net> 2010-12-28 08:48:11 UTC ---
Reduced test case:

procedure C390002 is
    type Object is tagged null record;
begin
   null;
end C390002;

guerby@Babe:~/tmp$ gnatmake -f -O1 c390002.adb
gcc -c -O1 c390002.adb
gnatbind -x c390002.ali
gnatlink c390002.ali -O1
./c390002.o: In function `_ada_c390002':
c390002.adb:(.text+0x661): undefined reference to `c390002___alignment.1835'
c390002.adb:(.text+0x6a1): undefined reference to `c390002__objectSR.1844'
c390002.adb:(.text+0x6e1): undefined reference to `c390002__objectSW.1850'
c390002.adb:(.text+0x771): undefined reference to `c390002__objectSO.1861'
c390002.adb:(.text+0x7b1): undefined reference to `c390002__Oeq.1865'
c390002.adb:(.text+0x7f1): undefined reference to `c390002___assign.1869'
c390002.adb:(.text+0x831): undefined reference to `c390002__objectDA.1887'
c390002.adb:(.text+0x871): undefined reference to `c390002__objectDF.1891'
collect2: ld returned 1 exit status
gnatlink: error when calling /home/guerby/install-trunk/bin/gcc
gnatmake: *** link failed.
guerby@Babe:~/tmp$ gnatmake -f -O0 c390002.adb
gcc -c -O0 c390002.adb
gnatbind -x c390002.ali
gnatlink c390002.ali -O0
guerby@Babe:~/tmp$

[Bug ada/47056] [4.6 Regression] 10 Ada ACATS tests fail to link with undefined reference on ia64-linux

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47056

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2010.12.28 15:21:44
            Version|unknown                     |4.6.0
     Ever Confirmed|0                           |1

--- Comment #3 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2010-12-28 15:21:44 UTC ---
> I took one of the test and it fails to link at -O2 and -O1 but works and PASS
> at -O0, see below. So I'm assuming some optimization is creating the issue,
> any idea on what to look for?

Probably a hole related to descriptors in reachability analysis.  The dump file
.043i.whole-program contains:

Reclaiming functions: P.Objectdf P.Objectda P P."=" P.Objectso P.Objectsw
P.Objectsr P

[Bug ada/47056] [4.6 Regression] 10 Ada ACATS tests fail to link with undefined reference on ia64-linux

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47056

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|ebotcazou at gcc dot        |
                   |gnu.org                     |
         AssignedTo|unassigned at gcc dot       |ebotcazou at gcc dot
                   |gnu.org                     |gnu.org

--- Comment #4 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2010-12-28 15:23:28 UTC ---
Investigating.

[Bug ada/47056] [4.6 Regression] 10 Ada ACATS tests fail to link with undefined reference on ia64-linux

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47056

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rguenth at gcc dot gnu.org

--- Comment #5 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2011-01-02 19:14:22 UTC ---
The problem is that CCP turns:

  pr47056___alignment.46_308 = pr47056___alignment;
  D.2264_309 = MEM[(struct  *)pr47056___alignment.46_308].D.227;

into

  D.2264_309 = MEM[(struct  *)pr47056___alignment].D.227;

(pr47056___alignment being a function) and while walk_stmt_load_store_addr_ops
recognizes the former as an address-of pattern (the & is implicit for
functions), it doesn't for the latter (unlike for TARGET_MEM_REF) so
build_cgraph_edges is fooled and missed the reference to pr47056___alignment.

Richard, I presume that the latter form must be deemed invalid GIMPLE?

[Bug tree-optimization/47056] [4.6 Regression] 10 Ada ACATS tests fail to link with undefined reference on ia64-linux

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47056

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|ada                         |tree-optimization

--- Comment #6 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2011-01-04 10:51:15 UTC ---
Recategorizing.

[Bug tree-optimization/47056] [4.6 Regression] 10 Ada ACATS tests fail to link with undefined reference on ia64-linux

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47056

--- Comment #7 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2011-01-04 10:53:14 UTC ---
Created attachment 22895
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22895
Tentative fix

This doesn't change GIMPLE but instead tweaks reachability analysis.

[Bug tree-optimization/47056] [4.6 Regression] 10 Ada ACATS tests fail to link with undefined reference on ia64-linux

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47056

--- Comment #8 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2011-01-04 23:22:35 UTC ---
Author: ebotcazou
Date: Tue Jan  4 23:22:31 2011
New Revision: 168493

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=168493
Log:
    PR tree-optimization/47056
    * cgraphbuild.c (mark_address): Remove ATTRIBUTE_UNUSED markers.
    (mark_load): Likewise.  Handle FUNCTION_DECL specially.
    (mark_store): Likewise.  Pass STMT to ipa_record_reference.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cgraphbuild.c

[Bug tree-optimization/47056] [4.6 Regression] 10 Ada ACATS tests fail to link with undefined reference on ia64-linux

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47056

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2011-01-04 23:25:56 UTC ---
Applied.

[Bug tree-optimization/47056] [4.6 Regression] 10 Ada ACATS tests fail to link with undefined reference on ia64-linux

[laurent at guerby dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47056

--- Comment #10 from Laurent GUERBY <laurent at guerby dot net> 2011-01-10 09:37:23 UTC ---
Thanks Eric :)

http://gcc.gnu.org/ml/gcc-testresults/2011-01/msg00728.html

LAST_UPDATED: Sat Jan  8 23:02:58 UTC 2011 (revision 168603)
        === acats tests ===
FAIL:    cb1010c
FAIL:    cb1010d
        === acats Summary ===
# of expected passes        2319
# of unexpected failures    2
Native configuration is ia64-unknown-linux-gnu