public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug testsuite/47057] New: FAIL/XPASS gcc.dg/vect/costmodel/ppc/costmodel-vect-outer-fir.c
@ 2010-12-23 21:19 dominiq at lps dot ens.fr
  2010-12-25 11:50 ` [Bug testsuite/47057] " irar at il dot ibm.com
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: dominiq at lps dot ens.fr @ 2010-12-23 21:19 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47057

           Summary: FAIL/XPASS
                    gcc.dg/vect/costmodel/ppc/costmodel-vect-outer-fir.c
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: dominiq@lps.ens.fr
            Target: powerpc*-*-*


The test gcc.dg/vect/costmodel/ppc/costmodel-vect-outer-fir.c gives

XPASS: gcc.dg/vect/costmodel/ppc/costmodel-vect-outer-fir.c
scan-tree-dump-times vect "OUTER LOOP VECTORIZED" 2
FAIL: gcc.dg/vect/costmodel/ppc/costmodel-vect-outer-fir.c scan-tree-dump-times
vect "OUTER LOOP VECTORIZED" 1

Obviously if there are two outer loops vectorized, there cannot be only one
vectorized! The following patch fixes the test

---
../_gcc_clean/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-outer-fir.c
   2007-11-21 20:18:34.000000000 +0100
+++
../gcc-4.6-work/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-outer-fir.c
   2010-12-23 22:02:28.000000000 +0100
@@ -71,6 +71,6 @@ int main (void)
   return 0;
 }

-/* { dg-final { scan-tree-dump-times "OUTER LOOP VECTORIZED" 2 "vect" { xfail
*-*-* } } } */
-/* { dg-final { scan-tree-dump-times "OUTER LOOP VECTORIZED" 1 "vect" { xfail
vect_no_align } } } */
+/* { dg-final { scan-tree-dump-times "OUTER LOOP VECTORIZED" 2 "vect" { xfail
vect_no_align } } } */
+/* { dg-final { scan-tree-dump-times "OUTER LOOP VECTORIZED" 1 "vect" { xfail
{ ! vect_no_align } } } } */
 /* { dg-final { cleanup-tree-dump "vect" } } */


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug testsuite/47057] FAIL/XPASS gcc.dg/vect/costmodel/ppc/costmodel-vect-outer-fir.c
  2010-12-23 21:19 [Bug testsuite/47057] New: FAIL/XPASS gcc.dg/vect/costmodel/ppc/costmodel-vect-outer-fir.c dominiq at lps dot ens.fr
@ 2010-12-25 11:50 ` irar at il dot ibm.com
  2010-12-25 12:54 ` irar at gcc dot gnu.org
  2010-12-25 12:55 ` irar at il dot ibm.com
  2 siblings, 0 replies; 4+ messages in thread
From: irar at il dot ibm.com @ 2010-12-25 11:50 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47057

Ira Rosen <irar at il dot ibm.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2010.12.25 11:49:58
                 CC|                            |irar at il dot ibm.com
         AssignedTo|unassigned at gcc dot       |irar at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

--- Comment #1 from Ira Rosen <irar at il dot ibm.com> 2010-12-25 11:49:58 UTC ---
The first loop now gets vectorized, it didn't because of:

/* Currently not vectorized because we get too many BBs in the inner-loop,
   because the compiler doesn't realize that the inner-loop executes at
   least once (cause k<4), and so there's no need to create a guard code
   to skip the inner-loop in case it doesn't execute.  */


So, the correct fix is to expect 2 outer loop vectorized on targets that
support realignment.

I'll fix the test.

Ira


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug testsuite/47057] FAIL/XPASS gcc.dg/vect/costmodel/ppc/costmodel-vect-outer-fir.c
  2010-12-23 21:19 [Bug testsuite/47057] New: FAIL/XPASS gcc.dg/vect/costmodel/ppc/costmodel-vect-outer-fir.c dominiq at lps dot ens.fr
  2010-12-25 11:50 ` [Bug testsuite/47057] " irar at il dot ibm.com
@ 2010-12-25 12:54 ` irar at gcc dot gnu.org
  2010-12-25 12:55 ` irar at il dot ibm.com
  2 siblings, 0 replies; 4+ messages in thread
From: irar at gcc dot gnu.org @ 2010-12-25 12:54 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47057

--- Comment #2 from irar at gcc dot gnu.org 2010-12-25 12:54:02 UTC ---
Author: irar
Date: Sat Dec 25 12:53:58 2010
New Revision: 168242

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=168242
Log:

        PR testsuite/47057
        * gcc.dg/vect/costmodel/ppc/costmodel-vect-outer-fir.c: Change
        comment. Expect two outer loops to get vectorized.


Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/vect/costmodel/ppc/costmodel-vect-outer-fir.c


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug testsuite/47057] FAIL/XPASS gcc.dg/vect/costmodel/ppc/costmodel-vect-outer-fir.c
  2010-12-23 21:19 [Bug testsuite/47057] New: FAIL/XPASS gcc.dg/vect/costmodel/ppc/costmodel-vect-outer-fir.c dominiq at lps dot ens.fr
  2010-12-25 11:50 ` [Bug testsuite/47057] " irar at il dot ibm.com
  2010-12-25 12:54 ` irar at gcc dot gnu.org
@ 2010-12-25 12:55 ` irar at il dot ibm.com
  2 siblings, 0 replies; 4+ messages in thread
From: irar at il dot ibm.com @ 2010-12-25 12:55 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47057

Ira Rosen <irar at il dot ibm.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Ira Rosen <irar at il dot ibm.com> 2010-12-25 12:55:18 UTC ---
Fixed.


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-12-25 12:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-23 21:19 [Bug testsuite/47057] New: FAIL/XPASS gcc.dg/vect/costmodel/ppc/costmodel-vect-outer-fir.c dominiq at lps dot ens.fr
2010-12-25 11:50 ` [Bug testsuite/47057] " irar at il dot ibm.com
2010-12-25 12:54 ` irar at gcc dot gnu.org
2010-12-25 12:55 ` irar at il dot ibm.com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).