[Bug target/47098] New: i686-openbsd3.0: OBSD_LIB_SPEC missing

[Bug target/47098] New: i686-openbsd3.0: OBSD_LIB_SPEC missing

[amylaar at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47098

           Summary: i686-openbsd3.0: OBSD_LIB_SPEC missing
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Keywords: build
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: amylaar@gcc.gnu.org
            Blocks: 47093
              Host: x86_64-pc-linux-gnu
            Target: i686-openbsd3.0


../../../gcc/gcc/gcc.c:684:31: error: ‘OBSD_LIB_SPEC’ undeclared here (not in a
function)
make[2]: *** [gcc.o] Error 1

[Bug target/47098] i686-openbsd3.0: OBSD_LIB_SPEC missing

[amylaar at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47098

Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|4.6.0                       |4.8.0

--- Comment #1 from Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> 2012-09-21 15:38:08 UTC ---
The error looks like this now:

g++   -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE  -fno-exceptions -fno-rtti -W
-Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute
-pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror
-fno-common  -DHAVE_CONFIG_H -I. -I. -I../../../gcc/gcc -I../../../gcc/gcc/.
-I../../../gcc/gcc/../include -I../../../gcc/gcc/../libcpp/include 
-I../../../gcc/gcc/../libdecnumber -I../../../gcc/gcc/../libdecnumber/dpd
-I../libdecnumber    \
  -DSTANDARD_STARTFILE_PREFIX=\"../../../\"
-DSTANDARD_EXEC_PREFIX=\"/usr/local/lib/gcc/\"
-DSTANDARD_LIBEXEC_PREFIX=\"/usr/local/libexec/gcc/\"
-DDEFAULT_TARGET_VERSION=\"4.8.0\" -DDEFAULT_TARGET_MACHINE=\"i686-openbsd3.0\"
-DSTANDARD_BINDIR_PREFIX=\"/usr/local/bin/\"
-DTOOLDIR_BASE_PREFIX=\"../../../../\"  `test "X${SHLIB}" = "X" || test "yes"
!= "yes" || echo "-DENABLE_SHARED_LIBGCC"` -DCONFIGURE_SPECS="\"\"" \
  -c ../../../gcc/gcc/gcc.c -o gcc.o)
In file included from ./tm.h:24:0,
                 from ../../../gcc/gcc/gcc.c:37:
../../../gcc/gcc/config/openbsd.h:144:18: error: ‘OBSD_LIB_SPEC’ was not
declared in this scope
 #define LIB_SPEC OBSD_LIB_SPEC
                  ^
../../../gcc/gcc/gcc.c:716:31: note: in expansion of macro 'LIB_SPEC'
 static const char *lib_spec = LIB_SPEC;
                               ^
make[2]: *** [gcc.o] Error 1
rm gcj-dbtool.pod jcf-dump.pod gcj.pod cpp.pod fsf-funding.pod gij.pod
gc-analyze.pod grmic.pod gccgo.pod gcc.pod gfortran.pod jv-convert.pod gfdl.pod
gcov.pod
make[2]: Leaving directory `/home/amylaar/fsf/multi/i686-openbsd3.0/gcc'
make[1]: *** [all-gcc] Error 2
make[1]: Leaving directory `/home/amylaar/fsf/multi/i686-openbsd3.0'

[Bug target/47098] i686-openbsd3.0: OBSD_LIB_SPEC missing

[aldot at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47098

Bernhard Reutner-Fischer <aldot at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|2013-02-25 00:00:00         |2015-04-10
                 CC|                            |aldot at gcc dot gnu.org
     Ever confirmed|0                           |1
      Known to fail|                            |5.0

--- Comment #2 from Bernhard Reutner-Fischer <aldot at gcc dot gnu.org> ---
I see 2 ways to fix this, fwiw:

1)

diff --git a/gcc/config/openbsd-oldgas.h b/gcc/config/openbsd-oldgas.h
index 04a4d37..0e2aebc 100644
--- a/gcc/config/openbsd-oldgas.h
+++ b/gcc/config/openbsd-oldgas.h
@@ -20,3 +20,6 @@ along with GCC; see the file COPYING3.  If not see


 #define OBSD_OLD_GAS
+
+/* OpenBSD3.0 had no libpthread, pthreads lived in -lc_r */
+#define OBSD_LIB_SPEC "%{!shared:-lc%{pthread:_r}}"


i.e. openbsd-oldgas.h is only used on i?86-*-openbsd2.*|i?86-*openbsd3.[0123]
so is right on spot it seems.

2) Remove openbsd <= 3.3 support altogether since openbsd-3.3 was released May
1, 2003.
This probably needs an announcement from Release Managers or something.

[Bug target/47098] i686-openbsd3.0: OBSD_LIB_SPEC missing

[aldot at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47098

--- Comment #3 from Bernhard Reutner-Fischer <aldot at gcc dot gnu.org> ---
Author: aldot
Date: Wed Apr 22 08:41:13 2015
New Revision: 222315

URL: https://gcc.gnu.org/viewcvs?rev=222315&root=gcc&view=rev
Log:
PR target/47098 OBSD_LIB_SPEC on i686-openbsd3 missing

config-list.mk for i686-*-openbsd3.0 failed with:

gcc/config/openbsd.h:143:18: error: ‘OBSD_LIB_SPEC’ was not declared in this
scope
 #define LIB_SPEC OBSD_LIB_SPEC
                  ^
gcc/gcc.c:879:31: note:
in expansion of macro ‘LIB_SPEC’
 static const char *lib_spec = LIB_SPEC;
                               ^
make[2]: *** [gcc.o] Error 1

i.e. openbsd-oldgas.h is only used on
i?86-*-openbsd2.*|i?86-*openbsd3.[0123] so add the OBSD_LIB_SPEC there


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/openbsd-oldgas.h
>From gcc-bugs-return-484231-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Apr 22 08:45:53 2015
Return-Path: <gcc-bugs-return-484231-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 22110 invoked by alias); 22 Apr 2015 08:45:52 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 22065 invoked by uid 48); 22 Apr 2015 08:45:49 -0000
From: "aldot at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/47098] i686-openbsd3.0: OBSD_LIB_SPEC missing
Date: Wed, 22 Apr 2015 08:45:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.8.0
X-Bugzilla-Keywords: build
X-Bugzilla-Severity: normal
X-Bugzilla-Who: aldot at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cf_known_to_work cf_known_to_fail
Message-ID: <bug-47098-4-uR90KMKCqC@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-47098-4@http.gcc.gnu.org/bugzilla/>
References: <bug-47098-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-04/txt/msg01783.txt.bz2
Content-length: 459

https://gcc.gnu.org/bugzilla/show_bug.cgi?idG098

Bernhard Reutner-Fischer <aldot at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |6.0
      Known to fail|5.0                         |4.8.0, 4.9.2

--- Comment #4 from Bernhard Reutner-Fischer <aldot at gcc dot gnu.org> ---
Fixed on the trunk.