[Bug debug/47106] New: -fcompare-debug failure (length) with -fpartial-inlining -flto -fconserve-stack

[Bug debug/47106] New: -fcompare-debug failure (length) with -fpartial-inlining -flto -fconserve-stack

[zsojka at seznam dot cz]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47106

           Summary: -fcompare-debug failure (length) with
                    -fpartial-inlining -flto -fconserve-stack
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: debug
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: zsojka@seznam.cz
                CC: aoliva@gcc.gnu.org
              Host: x86_64-pc-linux-gnu
            Target: x86_64-pc-linux-gnu


Created attachment 22864
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22864
reduced testcase

Compiler output:
$ gcc -O -fpartial-inlining -flto -fconserve-stack -fcompare-debug pr47106.C 
gcc: error: pr47106.C: -fcompare-debug failure (length)

Different code is generated with and without -g.

Tested revisions:
r168296 - fail

[Bug debug/47106] -fcompare-debug failure (length) with -fpartial-inlining -flto -fconserve-stack

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47106

Alexandre Oliva <aoliva at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2010.12.30 20:09:30
         AssignedTo|unassigned at gcc dot       |aoliva at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

--- Comment #1 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2010-12-30 20:09:30 UTC ---
Mine

[Bug debug/47106] -fcompare-debug failure (length) with -fpartial-inlining -flto -fconserve-stack

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47106

--- Comment #2 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2010-12-30 20:15:22 UTC ---
Created attachment 22870
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22870
Patch that fixes the bug, regstrapping

When estimating the stack size of a function, we shouldn't set TREE_USED in the
loop over local decls, for this makes us count every block var that is local
when accounting block vars: since we preserve more block vars for debugging
purposes, we end up counting them all in the latter pass, even if they weren't
marked as TREE_USED before the loop over locals.

Simply removing the set would be enough to fix the bug, but I figured we'd get
more accurate results if we refrained from counting variables twice, so I added
a bitmap.  This fixes the bug, testing a bootstrap with these flags now.

[Bug debug/47106] -fcompare-debug failure (length) with -fpartial-inlining -flto -fconserve-stack

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47106

--- Comment #3 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2011-01-21 14:57:36 UTC ---
Author: aoliva
Date: Fri Jan 21 14:57:33 2011
New Revision: 169093

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=169093
Log:
PR debug/47106
* cfgexpand.c (account_used_vars_for_block): Only account vars
that are annotated as used.
(estimated_stack_frame_size): Don't set TREE_USED.
* tree-dfa.c (create_var_ann): Mark variable as used.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cfgexpand.c
    trunk/gcc/tree-dfa.c

[Bug debug/47106] -fcompare-debug failure (length) with -fpartial-inlining -flto -fconserve-stack

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47106

Alexandre Oliva <aoliva at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2011-01-21 15:17:13 UTC ---
Fixed

[Bug debug/47106] -fcompare-debug failure (length) with -fpartial-inlining -flto -fconserve-stack

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47106

--- Comment #5 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2011-01-21 22:11:28 UTC ---
Author: aoliva
Date: Fri Jan 21 22:11:24 2011
New Revision: 169107

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=169107
Log:
PR debug/47402
Temporarily revert:
2011-01-21  Alexandre Oliva  <aoliva@redhat.com>
PR debug/47106
* tree-dfa.c (create_var_ann): Mark variable as used.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-dfa.c

[Bug debug/47106] -fcompare-debug failure (length) with -fpartial-inlining -flto -fconserve-stack

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47106

Alexandre Oliva <aoliva at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #6 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2011-01-31 05:36:14 UTC ---
Fix reverted because of bug 47402, still working on a proper fix.

[Bug debug/47106] -fcompare-debug failure (length) with -fpartial-inlining -flto -fconserve-stack

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47106

--- Comment #7 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2011-01-31 11:03:11 UTC ---
Revised patch under testing, posted at
http://gcc.gnu.org/ml/gcc-patches/2011-01/msg02264.html

[Bug debug/47106] -fcompare-debug failure (length) with -fpartial-inlining -flto -fconserve-stack

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47106

--- Comment #8 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2011-02-02 05:44:44 UTC ---
Author: aoliva
Date: Wed Feb  2 05:44:38 2011
New Revision: 169514

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=169514
Log:
PR debug/47106
PR debug/47402
* tree-inline.c (declare_return_variable): Add result decl to
local decls only once.
* gimple-low.c (record_vars_into): Mark newly-created variables
as referenced.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/gimple-low.c
    trunk/gcc/tree-inline.c

[Bug debug/47106] -fcompare-debug failure (length) with -fpartial-inlining -flto -fconserve-stack

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47106

--- Comment #9 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2011-02-02 06:18:07 UTC ---
Author: aoliva
Date: Wed Feb  2 06:18:01 2011
New Revision: 169515

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=169515
Log:
PR debug/47106
PR debug/47402
* tree-flow-inline.h (clear_is_used, is_used_p): New.
* cfgexpand.c (account_used_vars_for_block): Use them.
* tree-nrv.c (tree_nrv): Likewise.
* tree-ssa-live.c (remove_unused_scope_block_p): Likewise.
(dump_scope_block): Likewise.
(remove_unused_locals): Likewise.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cfgexpand.c
    trunk/gcc/tree-flow-inline.h
    trunk/gcc/tree-nrv.c
    trunk/gcc/tree-ssa-live.c

[Bug debug/47106] -fcompare-debug failure (length) with -fpartial-inlining -flto -fconserve-stack

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47106

--- Comment #10 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2011-02-02 06:28:26 UTC ---
Author: aoliva
Date: Wed Feb  2 06:28:22 2011
New Revision: 169516

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=169516
Log:
PR debug/47106
PR debug/47402
* tree-inline.c (declare_return_variable): Remove unused caller
variable.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-inline.c

[Bug debug/47106] -fcompare-debug failure (length) with -fpartial-inlining -flto -fconserve-stack

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47106

--- Comment #11 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2011-02-15 18:36:23 UTC ---
Author: aoliva
Date: Tue Feb 15 18:36:16 2011
New Revision: 170185

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170185
Log:
PR debug/47106
PR debug/47402
* tree-flow.h (referenced_var_lookup): Add fn parameter.
Adjust all callers.
* tree-dfa.c (referenced_var_lookup): Use fn instead of cfun.
* tree-flow-inline.h: Adjust.
* gimple-pretty-print.c: Adjust.
* tree-into-ssa.c: Adjust.
* tree-ssa.c: Adjust.
* cfgexpand.c: Adjust.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cfgexpand.c
    trunk/gcc/gimple-pretty-print.c
    trunk/gcc/tree-dfa.c
    trunk/gcc/tree-flow-inline.h
    trunk/gcc/tree-flow.h
    trunk/gcc/tree-into-ssa.c
    trunk/gcc/tree-ssa.c

[Bug debug/47106] -fcompare-debug failure (length) with -fpartial-inlining -flto -fconserve-stack

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47106

--- Comment #12 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2011-02-15 18:36:34 UTC ---
Author: aoliva
Date: Tue Feb 15 18:36:31 2011
New Revision: 170186

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170186
Log:
PR debug/47106
PR debug/47402
* tree-flow.h (FOR_EACH_REFERENCED_VAR): Add FN argument.
Adjust all users.  Pass FN to...
* tree-flow-inline.h (first_referenced_var): ... this.  Add
fn argument.
* ipa-struct-reorg.c: Adjust.
* tree-dfa.c: Adjust.
* tree-into-ssa.c: Adjust.
* tree-sra.c: Adjust.
* tree-ssa-alias.c: Adjust.
* tree-ssa-live.c: Adjust.
* tree-ssa.c: Adjust.
* tree-ssanames.c: Adjust.
* tree-tailcall.c: Adjust.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa-struct-reorg.c
    trunk/gcc/tree-dfa.c
    trunk/gcc/tree-flow-inline.h
    trunk/gcc/tree-flow.h
    trunk/gcc/tree-into-ssa.c
    trunk/gcc/tree-sra.c
    trunk/gcc/tree-ssa-alias.c
    trunk/gcc/tree-ssa-live.c
    trunk/gcc/tree-ssa.c
    trunk/gcc/tree-ssanames.c
    trunk/gcc/tree-tailcall.c

[Bug debug/47106] -fcompare-debug failure (length) with -fpartial-inlining -flto -fconserve-stack

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47106

--- Comment #13 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2011-02-15 18:36:48 UTC ---
Author: aoliva
Date: Tue Feb 15 18:36:44 2011
New Revision: 170187

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170187
Log:
PR debug/47106
PR debug/47402
* tree-inline.h (estimated_stack_frame_size): Take cgraph node
rather than decl.
* cfgexpand.c (estimated_stack_frame_size): Likewise.
* ipa-inline.c (compute_inline_parameters): Adjust.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cfgexpand.c
    trunk/gcc/ipa-inline.c
    trunk/gcc/tree-inline.h

[Bug debug/47106] -fcompare-debug failure (length) with -fpartial-inlining -flto -fconserve-stack

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47106

--- Comment #14 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2011-02-15 18:37:01 UTC ---
Author: aoliva
Date: Tue Feb 15 18:36:56 2011
New Revision: 170188

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170188
Log:
PR debug/47106
PR debug/47402
* cgraph.h (compute_inline_parameters): Return void.
* ipa-inline.c (compute_inline_parameters): Adjust.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cgraph.h
    trunk/gcc/ipa-inline.c

[Bug debug/47106] -fcompare-debug failure (length) with -fpartial-inlining -flto -fconserve-stack

[hubicka at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47106

--- Comment #15 from Jan Hubicka <hubicka at gcc dot gnu.org> 2011-02-17 16:18:34 UTC ---
Author: hubicka
Date: Thu Feb 17 16:18:24 2011
New Revision: 170249

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170249
Log:

    PR debug/47106
    PR debug/47402
    * cfgexpand.c (account_used_vars_for_block): Remove.
    (estimated_stack_frame_size): Use referenced vars.
    * tree-inline.c (remap_decl): Only mark VAR_DECLs as referenced
    that were referenced in the original function.  Test src_fn
    rather than cfun.  Drop redundant get_var_ann.
    (setup_one_parameter): Drop redundant get_var_ann.
    (declare_return_variable): Likewise.
    (copy_decl_for_dup_finish): Mark VAR_DECLs referenced in src_fn.
    (copy_arguments_for_versioning): Drop redundant get_var_ann.
    * ipa-inline.c (compute_inline_parameters): Do not compute
    disregard_inline_limits here.
    are not available.
    (compute_inlinable_for_current, pass_inlinable): New.
    (pass_inline_parameters): Require PROP_referenced_vars.
    * cgraphunit.c (cgraph_process_new_functions): Don't run
    compute_inline_parameters explicitly unless function is in
    SSA form.
    (cgraph_analyze_function): Set .disregard_inline_limits.
    * tree-sra.c (convert_callers): Compute inliner parameters
    only for functions already in SSA form.
    * g++.dg/debug/pr47106.C: New.

Added:
    trunk/gcc/testsuite/g++.dg/debug/pr47106.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/cfgexpand.c
    trunk/gcc/cgraphunit.c
    trunk/gcc/ipa-inline.c
    trunk/gcc/passes.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-inline.c
    trunk/gcc/tree-sra.c

[Bug debug/47106] -fcompare-debug failure (length) with -fpartial-inlining -flto -fconserve-stack

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47106

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danglin at gcc dot gnu.org

--- Comment #16 from John David Anglin <danglin at gcc dot gnu.org> 2011-02-21 13:44:58 UTC ---
Executing on host: /test/gnu/gcc/objdir/gcc/testsuite/g++/../../g++
-B/test/gnu/
gcc/objdir/gcc/testsuite/g++/../../
/test/gnu/gcc/gcc/gcc/testsuite/g++.dg/debug
/pr47106.C  -nostdinc++
-I/test/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/libstdc++-v
3/include/hppa2.0w-hp-hpux11.11
-I/test/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/lib
stdc++-v3/include -I/test/gnu/gcc/gcc/libstdc++-v3/libsupc++
-I/test/gnu/gcc/gcc
/libstdc++-v3/include/backward -I/test/gnu/gcc/gcc/libstdc++-v3/testsuite/util
-
fmessage-length=0 -gstabs1 -O -fpartial-inlining -flto -fconserve-stack
-fcompar
e-debug  -S  -o pr47106.s    (timeout = 300)
cc1plus: error: LTO support has not been enabled in this configuration
compiler exited with status 1
output is:
cc1plus: error: LTO support has not been enabled in this configuration

FAIL: g++.dg/debug/pr47106.C -gstabs1 (test for excess errors)
Excess errors:
cc1plus: error: LTO support has not been enabled in this configuration

[Bug debug/47106] -fcompare-debug failure (length) with -fpartial-inlining -flto -fconserve-stack

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47106

--- Comment #17 from Jakub Jelinek <jakub at gcc dot gnu.org> 2011-02-21 15:53:54 UTC ---
Author: jakub
Date: Mon Feb 21 15:53:49 2011
New Revision: 170366

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170366
Log:
    PR debug/47106
    * g++.dg/debug/pr47106.C: Require effective target lto.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/debug/pr47106.C

[Bug debug/47106] -fcompare-debug failure (length) with -fpartial-inlining -flto -fconserve-stack

[aoliva at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47106

Alexandre Oliva <aoliva at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #18 from Alexandre Oliva <aoliva at gcc dot gnu.org> 2011-02-23 00:37:50 UTC ---
Fixed