[Bug objc/47118] New: ICE on incorrect parameter to @synchronized()

[Bug objc/47118] New: ICE on incorrect parameter to @synchronized()

[nicola at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47118

           Summary: ICE on incorrect parameter to @synchronized()
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: objc
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: nicola@gcc.gnu.org


Here is a testcase that crashes GCC 4.6 --

typedef struct { float x; float y; } point;

int test (id object)
{
  point x;
  @synchronized (x)
    {
      return 1;
    }
}

The compiler is not checking the type of the argument of @synchronized() and is
not dealing with unexpected types correctly.

Thanks

[Bug objc/47118] ICE on incorrect parameter to @synchronized()

[nicola at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47118

Nicola Pero <nicola at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2010.12.29 15:21:12
     Ever Confirmed|0                           |1

--- Comment #1 from Nicola Pero <nicola at gcc dot gnu.org> 2010-12-29 15:21:12 UTC ---
Confirmed on trunk, 29 December 2010.

Thanks

[Bug objc/47118] ICE on incorrect parameter to @synchronized()

[nicola at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47118

--- Comment #2 from Nicola Pero <nicola at gcc dot gnu.org> 2010-12-29 21:52:03 UTC ---
Author: nicola
Date: Wed Dec 29 21:52:00 2010
New Revision: 168326

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=168326
Log:
In gcc/objc/:
2010-12-29  Nicola Pero  <nicola.pero@meta-innovation.com>

    PR objc/47118
    * objc-act.c (objc_build_synchronized): Check the argument of
    @synchronized and emit an appropriate error if it is not a valid
    Objective-C object.  Deal gracefully with that case.  Updated
    comments and variable names.

In gcc/testsuite/:
2010-12-29  Nicola Pero  <nicola.pero@meta-innovation.com>

    PR objc/47118
    * objc.dg/sync-3.m: New.
    * obj-c++.dg/sync-3.mm: New.


Added:
    trunk/gcc/testsuite/obj-c++.dg/sync-3.mm
    trunk/gcc/testsuite/objc.dg/sync-3.m
Modified:
    trunk/gcc/objc/ChangeLog
    trunk/gcc/objc/objc-act.c
    trunk/gcc/testsuite/ChangeLog

[Bug objc/47118] ICE on incorrect parameter to @synchronized()

[nicola at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47118

Nicola Pero <nicola at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Known to work|                            |4.6.0
         Resolution|                            |FIXED
   Target Milestone|---                         |4.6.0

--- Comment #3 from Nicola Pero <nicola at gcc dot gnu.org> 2010-12-30 22:07:26 UTC ---
Fixed in trunk.

Thanks