[Bug c/47142] New: incorrect libgcc_s_sjlj-1.dll install

[Bug c/47142] New: incorrect libgcc_s_sjlj-1.dll install

[dongsheng.song at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47142

           Summary: incorrect libgcc_s_sjlj-1.dll install
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: dongsheng.song@gmail.com


When I cross build i686-w64-mingw32 target with multilib support on
i686-pc-linux (Debian 6.0), libgcc_s_sjlj-1.dll not install correctly:

gcc-4.6-w32_i686-linux$ find . -name *.dll
./bin/64/pthreadGC2.dll
./bin/pthreadGC2.dll
./bin/libgcc_s_sjlj-1.dll
./i686-w64-mingw32/lib/libgfortran-3.dll
./i686-w64-mingw32/lib/libquadmath-0.dll
./i686-w64-mingw32/lib/libobjc-3.dll
./i686-w64-mingw32/lib/libgomp-1.dll
./i686-w64-mingw32/lib/libssp-0.dll
./i686-w64-mingw32/lib/libstdc++-6.dll
./i686-w64-mingw32/lib64/libgfortran-3.dll
./i686-w64-mingw32/lib64/libquadmath-0.dll
./i686-w64-mingw32/lib64/libobjc-3.dll
./i686-w64-mingw32/lib64/libgomp-1.dll
./i686-w64-mingw32/lib64/libssp-0.dll
./i686-w64-mingw32/lib64/libstdc++-6.dll

$ file bin/libgcc_s_sjlj-1.dll
bin/libgcc_s_sjlj-1.dll: PE32+ executable for MS Windows (DLL) (console)
Mono/.Net assembly

So no 32-bit version installed, not 64 bit version installed incorrectly.
But the building result is correct:

$ find . -name *.dll
./i686-w64-mingw32/64/libgomp/.libs/libgomp-1.dll
./i686-w64-mingw32/64/libgfortran/.libs/libgfortran-3.dll
./i686-w64-mingw32/64/libobjc/.libs/libobjc-3.dll
./i686-w64-mingw32/64/libstdc++-v3/src/.libs/libstdc++-6.dll
./i686-w64-mingw32/64/libquadmath/.libs/libquadmath-0.dll
./i686-w64-mingw32/64/libgcc/64/shlib/libgcc_s_sjlj-1.dll
./i686-w64-mingw32/64/libssp/.libs/libssp-0.dll
./i686-w64-mingw32/libgomp/.libs/libgomp-1.dll
./i686-w64-mingw32/libgfortran/.libs/libgfortran-3.dll
./i686-w64-mingw32/libobjc/.libs/libobjc-3.dll
./i686-w64-mingw32/libstdc++-v3/src/.libs/libstdc++-6.dll
./i686-w64-mingw32/libquadmath/.libs/libquadmath-0.dll
./i686-w64-mingw32/libgcc/shlib/libgcc_s_sjlj-1.dll
./i686-w64-mingw32/libssp/.libs/libssp-0.dll

[Bug target/47142] incorrect libgcc_s_sjlj-1.dll install

[ktietz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47142

Kai Tietz <ktietz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2011.02.03 18:00:56
                 CC|                            |ktietz at gcc dot gnu.org
     Ever Confirmed|0                           |1

--- Comment #1 from Kai Tietz <ktietz at gcc dot gnu.org> 2011-02-03 18:00:56 UTC ---
Hmm, this issue seems to be fixed already. At least for my installation
libgcc_s DLL is put into corresponding lib-folder, too.

Could you please retest?

Thanks,
Kai

[Bug target/47142] incorrect libgcc_s_sjlj-1.dll install

[dongsheng.song at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47142

--- Comment #2 from Dongsheng Song <dongsheng.song at gmail dot com> 2011-02-04 00:09:50 UTC ---
(In reply to comment #1)
> Hmm, this issue seems to be fixed already. At least for my installation
> libgcc_s DLL is put into corresponding lib-folder, too.
> 
> Could you please retest?
> 
> Thanks,
> Kai

Yes, are you mean the cross building configured with:
--build=i686-pc-linux-gnu --host=i686-pc-linux-gnu --target=i686-w64-mingw32
--enable-targets=all --enable-languages=c,c++,fortran,objc,obj-c++

But when I build native compiler with the generated compiler:
--build=i686-pc-linux-gnu --host=i686-w64-mingw32 --target=i686-w64-mingw32
--enable-targets=all --enable-languages=c,c++,fortran,objc,obj-c++

Some DLLs still not installed correctly.

PS: Could you build gcc 4.6 with LTO enabled?
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47528

[Bug target/47142] incorrect libgcc_s_sjlj-1.dll install

[dongsheng.song at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47142

--- Comment #3 from Dongsheng Song <dongsheng.song at gmail dot com> 2011-02-04 01:33:55 UTC ---
(In reply to comment #2)
> (In reply to comment #1)
> > Hmm, this issue seems to be fixed already. At least for my installation
> > libgcc_s DLL is put into corresponding lib-folder, too.
> > 
> > Could you please retest?
> > 
> > Thanks,
> > Kai
> 
> Yes, are you mean the cross building configured with:
> --build=i686-pc-linux-gnu --host=i686-pc-linux-gnu --target=i686-w64-mingw32
> --enable-targets=all --enable-languages=c,c++,fortran,objc,obj-c++
> 
> But when I build native compiler with the generated compiler:
> --build=i686-pc-linux-gnu --host=i686-w64-mingw32 --target=i686-w64-mingw32
> --enable-targets=all --enable-languages=c,c++,fortran,objc,obj-c++
> 
> Some DLLs still not installed correctly.

Here is the result:

oracle@vc:~/gcc-4.6-windows$ find . -name *.dll | sort
./bin/64/pthreadGC2.dll
./bin/libgcc_s_sjlj-1.dll
./bin/libgfortran-3.dll
./bin/libgomp-1.dll
./bin/libobjc-3.dll
./bin/libquadmath-0.dll
./bin/libssp-0.dll
./bin/libstdc++-6.dll
./bin/pthreadGC2.dll

oracle@vc:~/gcc-4.6-windows$ file bin/*.dll
bin/libgcc_s_sjlj-1.dll: PE32+ executable for MS Windows (DLL) (console)
Mono/.Net assembly
bin/libgfortran-3.dll:   PE32 executable for MS Windows (DLL) (console) Intel
80386 32-bit
bin/libgomp-1.dll:       PE32 executable for MS Windows (DLL) (console) Intel
80386 32-bit
bin/libobjc-3.dll:       PE32+ executable for MS Windows (DLL) (console)
Mono/.Net assembly
bin/libquadmath-0.dll:   PE32 executable for MS Windows (DLL) (console) Intel
80386 32-bit
bin/libssp-0.dll:        PE32 executable for MS Windows (DLL) (console) Intel
80386 32-bit
bin/libstdc++-6.dll:     PE32+ executable for MS Windows (DLL) (console)
Mono/.Net assembly
bin/pthreadGC2.dll:      PE32 executable for MS Windows (DLL) (console) Intel
80386 32-bit

[Bug target/47142] incorrect libgcc_s_sjlj-1.dll install

[ktietz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47142

--- Comment #4 from Kai Tietz <ktietz at gcc dot gnu.org> 2011-02-04 09:33:58 UTC ---
Could you please check if this patch solves the issue for multilib? (It treats
multilib scenario like cross for installation of dll files).

Index: config.gcc
===================================================================
--- config.gcc  (revision 169824)
+++ config.gcc  (working copy)
@@ -1489,7 +1489,19 @@
        fi
        # Shared libgcc DLL install dir depends on cross/native build.
        if test x${host} = x${target} ; then
-               tmake_dlldir_file="i386/t-dlldir"
+               # Are we building multilib version?
+               if test x$enable_targets = xall; then
+                       case ${target} in
+                       *-w64-*)
+                               tmake_dlldir_file="i386/t-dlldir-x"
+                               ;;
+                       *)
+                               tmake_dlldir_file="i386/t-dlldir"
+                               ;;
+                       esac
+               else
+                       tmake_dlldir_file="i386/t-dlldir"
+               fi
        else
                tmake_dlldir_file="i386/t-dlldir-x"
        fi

[Bug target/47142] incorrect libgcc_s_sjlj-1.dll install

[dongsheng.song at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47142

--- Comment #5 from Dongsheng Song <dongsheng.song at gmail dot com> 2011-02-04 13:29:09 UTC ---
(In reply to comment #4)
> Could you please check if this patch solves the issue for multilib? (It treats
> multilib scenario like cross for installation of dll files).
> 
> Index: config.gcc
> ===================================================================
> --- config.gcc  (revision 169824)
> +++ config.gcc  (working copy)
> @@ -1489,7 +1489,19 @@
>         fi
>         # Shared libgcc DLL install dir depends on cross/native build.
>         if test x${host} = x${target} ; then
> -               tmake_dlldir_file="i386/t-dlldir"
> +               # Are we building multilib version?
> +               if test x$enable_targets = xall; then
> +                       case ${target} in
> +                       *-w64-*)
> +                               tmake_dlldir_file="i386/t-dlldir-x"
> +                               ;;
> +                       *)
> +                               tmake_dlldir_file="i386/t-dlldir"
> +                               ;;
> +                       esac
> +               else
> +                       tmake_dlldir_file="i386/t-dlldir"
> +               fi
>         else
>                 tmake_dlldir_file="i386/t-dlldir-x"
>         fi

Since the cross compiler building is OK, so I only tried the native compiler
building. I got the same wrong results.

My next complete building will be started at 23:50 PM(UTC), if I got different
answer, I will inform you.

[Bug target/47142] incorrect libgcc_s_sjlj-1.dll install

[dongsheng.song at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47142

--- Comment #6 from Dongsheng Song <dongsheng.song at gmail dot com> 2011-02-04 14:26:44 UTC ---
(In reply to comment #5)
> My next complete building will be started at 23:50 PM(UTC), if I got different
> answer, I will inform you.

OOPS, libgcc_s_sjlj-1.dll installed OK. But the other files installation is
wrong. 

oracle@vc:~/gcc-4.6-windows$ find . -name *.dll | grep -v pthread | sort
./bin/libgfortran-3.dll
./bin/libgomp-1.dll
./bin/libobjc-3.dll
./bin/libquadmath-0.dll
./bin/libssp-0.dll
./bin/libstdc++-6.dll
./lib64/libgcc_s_sjlj-1.dll
./lib/libgcc_s_sjlj-1.dll

PS: For windows users, I think 32bit DLLs should go to bin/, and 64bit DLLs
should
go to bin/64/ .

[Bug target/47142] incorrect libgcc_s_sjlj-1.dll install

[ktietz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47142

--- Comment #7 from Kai Tietz <ktietz at gcc dot gnu.org> 2011-02-04 15:54:10 UTC ---
(In reply to comment #6)
> (In reply to comment #5)
> > My next complete building will be started at 23:50 PM(UTC), if I got different
> > answer, I will inform you.
> 
> OOPS, libgcc_s_sjlj-1.dll installed OK. But the other files installation is
> wrong. 
> 
> oracle@vc:~/gcc-4.6-windows$ find . -name *.dll | grep -v pthread | sort
> ./bin/libgfortran-3.dll
> ./bin/libgomp-1.dll
> ./bin/libobjc-3.dll
> ./bin/libquadmath-0.dll
> ./bin/libssp-0.dll
> ./bin/libstdc++-6.dll
> ./lib64/libgcc_s_sjlj-1.dll
> ./lib/libgcc_s_sjlj-1.dll

Hmm, did you rebuild target libraries, or did you reused existing build-tree?

> PS: For windows users, I think 32bit DLLs should go to bin/, and 64bit DLLs
> should
> go to bin/64/ .

No. As agreement it is ok to install for a none-multilib native build the host
DLLs into bin. But for multilib it should go into lib. I dislike the feature of
installing host DLLs into bin folder pretty much.

[Bug target/47142] incorrect libgcc_s_sjlj-1.dll install

[dongsheng.song at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47142

--- Comment #8 from Dongsheng Song <dongsheng.song at gmail dot com> 2011-02-04 16:05:13 UTC ---
On Fri, Feb 4, 2011 at 23:54, ktietz at gcc dot gnu.org
<gcc-bugzilla@gcc.gnu.org> wrote:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47142
>
> --- Comment #7 from Kai Tietz <ktietz at gcc dot gnu.org> 2011-02-04 15:54:10 UTC ---
>> OOPS, libgcc_s_sjlj-1.dll installed OK. But the other files installation is
>> wrong.
>>
>> oracle@vc:~/gcc-4.6-windows$ find . -name *.dll | grep -v pthread | sort
>> ./bin/libgfortran-3.dll
>> ./bin/libgomp-1.dll
>> ./bin/libobjc-3.dll
>> ./bin/libquadmath-0.dll
>> ./bin/libssp-0.dll
>> ./bin/libstdc++-6.dll
>> ./lib64/libgcc_s_sjlj-1.dll
>> ./lib/libgcc_s_sjlj-1.dll
>
> Hmm, did you rebuild target libraries, or did you reused existing build-tree?
>

I rebuild gcc-4.6-windows, remove gcc build-tree, then configure and building.

PS: I preform the rebuilding ahead of time, remove the cross compiler,
third-party software, and native compiler,
a really fresh building, no good news.