[Bug ada/47163] New: Failure building target-libada for MingW64

[Bug ada/47163] New: Failure building target-libada for MingW64

[vityan at vityan dot sytes.net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47163

           Summary: Failure building target-libada for MingW64
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ada
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: vityan@vityan.sytes.net
              Host: x86_64-w64-mingw32
            Target: x86_64-w64-mingw32,i686-w64-mingw32
             Build: i686-pc-mingw32(msys)


Created attachment 22892
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22892
libada patch for MingW64 target

libada fails to build for MingW64 target.

I gonna touch 4 issues in this report.

1) Ada doesn't include winsock2.h leaving MSG_WAITALL undefined.
Affected file: gcc/ada/s-oscons-tmplt.c
2) PERSONALITY_FUNCTION doesnt have declaration(Cosmetic improvement -
Predeclaration exists for PERSONALITY functions of libgcc and libstdc++).
Affected file: gcc/ada/raise-gcc.c
3) Linked PE+(X64) static libada.a is not functional then exceptions are
needed(Undefined GNAT PERSONALITY symbol) due to incorrect exception handling
mechanism selected for x86_64-w64-mingw32 target.
Affected file: gcc/ada/gcc-interface/Makefile.in
4) Failure to link shared libada.dll for alternative target in multilib
configuration because arch-flag(-m32/-m64) is not passed to the linker(But
passed to compiler while building object files)
Affected file: gcc/ada/gcc-interface/Makefile.in


My patch to those 4 issues is attached.

[Bug ada/47163] Failure building target-libada for MingW64

[vityan at vityan dot sytes.net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47163

--- Comment #1 from Victor K. <vityan at vityan dot sytes.net> 2011-01-04 05:17:03 UTC ---
Forgot to mention about 5-th issue:
Failure to copy adainclude/adalib libraries in MSYS.
Caused by LN_S set to cp -p for MSYS and this command is not suitable to copy
folder to folder(only suitable for files).
To copy folders cp-pr should be used and this is fixed too in the attached
patch.
Affected file: gcc/ada/gcc-interface/Makefile.in

[Bug ada/47163] Failure building target-libada for MingW64

[laurent at guerby dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47163

Laurent GUERBY <laurent at guerby dot net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |charlet at gcc dot gnu.org,
                   |                            |laurent at guerby dot net

--- Comment #2 from Laurent GUERBY <laurent at guerby dot net> 2011-01-04 07:05:37 UTC ---
Add Ada maintainer in CC.

[Bug ada/47163] Failure building target-libada for MingW64

[ktietz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47163

--- Comment #3 from Kai Tietz <ktietz at gcc dot gnu.org> 2011-04-04 07:31:16 UTC ---
Author: ktietz
Date: Mon Apr  4 07:31:11 2011
New Revision: 171926

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=171926
Log:
2011-04-04  Kai Tietz  <ktietz@redhat.com>

        PR ada/47163
        * s-oscons-tmplt.c (MSG_WAITALL): Define it for native windows
        targets to flag value.


Modified:
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/s-oscons-tmplt.c

[Bug ada/47163] Failure building target-libada for MingW64

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47163

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011.04.04 07:53:22
                 CC|                            |ebotcazou at gcc dot
                   |                            |gnu.org
     Ever Confirmed|0                           |1

--- Comment #4 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2011-04-04 07:53:22 UTC ---
Feel free to backport all the fixes to the 4.6 branch if you can test them on
the branch too, this is early enough.

[Bug ada/47163] Failure building target-libada for MingW64

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47163

--- Comment #5 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2011-04-04 18:06:58 UTC ---
Author: ebotcazou
Date: Mon Apr  4 18:06:55 2011
New Revision: 171943

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=171943
Log:
    PR ada/47163
    * s-oscons-tmplt.c (MSG_WAITALL): Fix thinko in previous change.

Modified:
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/s-oscons-tmplt.c

[Bug ada/47163] Failure building target-libada for MingW64

[ktietz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47163

Kai Tietz <ktietz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |ktietz at gcc dot gnu.org
         Resolution|---                         |FIXED

--- Comment #6 from Kai Tietz <ktietz at gcc dot gnu.org> ---
The remaining issue about LN -s is also mentioned in PR/52122 report.  So I
close this bug as fixed.