From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2644 invoked by alias); 10 Jan 2011 20:56:38 -0000 Received: (qmail 2632 invoked by uid 22791); 10 Jan 2011 20:56:37 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from localhost (HELO gcc.gnu.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Jan 2011 20:56:33 +0000 From: "hubicka at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug lto/47247] Linker plugin specification makes it difficult to handle COMDATs X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: lto X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: hubicka at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Mon, 10 Jan 2011 21:27:00 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2011-01/txt/msg00965.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47247 --- Comment #10 from Jan Hubicka 2011-01-10 20:56:23 UTC --- > What undesirable things may happen if we mark a COMDAT symbol > PREVAILING_DEF? Is that we won't know which one will be used > if both LTO and non-LTO objects define the same COMAT symbol? excatly, we don't know if something else in the same DSO is defining this COMDAT. Also the plugin specs explicitely say that plugin is required to provide this symbol in the output per the paragraph I quoted. Cary: the update seems fine to me. Any chance to get it implemented on plugin side? Adding support in GCC is easy (and we can even keep the current trick of not outputing some COMDATs in place until old linkers gets out of busyness)