[Bug tree-optimization/47278] New: [4.3/4.4/4.5 Regression] hidden weak function not handled properly

[Bug tree-optimization/47278] New: [4.3/4.4/4.5 Regression] hidden weak function not handled properly

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47278

           Summary: [4.3/4.4/4.5 Regression] hidden weak function not
                    handled properly
           Product: gcc
           Version: 4.5.2
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: rguenth@gcc.gnu.org


> cat t1.c
int foo (void) { return 1; }
> cat t2.c
extern void abort (void);

int __attribute__((weak,visibility("hidden"))) foo (void)
{
  return 0;
}

int main()
{
  if (foo() != 1)
    abort ();
  return 0;
}


This worked fine with GCC 4.1 and does work fine with GCC 4.6.

I have a patch for 4.3 for the moment.

[Bug tree-optimization/47278] [4.3/4.4/4.5 Regression] hidden weak function not handled properly

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47278

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |4.1.2, 4.6.0
   Target Milestone|---                         |4.3.6
      Known to fail|                            |4.3.5, 4.5.2

[Bug tree-optimization/47278] [4.3/4.4/4.5 Regression] hidden weak function not handled properly

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47278

--- Comment #1 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-01-13 13:37:55 UTC ---
Created attachment 22959
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=22959
patch for the 4.3 branch

[Bug tree-optimization/47278] [4.3/4.4/4.5 Regression] hidden weak function not handled properly

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47278

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2011.01.13 13:38:38
         AssignedTo|unassigned at gcc dot       |rguenth at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

--- Comment #2 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-01-13 13:38:38 UTC ---
Mine.

The branches differ in substantial ways, so I'll be slowly making my way
backward from trunk.

[Bug tree-optimization/47278] [4.3/4.4/4.5 Regression] hidden weak function not handled properly

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47278

--- Comment #3 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-03-08 13:03:38 UTC ---
Author: rguenth
Date: Tue Mar  8 13:03:34 2011
New Revision: 170775

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170775
Log:
2011-03-08  Richard Guenther  <rguenther@suse.de>

    PR tree-optimization/47278
    * tree.h (DECL_REPLACEABLE_P): Remove.
    (decl_replaceable_p): Declare.
    (decl_binds_to_current_def_p): Likewise.
    * varasm.c (decl_replaceable_p): New function.
    (decl_binds_to_current_def_p): Likewise.
    * cgraph.c (cgraph_function_body_availability): Use decl_replaceable_p.
    * tree-inline.c (inlinable_function_p): Likewise.

    cp/
    * decl.c (finish_function): Use decl_replaceable_p.

    testsuite/
    * gcc.dg/torture/pr47278-1.c: New testcase.
    * gcc.dg/torture/pr47278-2.c: Likewise.

Added:
    branches/gcc-4_5-branch/gcc/testsuite/gcc.dg/torture/pr47278-1.c
    branches/gcc-4_5-branch/gcc/testsuite/gcc.dg/torture/pr47278-2.c
Modified:
    branches/gcc-4_5-branch/gcc/ChangeLog
    branches/gcc-4_5-branch/gcc/cgraph.c
    branches/gcc-4_5-branch/gcc/cp/ChangeLog
    branches/gcc-4_5-branch/gcc/cp/decl.c
    branches/gcc-4_5-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_5-branch/gcc/tree-inline.c
    branches/gcc-4_5-branch/gcc/tree.h
    branches/gcc-4_5-branch/gcc/varasm.c

[Bug tree-optimization/47278] [4.3/4.4 Regression] hidden weak function not handled properly

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47278

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
      Known to work|                            |4.5.3
         AssignedTo|rguenth at gcc dot gnu.org  |unassigned at gcc dot
                   |                            |gnu.org
            Summary|[4.3/4.4/4.5 Regression]    |[4.3/4.4 Regression] hidden
                   |hidden weak function not    |weak function not handled
                   |handled properly            |properly

--- Comment #4 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-03-08 13:05:18 UTC ---
Fixed for 4.5.3.

[Bug tree-optimization/47278] [4.3/4.4 Regression] hidden weak function not handled properly

[danglin at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47278

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danglin at gcc dot gnu.org

--- Comment #5 from John David Anglin <danglin at gcc dot gnu.org> 2011-03-10 17:26:49 UTC ---
I see on 4.5.3 on hppa2.0w-hp-hpux11.11:

FAIL: gcc.dg/torture/pr47278-1.c  -O0  (test for excess errors)
Excess errors:
/mnt/gnu/gcc/gcc/gcc/testsuite/gcc.dg/torture/pr47278-2.c:6:1: warning:
visibili
ty attribute not supported in this configuration; ignored

[Bug tree-optimization/47278] [4.3/4.4 Regression] hidden weak function not handled properly

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47278

--- Comment #6 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-03-11 10:43:35 UTC ---
Author: rguenth
Date: Fri Mar 11 10:43:31 2011
New Revision: 170868

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170868
Log:
2011-03-11  Richard Guenther  <rguenther@suse.de>

    PR tree-optimization/47278
    * gcc.dg/torture/pr47278-1.c: Require visibility support.
    * gcc.dg/torture/pr47278-2.c: Likewise.

Modified:
    branches/gcc-4_5-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_5-branch/gcc/testsuite/gcc.dg/torture/pr47278-1.c
    branches/gcc-4_5-branch/gcc/testsuite/gcc.dg/torture/pr47278-2.c

[Bug tree-optimization/47278] [4.3/4.4 Regression] hidden weak function not handled properly

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47278

--- Comment #7 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-03-11 10:45:59 UTC ---
Author: rguenth
Date: Fri Mar 11 10:45:54 2011
New Revision: 170869

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=170869
Log:
2011-03-11  Richard Guenther  <rguenther@suse.de>

    PR tree-optimization/47278
    * gcc.dg/torture/pr47278-1.c: New testcase.
    * gcc.dg/torture/pr47278-2.c: Likewise.

Added:
    trunk/gcc/testsuite/gcc.dg/torture/pr47278-1.c
    trunk/gcc/testsuite/gcc.dg/torture/pr47278-2.c
Modified:
    trunk/gcc/testsuite/ChangeLog

[Bug tree-optimization/47278] [4.3/4.4 Regression] hidden weak function not handled properly

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47278

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

[Bug tree-optimization/47278] [4.3/4.4 Regression] hidden weak function not handled properly

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47278

Richard Guenther <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.3.6                       |4.4.7

--- Comment #8 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-06-27 12:12:36 UTC ---
4.3 branch is being closed, moving to 4.4.7 target.

[Bug tree-optimization/47278] [4.4 Regression] hidden weak function not handled properly

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47278

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |jakub at gcc dot gnu.org
         Resolution|                            |FIXED
   Target Milestone|4.4.7                       |4.5.3

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-03-13 13:24:21 UTC ---
Fixed in 4.5+, 4.4 is no longer supported.