public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug gcov-profile/47363] New: value-profile.c produces incorrect error message when *count > *all
@ 2011-01-19 20:10 asharif at gcc dot gnu.org
2011-01-20 11:53 ` [Bug gcov-profile/47363] " rguenth at gcc dot gnu.org
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: asharif at gcc dot gnu.org @ 2011-01-19 20:10 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47363
Summary: value-profile.c produces incorrect error message when
*count > *all
Product: gcc
Version: unknown
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: gcov-profile
AssignedTo: unassigned@gcc.gnu.org
ReportedBy: asharif@gcc.gnu.org
Created attachment 23032
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23032
Patch that adds a helpful error message when the profile is corrupted.
When a profile is corrupted and *count > *all (in value-prof.c) around line
473, an incorrect message is generated. This message reads:
profiler overall count (%d) does not match BB count (%d)
The integers in parentheses are actually equal so the message is confusing to
the user.
There should be a better error message generated in this case, pointing the
user to what went wrong.
I am attaching a patch that fixes this (I'll also be sending out an email to
the mailing list).
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug gcov-profile/47363] value-profile.c produces incorrect error message when *count > *all
2011-01-19 20:10 [Bug gcov-profile/47363] New: value-profile.c produces incorrect error message when *count > *all asharif at gcc dot gnu.org
@ 2011-01-20 11:53 ` rguenth at gcc dot gnu.org
2011-01-24 21:22 ` asharif at gcc dot gnu.org
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: rguenth at gcc dot gnu.org @ 2011-01-20 11:53 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47363
Richard Guenther <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2011.01.20 10:53:27
Ever Confirmed|0 |1
--- Comment #1 from Richard Guenther <rguenth at gcc dot gnu.org> 2011-01-20 10:53:27 UTC ---
A more reasonable error would be
profile counter (%d out of %d) inconsistent with basic-block count (%d)
and print *count, *all, bb_count.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug gcov-profile/47363] value-profile.c produces incorrect error message when *count > *all
2011-01-19 20:10 [Bug gcov-profile/47363] New: value-profile.c produces incorrect error message when *count > *all asharif at gcc dot gnu.org
2011-01-20 11:53 ` [Bug gcov-profile/47363] " rguenth at gcc dot gnu.org
@ 2011-01-24 21:22 ` asharif at gcc dot gnu.org
2011-01-24 21:38 ` asharif at gcc dot gnu.org
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: asharif at gcc dot gnu.org @ 2011-01-24 21:22 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47363
asharif at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23032|0 |1
is obsolete| |
--- Comment #2 from asharif at gcc dot gnu.org 2011-01-24 21:09:47 UTC ---
Created attachment 23109
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23109
Patch to fix this problem.
The patch now has a more appropriate error message.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug gcov-profile/47363] value-profile.c produces incorrect error message when *count > *all
2011-01-19 20:10 [Bug gcov-profile/47363] New: value-profile.c produces incorrect error message when *count > *all asharif at gcc dot gnu.org
2011-01-20 11:53 ` [Bug gcov-profile/47363] " rguenth at gcc dot gnu.org
2011-01-24 21:22 ` asharif at gcc dot gnu.org
@ 2011-01-24 21:38 ` asharif at gcc dot gnu.org
2011-01-24 21:41 ` asharif at gcc dot gnu.org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: asharif at gcc dot gnu.org @ 2011-01-24 21:38 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47363
asharif at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23109|0 |1
is obsolete| |
--- Comment #3 from asharif at gcc dot gnu.org 2011-01-24 21:22:33 UTC ---
Created attachment 23111
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23111
I forgot a space earlier. It is fixed in this version now.
Updated patch.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug gcov-profile/47363] value-profile.c produces incorrect error message when *count > *all
2011-01-19 20:10 [Bug gcov-profile/47363] New: value-profile.c produces incorrect error message when *count > *all asharif at gcc dot gnu.org
` (2 preceding siblings ...)
2011-01-24 21:38 ` asharif at gcc dot gnu.org
@ 2011-01-24 21:41 ` asharif at gcc dot gnu.org
2011-01-24 22:21 ` asharif at gcc dot gnu.org
2011-02-03 22:22 ` asharif at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: asharif at gcc dot gnu.org @ 2011-01-24 21:41 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47363
asharif at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23111|0 |1
is obsolete| |
--- Comment #4 from asharif at gcc dot gnu.org 2011-01-24 21:32:29 UTC ---
Created attachment 23112
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23112
The patch now has the original "corrupted value profile: %s" line.
Added original line.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug gcov-profile/47363] value-profile.c produces incorrect error message when *count > *all
2011-01-19 20:10 [Bug gcov-profile/47363] New: value-profile.c produces incorrect error message when *count > *all asharif at gcc dot gnu.org
` (3 preceding siblings ...)
2011-01-24 21:41 ` asharif at gcc dot gnu.org
@ 2011-01-24 22:21 ` asharif at gcc dot gnu.org
2011-02-03 22:22 ` asharif at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: asharif at gcc dot gnu.org @ 2011-01-24 22:21 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47363
asharif at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #23112|0 |1
is obsolete| |
--- Comment #5 from asharif at gcc dot gnu.org 2011-01-24 21:38:50 UTC ---
Created attachment 23113
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23113
Patch to fix this problem.
Fixed indentation.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug gcov-profile/47363] value-profile.c produces incorrect error message when *count > *all
2011-01-19 20:10 [Bug gcov-profile/47363] New: value-profile.c produces incorrect error message when *count > *all asharif at gcc dot gnu.org
` (4 preceding siblings ...)
2011-01-24 22:21 ` asharif at gcc dot gnu.org
@ 2011-02-03 22:22 ` asharif at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: asharif at gcc dot gnu.org @ 2011-02-03 22:22 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47363
asharif at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #6 from asharif at gcc dot gnu.org 2011-02-03 22:22:31 UTC ---
Fixed in r169387.
http://gcc.gnu.org/viewcvs?view=revision&revision=169387
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-02-03 22:22 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-19 20:10 [Bug gcov-profile/47363] New: value-profile.c produces incorrect error message when *count > *all asharif at gcc dot gnu.org
2011-01-20 11:53 ` [Bug gcov-profile/47363] " rguenth at gcc dot gnu.org
2011-01-24 21:22 ` asharif at gcc dot gnu.org
2011-01-24 21:38 ` asharif at gcc dot gnu.org
2011-01-24 21:41 ` asharif at gcc dot gnu.org
2011-01-24 22:21 ` asharif at gcc dot gnu.org
2011-02-03 22:22 ` asharif at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).