From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-344013-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 3003 invoked by alias); 19 Jan 2011 19:39:14 -0000
Received: (qmail 2994 invoked by uid 22791); 19 Jan 2011 19:39:13 -0000
X-SWARE-Spam-Status: No, hits=-2.9 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO gcc.gnu.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 19 Jan 2011 19:39:09 +0000
From: "asharif at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug gcov-profile/47363] New: value-profile.c produces incorrect error message when *count > *all
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: gcov-profile
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: asharif at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields:
Message-ID: <bug-47363-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Date: Wed, 19 Jan 2011 20:10:00 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2011-01/txt/msg01952.txt.bz2

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47363

           Summary: value-profile.c produces incorrect error message when
                    *count > *all
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: gcov-profile
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: asharif@gcc.gnu.org


Created attachment 23032
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23032
Patch that adds a helpful error message when the profile is corrupted.

When a profile is corrupted and *count > *all (in value-prof.c) around line
473, an incorrect message is generated. This message reads:

profiler overall count (%d) does not match BB count (%d)

The integers in parentheses are actually equal so the message is confusing to
the user.

There should be a better error message generated in this case, pointing the
user to what went wrong.

I am attaching a patch that fixes this (I'll also be sending out an email to
the mailing list).