public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "marc.glisse at normalesup dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/47380] concept checking and incomplete types
Date: Tue, 23 Aug 2011 15:37:00 -0000	[thread overview]
Message-ID: <bug-47380-4-TVwj9Kg6fi@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-47380-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47380

--- Comment #11 from Marc Glisse <marc.glisse at normalesup dot org> 2011-08-23 15:27:35 UTC ---
In case someone else has issues with _GLIBCXX_CONCEPT_CHECKS, all the bad cases
I have hit came from _SGIAssignableConcept, so I simply removed the content of
that concept (not very subtle I know...). Afterwards, all the errors given by
the concept checking matched real bugs in our code, and there were quite a few
so the patch didn't completely kill the checking. (Note that this is not a
proposition to change libstdc++, just information for anyone reading this
entry)

--- boost_concept_check.h.orig    2011-01-28 15:01:12.177453226 +0100
+++ boost_concept_check.h    2011-01-28 15:01:29.665445131 +0100
@@ -201,15 +201,9 @@
   struct _SGIAssignableConcept
   {
     void __constraints() {
-      _Tp __b _IsUnused(__a);
-      __a = __a;                        // require assignment operator
-      __const_constraints(__a);
     }
     void __const_constraints(const _Tp& __b) {
-      _Tp __c _IsUnused(__b);
-      __a = __b;              // const required for argument to assignment
     }
-    _Tp __a;
   };

   template <class _From, class _To>


      parent reply	other threads:[~2011-08-23 15:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-20 16:37 [Bug libstdc++/47380] New: " marc.glisse at normalesup dot org
2011-01-20 18:13 ` [Bug libstdc++/47380] " paolo.carlini at oracle dot com
2011-01-20 18:14 ` redi at gcc dot gnu.org
2011-01-20 18:52 ` paolo.carlini at oracle dot com
2011-01-20 20:06 ` marc.glisse at normalesup dot org
2011-01-20 20:16 ` redi at gcc dot gnu.org
2011-01-20 20:18 ` redi at gcc dot gnu.org
2011-01-20 20:42 ` redi at gcc dot gnu.org
2011-01-20 20:44 ` marc.glisse at normalesup dot org
2011-01-20 20:47 ` redi at gcc dot gnu.org
2011-01-21  1:02 ` paolo.carlini at oracle dot com
2011-08-23 15:37 ` marc.glisse at normalesup dot org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-47380-4-TVwj9Kg6fi@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).