From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1145 invoked by alias); 23 Aug 2011 15:27:56 -0000 Received: (qmail 1136 invoked by uid 22791); 23 Aug 2011 15:27:55 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from localhost (HELO gcc.gnu.org) (127.0.0.1) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Aug 2011 15:27:42 +0000 From: "marc.glisse at normalesup dot org" To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/47380] concept checking and incomplete types Date: Tue, 23 Aug 2011 15:37:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: libstdc++ X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: marc.glisse at normalesup dot org X-Bugzilla-Status: RESOLVED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2011-08/txt/msg01924.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47380 --- Comment #11 from Marc Glisse 2011-08-23 15:27:35 UTC --- In case someone else has issues with _GLIBCXX_CONCEPT_CHECKS, all the bad cases I have hit came from _SGIAssignableConcept, so I simply removed the content of that concept (not very subtle I know...). Afterwards, all the errors given by the concept checking matched real bugs in our code, and there were quite a few so the patch didn't completely kill the checking. (Note that this is not a proposition to change libstdc++, just information for anyone reading this entry) --- boost_concept_check.h.orig 2011-01-28 15:01:12.177453226 +0100 +++ boost_concept_check.h 2011-01-28 15:01:29.665445131 +0100 @@ -201,15 +201,9 @@ struct _SGIAssignableConcept { void __constraints() { - _Tp __b _IsUnused(__a); - __a = __a; // require assignment operator - __const_constraints(__a); } void __const_constraints(const _Tp& __b) { - _Tp __c _IsUnused(__b); - __a = __b; // const required for argument to assignment } - _Tp __a; }; template