[Bug target/47381] New: [x32] internal compiler error: in gen_lowpart_general, at rtlhooks.c:59

[Bug target/47381] New: [x32] internal compiler error: in gen_lowpart_general, at rtlhooks.c:59

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47381

           Summary: [x32] internal compiler error: in gen_lowpart_general,
                    at rtlhooks.c:59
           Product: gcc
           Version: 4.6.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hjl.tools@gmail.com


[hjl@gnu-6 ilp32-12]$ cat y.i
typedef unsigned long ulg;
long block_start;
typedef unsigned char uch;
extern uch window[];
 unsigned strstart;
ulg flush_block (char *buf, ulg stored_len, int eof);
ulg deflate()
{
    return flush_block(block_start >= 0L ?
(char*)&window[(unsigned)block_start] : (char*)((void *)0), (long)strstart -
block_start, (1));
}
[hjl@gnu-6 ilp32-12]$ make y.s
/export/build/gnu/gcc-x32/build-x86_64-linux/gcc/xgcc
-B/export/build/gnu/gcc-x32/build-x86_64-linux/gcc/ -S -o y.s -mx32 -O2 -dp 
y.i
y.i: In function ‘deflate’:
y.i:10:1: internal compiler error: in gen_lowpart_general, at rtlhooks.c:59
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
make: *** [y.s] Error 1
[hjl@gnu-6 ilp32-12]$ 


Breakpoint 1, fancy_abort (
    file=0x1245008 "/export/gnu/import/git/gcc-x32/gcc/rtlhooks.c", line=59, 
    function=0x1245040 "gen_lowpart_general")
    at /export/gnu/import/git/gcc-x32/gcc/diagnostic.c:893
893      internal_error ("in %s, at %s:%d", function, trim_filename (file),
line);
(gdb) bt
#0  fancy_abort (
    file=0x1245008 "/export/gnu/import/git/gcc-x32/gcc/rtlhooks.c", line=59, 
    function=0x1245040 "gen_lowpart_general")
    at /export/gnu/import/git/gcc-x32/gcc/diagnostic.c:893
#1  0x000000000097dacb in gen_lowpart_general (mode=DImode, x=0x7ffff1c92e60)
    at /export/gnu/import/git/gcc-x32/gcc/rtlhooks.c:59
#2  0x0000000000eb47b4 in gen_split_2389 (curr_insn=0x7ffff1a98a68, 
    operands=0x18af5a0)
    at /export/gnu/import/git/gcc-x32/gcc/config/i386/i386.md:6092
#3  0x0000000000fdc878 in split_2 (x0=0x7ffff1af6060, insn=0x7ffff1a98a68)
    at /export/gnu/import/git/gcc-x32/gcc/config/i386/i386.md:6089
#4  0x0000000000fee8ec in split_7 (x0=0x7ffff1af6060, insn=0x7ffff1a98a68)
    at /export/gnu/import/git/gcc-x32/gcc/config/i386/i386.md:11194
#5  0x0000000000ff9ef7 in split_insns (x0=0x7ffff1af6060, insn=0x7ffff1a98a68)
    at /export/gnu/import/git/gcc-x32/gcc/config/i386/sse.md:4647
#6  0x00000000006c3db1 in try_split (pat=0x7ffff1af6060, trial=0x7ffff1a98a68, 
    last=1) at /export/gnu/import/git/gcc-x32/gcc/emit-rtl.c:3415
#7  0x000000000092bf18 in split_insn (insn=0x7ffff1a98a68)
    at /export/gnu/import/git/gcc-x32/gcc/recog.c:2781
#8  0x000000000092c2d0 in split_all_insns ()
    at /export/gnu/import/git/gcc-x32/gcc/recog.c:2870
#9  0x000000000092df31 in rest_of_handle_split_after_reload ()
    at /export/gnu/import/git/gcc-x32/gcc/recog.c:3730
---Type <return> to continue, or q <return> to quit---
#10 0x00000000008f98ab in execute_one_pass (pass=0x17b0c00)
    at /export/gnu/import/git/gcc-x32/gcc/passes.c:1561
#11 0x00000000008f9a9a in execute_pass_list (pass=0x17b0c00)
    at /export/gnu/import/git/gcc-x32/gcc/passes.c:1616
#12 0x00000000008f9abb in execute_pass_list (pass=0x17b07a0)
    at /export/gnu/import/git/gcc-x32/gcc/passes.c:1617
#13 0x00000000008f9abb in execute_pass_list (pass=0x17b0740)
    at /export/gnu/import/git/gcc-x32/gcc/passes.c:1617
#14 0x0000000000a82760 in tree_rest_of_compilation (fndecl=0x7ffff1aa7000)
    at /export/gnu/import/git/gcc-x32/gcc/tree-optimize.c:422
#15 0x0000000000d22a89 in cgraph_expand_function (node=0x7ffff1aab000)
    at /export/gnu/import/git/gcc-x32/gcc/cgraphunit.c:1522
#16 0x0000000000d22c48 in cgraph_expand_all_functions ()
    at /export/gnu/import/git/gcc-x32/gcc/cgraphunit.c:1581
#17 0x0000000000d2327d in cgraph_optimize ()
    at /export/gnu/import/git/gcc-x32/gcc/cgraphunit.c:1841
#18 0x0000000000d20db0 in cgraph_finalize_compilation_unit ()
    at /export/gnu/import/git/gcc-x32/gcc/cgraphunit.c:1042
#19 0x00000000004aeb60 in c_write_global_declarations ()
    at /export/gnu/import/git/gcc-x32/gcc/c-decl.c:9843

The problem is

;; Convert lea to the lea pattern to avoid flags dependency.
(define_split
  [(set (match_operand 0 "register_operand" "")
        (plus (match_operand 1 "register_operand" "")
              (match_operand 2 "nonmemory_operand" ""))) 
   (clobber (reg:CC FLAGS_REG))]
  "reload_completed && ix86_lea_for_add_ok (insn, operands)" 
  [(const_int 0)]
{
  rtx pat;
  enum machine_mode mode = GET_MODE (operands[0]);

  /* In -fPIC mode the constructs like (const (unspec [symbol_ref]))
     may confuse gen_lowpart.  */
  if (mode != Pmode)
    {
      operands[1] = gen_lowpart (Pmode, operands[1]);
      operands[2] = gen_lowpart (Pmode, operands[2]);
    }

doesn't support

(gdb) call debug_rtx (curr_insn)
(insn 34 9 35 2 (parallel [
            (set (reg:DI 1 dx [70])
                (zero_extend:DI (plus:SI (reg:SI 0 ax [orig:62 block_start.2 ]
[62])
                        (symbol_ref:SI ("window") [flags 0x40] <var_decl
0x7ffff1aa60a0 window>))))
            (clobber (reg:CC 17 flags))
        ]) y.i:9 255 {*addsi_1_zext}
     (nil))
(gdb)

[Bug target/47381] [x32] internal compiler error: in gen_lowpart_general, at rtlhooks.c:59

[hjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47381

--- Comment #1 from hjl at gcc dot gnu.org <hjl at gcc dot gnu.org> 2011-01-20 17:28:54 UTC ---
Author: hjl
Date: Thu Jan 20 17:28:49 2011
New Revision: 169059

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=169059
Log:
Fix LEA alternative in *add<mode>_1/*addsi_1_zext for x32.

gcc/

2011-01-20  H.J. Lu  <hongjiu.lu@intel.com>

    PR target/47381
    * config/i386/constraints.md (Yl): New.

    * config/i386/i386.md (l): New.
    (*add<mode>_1): Replace <i> with <l>.
    (*addsi_1_zext): Replace "lYe" with "lYl".

gcc/testsuite/

2011-01-20  H.J. Lu  <hongjiu.lu@intel.com>

    PR target/47381
    * gcc.target/i386/pr47381-1.c: New.
    * gcc.target/i386/pr47381-2.c: Likewise.

Added:
    branches/x32/gcc/testsuite/gcc.target/i386/pr47381-1.c
    branches/x32/gcc/testsuite/gcc.target/i386/pr47381-2.c
Modified:
    branches/x32/gcc/ChangeLog.x32
    branches/x32/gcc/config/i386/constraints.md
    branches/x32/gcc/config/i386/i386.md
    branches/x32/gcc/testsuite/ChangeLog.x32

[Bug target/47381] [x32] internal compiler error: in gen_lowpart_general, at rtlhooks.c:59

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47381

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> 2011-01-20 18:59:10 UTC ---
Another crash

[hjl@gnu-6 ilp32-13]$ cat x.i 
struct foo_t {
  int limit;
} foo[3];
void
bar () {
  int i;
  for (i = 0; i < 3; i++) {
    __builtin_memset (&foo[i], 0, sizeof(*foo));
  }
}
[hjl@gnu-6 ilp32-13]$ /export/build/gnu/gcc-x32/build-x86_64-linux/gcc/xgcc
-B/export/build/gnu/gcc-x32/build-x86_64-linux/gcc/ -S -o x.s -mx32 -O2 -dp
-march=atom  x.i
x.i: In function ‘bar’:
x.i:10:1: internal compiler error: in gen_lowpart_general, at rtlhooks.c:59
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
[hjl@gnu-6 ilp32-13]$

[Bug target/47381] [x32] internal compiler error: in gen_lowpart_general, at rtlhooks.c:59

[hjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47381

--- Comment #3 from hjl at gcc dot gnu.org <hjl at gcc dot gnu.org> 2011-01-20 19:06:05 UTC ---
Author: hjl
Date: Thu Jan 20 19:06:03 2011
New Revision: 169062

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=169062
Log:
Use x32_lea_nonmemory_operand on 64bit LEA split.

gcc/

2011-01-20  H.J. Lu  <hongjiu.lu@intel.com>

    PR target/47381
    * config/i386/i386.md (64bit LEA split): Replace nonmemory_operand
    with x32_lea_nonmemory_operand.

gcc/testsuite/

2011-01-20  H.J. Lu  <hongjiu.lu@intel.com>

    PR target/47381
    * gcc.target/i386/pr47381-3.c: New.

Added:
    branches/x32/gcc/testsuite/gcc.target/i386/pr47381-3.c
Modified:
    branches/x32/gcc/ChangeLog.x32
    branches/x32/gcc/config/i386/i386.md
    branches/x32/gcc/testsuite/ChangeLog.x32

[Bug target/47381] [x32] internal compiler error: in gen_lowpart_general, at rtlhooks.c:59

[uros at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47381

--- Comment #4 from uros at gcc dot gnu.org 2011-07-26 12:00:36 UTC ---
Author: uros
Date: Tue Jul 26 12:00:33 2011
New Revision: 176788

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=176788
Log:
    PR target/47381
    PR target/49832
    PR target/49833
    * config/i386/i386.md (i): Change SImode attribute to "e".
    (g): Change SImode attribute to "rme".
    (di): Change SImode attribute to "nF".
    (general_operand): Change SImode attribute to x86_64_general_operand.
    (general_szext_operand): Change SImode attribute to
    x86_64_szext_general_operand.
    (immediate_operand): Change SImode attribute to
    x86_64_immediate_operand.
    (nonmemory_operand): Change SImode attribute to
    x86_64_nonmemory_operand.
    (*movdi_internal_rex64): Remove mode from pic_32bit_operand check.
    (*movsi_internal): Ditto.  Use "e" constraint in alternative 2.
    (*lea_1): Use SWI48 mode iterator.
    (*lea_1_zext): New insn pattern.
    (testsi_ccno_1): Use x86_64_nonmemory_operand predicate for operand 2.
    (*bt<mode>): Ditto.
    (*add<mode>1): Use x86_64_general_operand predicate for operand 2.
    Update operand constraints.
    (addsi_1_zext): Ditto.
    (*add<mode>2): Ditto.
    (*addsi_3_zext): Ditto.
    (*subsi_1_zext): Ditto.
    (*subsi_2_zext): Ditto.
    (*subsi_3_zext): Ditto.
    (*addsi3_carry_zext): Ditto.
    (*<plusminus_insn>si3_zext_cc_overflow): Ditto.
    (*mulsi3_1_zext): Ditto.
    (*andsi_1): Ditto.
    (*andsi_1_zext): Ditto.
    (*andsi_2_zext): Ditto.
    (*<any_or:code>si_1_zext): Ditto.
    (*<any_or:code>si_2_zext): Ditto.
    (*test<mode>_1): Use <general_operand> predicate for operand 1.
    (*and<mode>_2): Ditto.
    (mov<mode>cc): Use  <general_operand> predicate for operands 1 and 2.
    (add->lea splitter): Check operand modes in insn constraint.  Extend
    operands less than SImode wide to SImode.
    (add->lea zext splitter): Do not extend input operands to DImode.
    (*lea_general_1): Handle only QImode and HImode operands.
    (*lea_general_2): Ditto.
    (*lea_general_3): Ditto.
    (*lea_general_1_zext): Remove.
    (*lea_general_2_zext): Ditto.
    (*lea_general_3_zext): Ditto.
    (*lea_general_4): Check operand modes in insn constraint.  Extend
    operands less than SImode wide to SImode.
    (ashift->lea splitter): Ditto.
    * config/i386/i386.c (ix86_print_operand_address): Print address
    registers with 'q' modifier on 64bit targets.
    * config/i386/predicates.md (pic_32bit_opreand): Define as special
    predicate.  Reject non-SI and non-DI modes.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/i386.c
    trunk/gcc/config/i386/i386.md
    trunk/gcc/config/i386/predicates.md

[Bug target/47381] [x32] internal compiler error: in gen_lowpart_general, at rtlhooks.c:59

[ubizjak at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47381

Uros Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |x32
             Status|UNCONFIRMED                 |RESOLVED
                URL|                            |http://gcc.gnu.org/ml/gcc-p
                   |                            |atches/2011-07/msg02249.htm
                   |                            |l
         Resolution|                            |FIXED
   Target Milestone|---                         |4.7.0

--- Comment #5 from Uros Bizjak <ubizjak at gmail dot com> 2011-07-26 12:07:11 UTC ---
Committed to trunk.

[Bug target/47381] [x32] internal compiler error: in gen_lowpart_general, at rtlhooks.c:59

[hjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47381

--- Comment #6 from hjl at gcc dot gnu.org <hjl at gcc dot gnu.org> 2011-07-29 16:00:45 UTC ---
Author: hjl
Date: Fri Jul 29 16:00:41 2011
New Revision: 176932

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=176932
Log:
Rewrite x86 lea support for x32.

2011-07-26  Uros Bizjak  <ubizjak@gmail.com>
       H.J. Lu  <hongjiu.lu@intel.com>

    PR target/47381
    PR target/49832
    PR target/49833
    * config/i386/i386.md (i): Change SImode attribute to "e".
    (g): Change SImode attribute to "rme".
    (di): Change SImode attribute to "nF".
    (general_operand): Change SImode attribute to x86_64_general_operand.
    (general_szext_operand): Change SImode attribute to
    x86_64_szext_general_operand.
    (immediate_operand): Change SImode attribute to
    x86_64_immediate_operand.
    (nonmemory_operand): Change SImode attribute to
    x86_64_nonmemory_operand.
    (*movdi_internal_rex64): Remove mode from pic_32bit_operand check.
    (*movsi_internal): Ditto.  Use "e" constraint in alternative 2.
    (*lea_1): Use SWI48 mode iterator.
    (*lea_1_zext): New insn pattern.
    (testsi_ccno_1): Use x86_64_nonmemory_operand predicate for operand 2.
    (*bt<mode>): Ditto.
    (*add<mode>1): Use x86_64_general_operand predicate for operand 2.
    Update operand constraints.
    (addsi_1_zext): Ditto.
    (*add<mode>2): Ditto.
    (*addsi_3_zext): Ditto.
    (*subsi_1_zext): Ditto.
    (*subsi_2_zext): Ditto.
    (*subsi_3_zext): Ditto.
    (*addsi3_carry_zext): Ditto.
    (*<plusminus_insn>si3_zext_cc_overflow): Ditto.
    (*mulsi3_1_zext): Ditto.
    (*andsi_1): Ditto.
    (*andsi_1_zext): Ditto.
    (*andsi_2_zext): Ditto.
    (*<any_or:code>si_1_zext): Ditto.
    (*<any_or:code>si_2_zext): Ditto.
    (*test<mode>_1): Use <general_operand> predicate for operand 1.
    (*and<mode>_2): Ditto.
    (mov<mode>cc): Use  <general_operand> predicate for operands 1 and 2.
    (add->lea splitter): Check operand modes in insn constraint.  Extend
    operands less than SImode wide to SImode.
    (add->lea zext splitter): Do not extend input operands to DImode.
    (*lea_general_1): Handle only QImode and HImode operands.
    (*lea_general_2): Ditto.
    (*lea_general_3): Ditto.
    (*lea_general_1_zext): Remove.
    (*lea_general_2_zext): Ditto.
    (*lea_general_3_zext): Ditto.
    (*lea_general_4): Check operand modes in insn constraint.  Extend
    operands less than SImode wide to SImode.
    (ashift->lea splitter): Ditto.
    * config/i386/i386.c (ix86_print_operand_address): Print address
    registers with 'q' modifier on 64bit targets.
    * config/i386/predicates.md (pic_32bit_opreand): Define as special
    predicate.  Reject non-SI and non-DI modes.

Modified:
    branches/x32/gcc/ChangeLog.x32
    branches/x32/gcc/config/i386/i386.c
    branches/x32/gcc/config/i386/i386.md
    branches/x32/gcc/config/i386/predicates.md

[Bug target/47381] [x32] internal compiler error: in gen_lowpart_general, at rtlhooks.c:59

[hjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47381

--- Comment #7 from hjl at gcc dot gnu.org <hjl at gcc dot gnu.org> 2011-08-06 14:57:55 UTC ---
Author: hjl
Date: Sat Aug  6 14:57:52 2011
New Revision: 177514

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=177514
Log:
Add testcases for PR 47381.

2011-08-06  H.J. Lu  <hongjiu.lu@intel.com>

    PR target/47381
    * gcc.dg/pr47381-1.c: New.
    * gcc.dg/pr47381-2.c: Likewise.
    * gcc.target/i386/pr47381.c: Likewise.

Added:
    trunk/gcc/testsuite/gcc.dg/pr47381-1.c
    trunk/gcc/testsuite/gcc.dg/pr47381-2.c
    trunk/gcc/testsuite/gcc.target/i386/pr47381.c
Modified:
    trunk/gcc/testsuite/ChangeLog