[Bug libstdc++/47387] New: AIX ctype 'mask' override not working

[Bug libstdc++/47387] New: AIX ctype 'mask' override not working

[greed at pobox dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47387

           Summary: AIX ctype 'mask' override not working
           Product: gcc
           Version: 4.5.2
            Status: UNCONFIRMED
          Severity: minor
          Priority: P3
         Component: libstdc++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: greed@pobox.com


Created attachment 23053
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=23053
Use _M_table if not NULL

On AIX, the test '22_locale/ctype/is/char/3.cc' fails:

Assertion failed: __EX, file 
/local/buildarea/grahamr/aix-ppc-5.3/gcc-4.5.2-lit
e-c++/libstdc++-v3/testsuite/22_locale/ctype/is/char/3.cc, line 39

This is because "libstdc++-v3/config/os/aix/ctype_inline.h" always uses the
system type mask, regardless of the value of _M_table.

The attached patch solve this problem for both trunk and 4.5.2.  (Due to a
change in whitespace at end of line, applying on 4.5.2 needs the '-l' flag on
patch.)  I based it on the logic used for Darwin.

(Problem appears to be present in 4.3.3 as well, but the testcase itself is
different and won't fail.)

[Bug libstdc++/47387] AIX ctype 'mask' override not working

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47387

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dje.gcc at gmail dot com

--- Comment #1 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-01-20 23:57:44 UTC ---
I have no way to test the change, I'm adding David Edelsohn in CC, maybe he can
help.

[Bug libstdc++/47387] AIX ctype 'mask' override not working

[dje at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47387

David Edelsohn <dje at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dje at gcc dot gnu.org

--- Comment #2 from David Edelsohn <dje at gcc dot gnu.org> 2011-01-23 00:22:02 UTC ---
The patch seems reasonable to me.  Is it posted as a formally posted patch
waiting for approval?

[Bug libstdc++/47387] AIX ctype 'mask' override not working

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47387

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2011.01.23 01:01:42
     Ever Confirmed|0                           |1

--- Comment #3 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-01-23 01:01:42 UTC ---
Thanks David. Indeed, please Graham post the patch to the libstdc++ mailing
list (and of course say explicitly that you regression tested it): the patch is
small enough and affects only AIX, thus if David doesn't object I believe it
can go in for 4.6.0 too.

[Bug libstdc++/47387] AIX ctype 'mask' override not working

[greed at pobox dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47387

--- Comment #4 from Graham Reed <greed at pobox dot com> 2011-01-24 15:29:55 UTC ---
OK, I'll try and get the mailing list thing worked out today.

[Bug libstdc++/47387] AIX ctype 'mask' override not working

[paolo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47387

--- Comment #5 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> 2011-01-24 19:53:38 UTC ---
Author: paolo
Date: Mon Jan 24 19:53:35 2011
New Revision: 169178

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=169178
Log:
2011-01-24  Graham Reed  <greed@pobox.com>

    PR libstdc++/47387
    * config/os/aix/ctype_inline.h (ctype<char>::is): Use _M_table if
    provided.

Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/config/os/aix/ctype_inline.h

[Bug libstdc++/47387] AIX ctype 'mask' override not working

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47387

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.6.0
           Severity|minor                       |normal

--- Comment #6 from Paolo Carlini <paolo.carlini at oracle dot com> 2011-01-24 19:54:58 UTC ---
Applied.

[Bug libstdc++/47387] AIX ctype 'mask' override not working

[dnovillo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47387

--- Comment #7 from Diego Novillo <dnovillo at gcc dot gnu.org> 2011-02-02 17:41:46 UTC ---
Author: dnovillo
Date: Wed Feb  2 17:41:43 2011
New Revision: 169539

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=169539
Log:
2011-01-24  Graham Reed  <greed@pobox.com>

    PR libstdc++/47387
    * config/os/aix/ctype_inline.h (ctype<char>::is): Use _M_table if
    provided.

Modified:
    branches/google/integration/libstdc++-v3/ChangeLog
    branches/google/integration/libstdc++-v3/config/os/aix/ctype_inline.h