[Bug libfortran/47431] New: ctime() not thread-safe

[Bug libfortran/47431] New: ctime() not thread-safe

[jb at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47431

           Summary: ctime() not thread-safe
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libfortran
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: jb@gcc.gnu.org


In libgfortran/intrinsics/ctime.c we call the POSIX ctime() function, which
need not be thread safe. Instead, we should use ctime_r() if available.

[Bug libfortran/47431] ctime() not thread-safe

[jb at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47431

Janne Blomqvist <jb at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2011.01.24 09:55:30
         AssignedTo|unassigned at gcc dot       |jb at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

[Bug libfortran/47431] ctime() not thread-safe

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47431

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu.org

--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> 2011-01-27 15:19:22 UTC ---
Janne's patch: http://gcc.gnu.org/ml/fortran/2011-01/msg00224.html

There is an POSIX-version issue (draft and final) on Solaris,
cf. http://gcc.gnu.org/ml/fortran/2011-01/msg00248.html (or related PRs 47491
and 47432).

Rainer Orth wrote:

* full standard:

  extern char *ctime_r(const time_t *, char *);

* draft standards:

  extern char *ctime_r(const time_t *, char *, int);

[Bug libfortran/47431] ctime() not thread-safe

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47431

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> 2011-01-27 15:21:48 UTC ---
(In reply to comment #1)
> (or related PRs 47491 and 47432).
(did not link. Try harder:)

PR 47491 - bootstrap error for GETLOG's getpwuid_r
           Cf. solution ideas at
           http://gcc.gnu.org/ml/fortran/2011-01/msg00245.html

PR 47432 - ttyname_r issue (not committed)

[Bug libfortran/47431] ctime() not thread-safe

[jb at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47431

--- Comment #3 from Janne Blomqvist <jb at gcc dot gnu.org> 2011-01-27 20:22:46 UTC ---
Author: jb
Date: Thu Jan 27 20:22:37 2011
New Revision: 169338

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=169338
Log:
Pr 47431 CTIME/FDATE thread-safety using ctime_r()

Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/config.h.in
    trunk/libgfortran/configure
    trunk/libgfortran/configure.ac
    trunk/libgfortran/intrinsics/ctime.c

[Bug libfortran/47431] ctime() not thread-safe

[jb at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47431

Janne Blomqvist <jb at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Janne Blomqvist <jb at gcc dot gnu.org> 2011-01-27 20:25:42 UTC ---
Fixed, closing.

[Bug libfortran/47431] ctime() not thread-safe

[dnovillo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47431

--- Comment #5 from Diego Novillo <dnovillo at gcc dot gnu.org> 2011-02-02 17:58:08 UTC ---
Author: dnovillo
Date: Wed Feb  2 17:58:02 2011
New Revision: 169655

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=169655
Log:
Pr 47431 CTIME/FDATE thread-safety using ctime_r()

Modified:
    branches/google/integration/libgfortran/ChangeLog
    branches/google/integration/libgfortran/config.h.in
    branches/google/integration/libgfortran/configure
    branches/google/integration/libgfortran/configure.ac
    branches/google/integration/libgfortran/intrinsics/ctime.c